mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-13 18:32:12 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
66 lines
2.8 KiB
TypeScript
66 lines
2.8 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const { resolveProjectRoot } = await import("../../src/lib/system/autoUpdate.ts");
|
|
|
|
test("repro-8956: resolveProjectRoot skips synthetic .build/next/package.json (no name field)", () => {
|
|
const tmp = fs.mkdtempSync(path.join(os.tmpdir(), "repro-8956-"));
|
|
try {
|
|
// Simulate a Next.js standalone build layout inside a real repo:
|
|
// <tmp>/repo/.git/ (real git marker)
|
|
// <tmp>/repo/package.json (real repo root, has a "name" field)
|
|
// <tmp>/repo/.build/next/package.json (synthetic marker, {"type":"commonjs"}, no name)
|
|
// <tmp>/repo/.build/next/server/chunks/ (where the bundled module lives at runtime)
|
|
const repoRoot = path.join(tmp, "repo");
|
|
const buildPkgDir = path.join(repoRoot, ".build", "next");
|
|
const chunksDir = path.join(buildPkgDir, "server", "chunks");
|
|
|
|
fs.mkdirSync(path.join(repoRoot, ".git"), { recursive: true });
|
|
fs.mkdirSync(chunksDir, { recursive: true });
|
|
|
|
// Real root package.json with a name
|
|
fs.writeFileSync(path.join(repoRoot, "package.json"), JSON.stringify({ name: "omniroute" }));
|
|
// Synthetic Next.js standalone build marker — no "name" field
|
|
fs.writeFileSync(path.join(buildPkgDir, "package.json"), JSON.stringify({ type: "commonjs" }));
|
|
|
|
// Start from the chunks dir (simulating __dirname at runtime)
|
|
const root = resolveProjectRoot("/fallback", chunksDir);
|
|
|
|
// Must NOT stop at .build/next — must walk up to the repo root that has .git
|
|
assert.equal(
|
|
root,
|
|
repoRoot,
|
|
`resolveProjectRoot returned ${root}, expected the repo root ${repoRoot} ` +
|
|
"(it stopped at the synthetic .build/next/package.json marker)"
|
|
);
|
|
|
|
// The resolved root must own .git so source-mode validation passes
|
|
assert.ok(
|
|
fs.existsSync(path.join(root, ".git")),
|
|
`PROJECT_ROOT resolved to ${root}, which lacks .git`
|
|
);
|
|
} finally {
|
|
fs.rmSync(tmp, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
}
|
|
});
|
|
|
|
test("repro-8956: resolveProjectRoot still finds package.json with a name field", () => {
|
|
const tmp = fs.mkdtempSync(path.join(os.tmpdir(), "repro-8956-named-"));
|
|
try {
|
|
// A normal repo root: has .git AND a named package.json
|
|
const repoRoot = path.join(tmp, "my-repo");
|
|
const subDir = path.join(repoRoot, "some", "deep", "path");
|
|
fs.mkdirSync(subDir, { recursive: true });
|
|
fs.writeFileSync(path.join(repoRoot, "package.json"), JSON.stringify({ name: "my-app" }));
|
|
fs.mkdirSync(path.join(repoRoot, ".git"), { recursive: true });
|
|
|
|
const root = resolveProjectRoot("/fallback", subDir);
|
|
assert.equal(root, repoRoot);
|
|
} finally {
|
|
fs.rmSync(tmp, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
}
|
|
});
|