mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-13 18:32:12 +03:00
Landed with the design call resolved per the owner's pick — **option 1**: the synced store is now endpoint-agnostic (persistDiscoveredModels and managedModelImport no longer drop non-chat models at write time), and chat selectability moved to read time (auto-pool expansion in autoStrategy applies filterChatSelectableModels; the models-route projection already had its chatOnly filter). Your discovery test now passes end-to-end (3/3): /api/show capabilities persist per connection and image/embedding requests route through the advertising host. Reconciliation notes: conflicted areas merged onto the current tip (adobe discovery import, requestedModel preflight signature, resolvedProvider fast-path coexists with the synced-route override — explicit resolution wins); carried base-red drains (#10055 memoization, #11071 test variants) dropped as already-landed; the managed-model-import exclusion test was propagated to the new contract (image/video models persist; the read filter still hides them from chat pickers — pinned by a new assertion). Full battery: 205/206 focused (the one red is a confirmed periodic-timer timing flake on the loaded devbox — 20/20 isolated), autoCombo vitest 30/30, combo suites 46/46, gates + typecheck clean. Thank you @yourspraveen — the capability probe + routing design was right; it just needed the store contract opened up. Fixes #11087.
53 lines
2.1 KiB
TypeScript
53 lines
2.1 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
|
|
// #9623: Failed connection test leaves testStatus=error with no recovery path.
|
|
// Previously the route wrote testStatus:"error" + rateLimitedUntil:null, which the
|
|
// lazy-recovery cooldown filter never matches (it only skips FUTURE rateLimitedUntil),
|
|
// leaving the connection permanently unavailable after a transient outage.
|
|
// Fix: non-terminal test failures now get a short future cooldown (30s) so they recover.
|
|
|
|
test("#9623 fix: non-terminal test failure sets a future rateLimitedUntil", () => {
|
|
// Simulate the fixed updateData logic
|
|
const now = Date.now();
|
|
const terminalTestStatuses = new Set(["banned", "expired", "credits_exhausted"]);
|
|
const valid = false;
|
|
const diagnosis = { code: "network_error", type: "upstream" }; // non-terminal
|
|
const isTerminalFailure = terminalTestStatuses.has(String(diagnosis.code).toLowerCase());
|
|
const testFailureCooldownMs = 30_000;
|
|
|
|
const rateLimitedUntil =
|
|
valid || isTerminalFailure
|
|
? valid
|
|
? null
|
|
: null
|
|
: new Date(now + testFailureCooldownMs).toISOString();
|
|
|
|
assert.ok(
|
|
rateLimitedUntil !== null,
|
|
"non-terminal failure should set a future rateLimitedUntil"
|
|
);
|
|
const cooldownTime = new Date(rateLimitedUntil as string).getTime();
|
|
assert.ok(
|
|
cooldownTime > now,
|
|
"rateLimitedUntil must be in the future so the lazy-recovery path retries"
|
|
);
|
|
assert.ok(
|
|
cooldownTime <= now + 30_000,
|
|
"cooldown should be bounded (30s)"
|
|
);
|
|
});
|
|
|
|
test("#9623 guard: terminal failures stay terminal (no fake recovery)", () => {
|
|
const terminalTestStatuses = new Set(["banned", "expired", "credits_exhausted"]);
|
|
const diagnosis = { code: "banned", type: "terminal" };
|
|
const isTerminalFailure = terminalTestStatuses.has(String(diagnosis.code).toLowerCase());
|
|
assert.equal(isTerminalFailure, true, "banned must be terminal");
|
|
});
|
|
|
|
test("#9623: success resets cooldown to null", () => {
|
|
const valid = true;
|
|
const rateLimitedUntil = valid ? null : new Date(Date.now() + 30_000).toISOString();
|
|
assert.equal(rateLimitedUntil, null, "successful test clears cooldown");
|
|
});
|