mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-13 18:32:12 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
93 lines
3.6 KiB
TypeScript
93 lines
3.6 KiB
TypeScript
/**
|
||
* Issue #9625 — domain_cost_history cleanup cutoff unit mismatch.
|
||
*
|
||
* cleanupDomainCostHistory() computes the cutoff in epoch seconds
|
||
* (Math.floor(Date.now() / 1000)) but the timestamp column stores
|
||
* epoch milliseconds (Date.now()), as inserted by saveCostEntry().
|
||
*
|
||
* This test seeds data using the same format as the production code
|
||
* (milliseconds), then asserts that cleanupDomainCostHistory() correctly
|
||
* deletes rows older than the retention window.
|
||
*
|
||
* Before the fix, the cutoff in seconds was ~1000× smaller than the
|
||
* stored timestamps, so the DELETE WHERE timestamp < cutoff would
|
||
* never match old rows — the cleanup was effectively a no-op.
|
||
*/
|
||
|
||
import test from "node:test";
|
||
import assert from "node:assert/strict";
|
||
import fs from "node:fs";
|
||
import os from "node:os";
|
||
import path from "node:path";
|
||
|
||
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-9625-"));
|
||
process.env.DATA_DIR = TEST_DATA_DIR;
|
||
|
||
const { cleanupDomainCostHistory } = await import("../../src/lib/db/cleanup.ts");
|
||
const { getDbInstance, resetDbInstance } = await import("../../src/lib/db/core.ts");
|
||
|
||
test.after(() => {
|
||
resetDbInstance();
|
||
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
||
});
|
||
|
||
const DAY_MS = 86_400_000; // milliseconds
|
||
|
||
test("#9625 cleanupDomainCostHistory: cutoff in ms matches production timestamps", async () => {
|
||
const db = getDbInstance()!;
|
||
const now = Date.now(); // milliseconds — same as saveCostEntry() default
|
||
|
||
const insert = db.prepare(
|
||
"INSERT INTO domain_cost_history (api_key_id, cost, timestamp) VALUES (?, ?, ?)"
|
||
);
|
||
|
||
// Seed data using millisecond timestamps (production format).
|
||
// 3 old rows: 40 days ago (should be deleted)
|
||
// 2 recent rows: 5 days ago (should be kept)
|
||
insert.run("key1", 1.0, now - 40 * DAY_MS);
|
||
insert.run("key1", 2.0, now - 40 * DAY_MS);
|
||
insert.run("key1", 3.0, now - 40 * DAY_MS);
|
||
insert.run("key1", 4.0, now - 5 * DAY_MS);
|
||
insert.run("key1", 5.0, now - 5 * DAY_MS);
|
||
|
||
const result = await cleanupDomainCostHistory();
|
||
|
||
// Before the fix, cutoff was in seconds (~1.7e9) while timestamps
|
||
// are in milliseconds (~1.7e12). The comparison `WHERE ts < 1.7e9`
|
||
// would never match rows with ts ~1.7e12, so nothing was deleted.
|
||
assert.strictEqual(result.deleted, 3, "Should delete 3 old rows (40 days old)");
|
||
assert.strictEqual(result.errors, 0);
|
||
|
||
const remaining = db.prepare("SELECT COUNT(*) as cnt FROM domain_cost_history").get() as {
|
||
cnt: number;
|
||
};
|
||
assert.strictEqual(remaining.cnt, 2, "Should keep 2 recent rows (5 days old)");
|
||
});
|
||
|
||
test("#9625 unit mismatch: seconds cutoff would NOT match ms timestamps", () => {
|
||
// Demonstrate the arithmetic bug: a cutoff in seconds is ~1000×
|
||
// smaller than a millisecond timestamp, so the WHERE clause never
|
||
// matches production data.
|
||
const nowMs = Date.now();
|
||
const nowSec = Math.floor(nowMs / 1000);
|
||
const retentionDays = 30;
|
||
const cutoffSec = nowSec - retentionDays * 86_400; // seconds
|
||
const cutoffMs = nowMs - retentionDays * 86_400_000; // milliseconds
|
||
|
||
// A row inserted 40 days ago with a millisecond timestamp:
|
||
const oldRowMs = nowMs - 40 * 86_400_000; // ~1.7e12
|
||
|
||
// With seconds cutoff: oldRowMs (1.7e12) < cutoffSec (1.7e9) is FALSE
|
||
// because 1.7e12 > 1.7e9 — the row is never matched.
|
||
assert.ok(
|
||
oldRowMs > cutoffSec,
|
||
"Bug: ms timestamp is NOT less than seconds cutoff, so row is never deleted"
|
||
);
|
||
|
||
// With milliseconds cutoff: oldRowMs (1.7e12) < cutoffMs (1.7e12) is TRUE
|
||
assert.ok(
|
||
oldRowMs < cutoffMs,
|
||
"Fix: ms timestamp IS less than ms cutoff, so row is correctly deleted"
|
||
);
|
||
});
|