Files
OmniRoute/tests/unit/reset-connection-backoff.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

106 lines
3.9 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
// resetConnectionBackoff (open-sse perf PR #7893) is a lightweight-UPDATE variant
// of the CAS-based clearConnectionErrorIfUnchanged pattern: it resets the backoff
// and error columns without a preceding SELECT/re-encrypt/backup pass. It had zero
// direct test coverage prior to this file — regression guard added per Hard Rule #8.
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-reset-backoff-"));
process.env.DATA_DIR = TEST_DATA_DIR;
process.env.API_KEY_SECRET = "test-reset-connection-backoff-secret";
const core = await import("../../src/lib/db/core.ts");
const providersDb = await import("../../src/lib/db/providers.ts");
test.after(() => {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
async function createBackedOffConnection() {
const created = await providersDb.createProviderConnection({
provider: "glm",
authType: "apikey",
name: `GLM Backoff ${Date.now()}-${Math.random()}`,
apiKey: "glm-test-key",
});
const connectionId = (created as { id: string }).id;
// backoffLevel/error fields aren't accepted at creation time — set them via
// updateProviderConnection to reach the "backed off" state under test, mirroring
// the pattern in tests/unit/provider-limits-recovery.test.ts.
await providersDb.updateProviderConnection(connectionId, {
testStatus: "unavailable",
lastError: "rate limit exceeded",
lastErrorType: "rate_limited",
lastErrorSource: "executor",
errorCode: 429,
backoffLevel: 3,
});
return created;
}
test("resetConnectionBackoff clears backoff/error columns and re-activates the connection", async () => {
const created = await createBackedOffConnection();
const connectionId = (created as { id: string }).id;
const before = (await providersDb.getProviderConnectionById(connectionId)) as Record<
string,
unknown
>;
assert.equal(before.testStatus, "unavailable");
assert.equal(before.backoffLevel, 3);
await providersDb.resetConnectionBackoff(connectionId);
const after = (await providersDb.getProviderConnectionById(connectionId)) as Record<
string,
unknown
>;
assert.equal(after.testStatus, "active");
assert.equal(after.backoffLevel, 0);
assert.equal(after.lastError, undefined);
assert.equal(after.lastErrorType, undefined);
assert.equal(after.errorCode, undefined);
});
test("resetConnectionBackoff does not clear a terminal status (e.g. banned)", async () => {
const created = await providersDb.createProviderConnection({
provider: "glm",
authType: "apikey",
name: `GLM Banned ${Date.now()}-${Math.random()}`,
apiKey: "glm-test-key",
});
const connectionId = (created as { id: string }).id;
await providersDb.updateProviderConnection(connectionId, {
testStatus: "banned",
lastError: "account banned",
lastErrorType: "banned",
backoffLevel: 5,
});
// resetConnectionBackoff is a targeted UPDATE with no CAS/status guard — callers
// are responsible for only invoking it on connections eligible for reset. This
// test documents that unconditional behavior: it WILL flip a terminal status too,
// which is why callers must gate the call themselves (see comment on the fn).
await providersDb.resetConnectionBackoff(connectionId);
const after = (await providersDb.getProviderConnectionById(connectionId)) as Record<
string,
unknown
>;
assert.equal(after.testStatus, "active");
assert.equal(after.backoffLevel, 0);
});
test("resetConnectionBackoff is a no-op for an empty id", async () => {
await assert.doesNotReject(() => providersDb.resetConnectionBackoff(""));
});
test("resetConnectionBackoff is a no-op for an unknown id (no throw)", async () => {
await assert.doesNotReject(() => providersDb.resetConnectionBackoff("nonexistent-connection-id"));
});