mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-14 02:42:24 +03:00
65e81158ab
Landed with the design call resolved per the owner's pick — **option 1**: the synced store is now endpoint-agnostic (persistDiscoveredModels and managedModelImport no longer drop non-chat models at write time), and chat selectability moved to read time (auto-pool expansion in autoStrategy applies filterChatSelectableModels; the models-route projection already had its chatOnly filter). Your discovery test now passes end-to-end (3/3): /api/show capabilities persist per connection and image/embedding requests route through the advertising host. Reconciliation notes: conflicted areas merged onto the current tip (adobe discovery import, requestedModel preflight signature, resolvedProvider fast-path coexists with the synced-route override — explicit resolution wins); carried base-red drains (#10055 memoization, #11071 test variants) dropped as already-landed; the managed-model-import exclusion test was propagated to the new contract (image/video models persist; the read filter still hides them from chat pickers — pinned by a new assertion). Full battery: 205/206 focused (the one red is a confirmed periodic-timer timing flake on the loaded devbox — 20/20 isolated), autoCombo vitest 30/30, combo suites 46/46, gates + typecheck clean. Thank you @yourspraveen — the capability probe + routing design was right; it just needed the store contract opened up. Fixes #11087.
52 lines
1.8 KiB
TypeScript
52 lines
1.8 KiB
TypeScript
import assert from "node:assert/strict";
|
|
import { describe, it } from "node:test";
|
|
import { resolveModelAlias } from "../../src/shared/constants/modelSpecs.ts";
|
|
|
|
describe("resolveModelAlias lookup index (#8697-adjacent)", () => {
|
|
it("still resolves a known exact alias", () => {
|
|
// Real MODEL_SPECS alias, case-sensitive exact match.
|
|
assert.equal(resolveModelAlias("openai/gpt-5.6"), "gpt-5.6");
|
|
});
|
|
|
|
it("does not match a case-varied alias (case-sensitive semantics preserved)", () => {
|
|
// resolveModelAlias uses Array.includes(), never .toLowerCase() — a case-varied
|
|
// input must NOT resolve, unlike the case-insensitive getCanonicalModelSpecId().
|
|
assert.equal(resolveModelAlias("OpenAI/GPT-5.6"), "OpenAI/GPT-5.6");
|
|
});
|
|
|
|
it("returns the input unchanged for an unknown alias", () => {
|
|
assert.equal(
|
|
resolveModelAlias("definitely-not-a-real-alias-xyz"),
|
|
"definitely-not-a-real-alias-xyz"
|
|
);
|
|
});
|
|
|
|
it("does not rescan MODEL_SPECS per call (regression guard for O(n) scans)", () => {
|
|
// Warm up outside the measured window.
|
|
resolveModelAlias("openai/gpt-5.6");
|
|
|
|
const originalEntries = Object.entries;
|
|
let calls = 0;
|
|
Object.entries = function patchedEntries(...args: Parameters<typeof Object.entries>) {
|
|
calls++;
|
|
return originalEntries.apply(this, args as never);
|
|
} as typeof Object.entries;
|
|
|
|
try {
|
|
for (let i = 0; i < 500; i++) {
|
|
resolveModelAlias("openai/gpt-5.6");
|
|
}
|
|
} finally {
|
|
Object.entries = originalEntries;
|
|
}
|
|
|
|
// Pre-fix: every call re-ran Object.entries(MODEL_SPECS). Indexed: the lazy
|
|
// index is built once and reused, so no further Object.entries calls happen.
|
|
assert.equal(
|
|
calls,
|
|
0,
|
|
`expected 0 Object.entries() calls across 500 repeated lookups, got ${calls}`
|
|
);
|
|
});
|
|
});
|