mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-17 20:32:25 +03:00
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
101 lines
3.6 KiB
TypeScript
101 lines
3.6 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
import { readFileSync } from "node:fs";
|
|
|
|
import { resolveResponsesApiModel } from "../../src/app/api/internal/codex-responses-ws/modelResolution.ts";
|
|
|
|
const resolver = async (modelStr: string) => {
|
|
if (modelStr.startsWith("codex/")) {
|
|
return { provider: "codex", model: modelStr.slice("codex/".length) };
|
|
}
|
|
return { provider: "openrouter", model: modelStr };
|
|
};
|
|
|
|
test("case-insensitive combo match prevents Codex rewrite on /v1/responses", async () => {
|
|
const storedComboName = "GPT-5.6-SOL";
|
|
const isCombo = async (name: string) => name.toLowerCase() === storedComboName.toLowerCase();
|
|
|
|
const result = await resolveResponsesApiModel("gpt-5.6-sol", resolver, isCombo);
|
|
|
|
assert.equal(result.changed, false);
|
|
assert.equal(result.model, "gpt-5.6-sol");
|
|
});
|
|
|
|
test("bare codex model is still rewritten when not a combo (Codex preference preserved)", async () => {
|
|
const isCombo = async () => false;
|
|
|
|
const result = await resolveResponsesApiModel("gpt-5.5", resolver, isCombo);
|
|
|
|
assert.equal(result.changed, true);
|
|
assert.equal(result.model, "codex/gpt-5.5");
|
|
});
|
|
|
|
test("provider-prefixed models pass through unchanged", async () => {
|
|
const isCombo = async () => false;
|
|
|
|
for (const model of ["anthropic/claude-opus-4-8", "codex/gpt-5.5", "combo/my-combo"]) {
|
|
const result = await resolveResponsesApiModel(model, resolver, isCombo);
|
|
assert.equal(result.changed, false, `${model} must not be marked as changed`);
|
|
assert.equal(result.model, model, `${model} must pass through unchanged`);
|
|
}
|
|
});
|
|
|
|
test("Responses route uses the downstream combo resolver for the Codex rewrite guard", () => {
|
|
const source = readFileSync(
|
|
new URL("../../src/app/api/v1/responses/route.ts", import.meta.url),
|
|
"utf8"
|
|
);
|
|
|
|
assert.match(
|
|
source,
|
|
/import \{ getModelInfo, getComboForModel \} from "@\/sse\/services\/model"/
|
|
);
|
|
assert.match(source, /async \(name\) => !!\(await getComboForModel\(name\)\)/);
|
|
assert.doesNotMatch(source, /getComboByName\(name\)/);
|
|
});
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(
|
|
path.join(os.tmpdir(), "omniroute-responses-ci-" + Date.now())
|
|
);
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const combosDb = await import("../../src/lib/db/combos.ts");
|
|
const sseModelService = await import("../../src/sse/services/model.ts");
|
|
|
|
test.after(() => {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
test("getComboForModel resolves a stored combo by a case-insensitive request name", async () => {
|
|
core.resetDbInstance();
|
|
|
|
await combosDb.createCombo({
|
|
name: "GPT-5.6-SOL",
|
|
models: [{ provider: "openrouter", model: "gpt-5.6" }],
|
|
});
|
|
|
|
const resolved = await sseModelService.getComboForModel("gpt-5.6-sol");
|
|
assert.ok(resolved, "expected lowercased request to resolve to the stored GPT-5.6-SOL combo");
|
|
assert.equal((resolved as { name: string }).name, "GPT-5.6-SOL");
|
|
});
|
|
|
|
test("real getComboForModel predicate prevents the Codex rewrite on /v1/responses", async () => {
|
|
core.resetDbInstance();
|
|
|
|
await combosDb.createCombo({
|
|
name: "Archon-Gate-9",
|
|
models: [{ provider: "openrouter", model: "gpt-5.6" }],
|
|
});
|
|
|
|
const isCombo = async (name: string) => !!(await sseModelService.getComboForModel(name));
|
|
|
|
const result = await resolveResponsesApiModel("archon-gate-9", resolver, isCombo);
|
|
assert.equal(result.changed, false);
|
|
assert.equal(result.model, "archon-gate-9");
|
|
});
|