mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-13 18:32:12 +03:00
65e81158ab
Landed with the design call resolved per the owner's pick — **option 1**: the synced store is now endpoint-agnostic (persistDiscoveredModels and managedModelImport no longer drop non-chat models at write time), and chat selectability moved to read time (auto-pool expansion in autoStrategy applies filterChatSelectableModels; the models-route projection already had its chatOnly filter). Your discovery test now passes end-to-end (3/3): /api/show capabilities persist per connection and image/embedding requests route through the advertising host. Reconciliation notes: conflicted areas merged onto the current tip (adobe discovery import, requestedModel preflight signature, resolvedProvider fast-path coexists with the synced-route override — explicit resolution wins); carried base-red drains (#10055 memoization, #11071 test variants) dropped as already-landed; the managed-model-import exclusion test was propagated to the new contract (image/video models persist; the read filter still hides them from chat pickers — pinned by a new assertion). Full battery: 205/206 focused (the one red is a confirmed periodic-timer timing flake on the loaded devbox — 20/20 isolated), autoCombo vitest 30/30, combo suites 46/46, gates + typecheck clean. Thank you @yourspraveen — the capability probe + routing design was right; it just needed the store contract opened up. Fixes #11087.
48 lines
2.3 KiB
TypeScript
48 lines
2.3 KiB
TypeScript
import assert from "node:assert/strict";
|
|
import { describe, it } from "node:test";
|
|
import { getResolvedModelCapabilities } from "../../src/lib/modelCapabilities.ts";
|
|
import { MODELS_DEV_PROVIDER_MAP } from "../../src/lib/modelsDevSync/transform.ts";
|
|
|
|
describe("reverseModelsDevProviders memoization (#8697-adjacent)", () => {
|
|
it("stays correct across repeated calls for the same provider", () => {
|
|
// codex/claude only list their alias (cx/cc) in MODELS_DEV_PROVIDER_MAP — exercises
|
|
// the reverse-lookup fallback this function builds (#8429).
|
|
const first = getResolvedModelCapabilities({ provider: "codex", model: "gpt-5.6" });
|
|
const second = getResolvedModelCapabilities({ provider: "codex", model: "gpt-5.6" });
|
|
assert.deepEqual(first, second, "memoized reverse-provider lookup must not change results");
|
|
});
|
|
|
|
it("does not rescan MODELS_DEV_PROVIDER_MAP per call (regression guard for O(n) scans)", () => {
|
|
// Warm up outside the measured window.
|
|
getResolvedModelCapabilities({ provider: "codex", model: "gpt-5.6" });
|
|
|
|
// getResolvedModelCapabilities' wider call chain legitimately calls Object.entries()
|
|
// on unrelated objects (e.g. once per call, elsewhere in the chain) — count only calls
|
|
// targeting MODELS_DEV_PROVIDER_MAP specifically, the object reverseModelsDevProviders()
|
|
// scans, to isolate this fix's contribution precisely.
|
|
const originalEntries = Object.entries;
|
|
let mapScans = 0;
|
|
Object.entries = function patchedEntries(...args: Parameters<typeof Object.entries>) {
|
|
if (args[0] === MODELS_DEV_PROVIDER_MAP) mapScans++;
|
|
return originalEntries.apply(this, args as never);
|
|
} as typeof Object.entries;
|
|
|
|
try {
|
|
for (let i = 0; i < 300; i++) {
|
|
getResolvedModelCapabilities({ provider: "codex", model: "gpt-5.6" });
|
|
}
|
|
} finally {
|
|
Object.entries = originalEntries;
|
|
}
|
|
|
|
// Pre-fix: reverseModelsDevProviders() rescanned Object.entries(MODELS_DEV_PROVIDER_MAP)
|
|
// on every call → mapScans would be ~300. Memoized by provider key: 0 scans once the
|
|
// "codex" entry is cached (the warm-up call above already populated it).
|
|
assert.equal(
|
|
mapScans,
|
|
0,
|
|
`expected 0 Object.entries(MODELS_DEV_PROVIDER_MAP) scans across 300 repeated calls, got ${mapScans}`
|
|
);
|
|
});
|
|
});
|