mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-13 18:32:12 +03:00
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
129 lines
3.7 KiB
TypeScript
129 lines
3.7 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import { mkdirSync, mkdtempSync, rmSync, writeFileSync } from "node:fs";
|
|
import { tmpdir } from "node:os";
|
|
import { join } from "node:path";
|
|
import { spawnSync } from "node:child_process";
|
|
|
|
const trendsScript = "scripts/router-eval/trends.ts";
|
|
|
|
function artifact(generatedAt: string, configId: string, aiq: number) {
|
|
return {
|
|
schemaVersion: 1,
|
|
kind: "router-eval-report",
|
|
generatedAt,
|
|
report: {
|
|
evaluatedAt: generatedAt,
|
|
summary: {
|
|
totalSamples: 1,
|
|
validSamples: 1,
|
|
droppedSamples: 0,
|
|
uniqueConfigs: 1,
|
|
},
|
|
configurations: [],
|
|
frontier: [],
|
|
top: [
|
|
{
|
|
configId,
|
|
samples: 1,
|
|
successRate: 1,
|
|
avgLatencyMs: 100,
|
|
p50LatencyMs: 100,
|
|
p95LatencyMs: 100,
|
|
avgCostUsd: 0.004,
|
|
aiq,
|
|
},
|
|
],
|
|
},
|
|
};
|
|
}
|
|
|
|
test("router eval trends reads retained and flat artifacts with limit", () => {
|
|
const dir = mkdtempSync(join(tmpdir(), "router-eval-trends-"));
|
|
const runA = join(dir, "run-a");
|
|
const runB = join(dir, "run-b");
|
|
mkdirSync(runA);
|
|
mkdirSync(runB);
|
|
writeFileSync(
|
|
join(runA, "router-eval.json"),
|
|
JSON.stringify(artifact("2026-01-01T00:00:00.000Z", "old", 80))
|
|
);
|
|
writeFileSync(
|
|
join(runB, "router-eval.json"),
|
|
JSON.stringify(artifact("2026-01-02T00:00:00.000Z", "new", 90))
|
|
);
|
|
writeFileSync(
|
|
join(dir, "flat.json"),
|
|
JSON.stringify(artifact("2026-01-03T00:00:00.000Z", "flat", 95))
|
|
);
|
|
writeFileSync(join(dir, "bad.json"), "{not json");
|
|
|
|
const result = spawnSync(
|
|
process.execPath,
|
|
["--import", "tsx", trendsScript, "--artifact-dir", dir, "--limit", "2"],
|
|
{
|
|
encoding: "utf8",
|
|
}
|
|
);
|
|
|
|
try {
|
|
assert.equal(result.status, 0);
|
|
assert.ok((result.stdout ?? "").includes("Router Eval Trends"));
|
|
assert.ok(!(result.stdout ?? "").includes("run-a"));
|
|
assert.ok((result.stdout ?? "").includes("run-b"));
|
|
assert.ok((result.stdout ?? "").includes("flat"));
|
|
} finally {
|
|
rmSync(dir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
}
|
|
});
|
|
|
|
test("router eval trends can print dashboard summaries", () => {
|
|
const dir = mkdtempSync(join(tmpdir(), "router-eval-dashboard-"));
|
|
const runA = join(dir, "run-a");
|
|
const runB = join(dir, "run-b");
|
|
mkdirSync(runA);
|
|
mkdirSync(runB);
|
|
writeFileSync(
|
|
join(runA, "router-eval.json"),
|
|
JSON.stringify(artifact("2026-01-01T00:00:00.000Z", "old", 80))
|
|
);
|
|
writeFileSync(
|
|
join(runB, "router-eval.json"),
|
|
JSON.stringify(artifact("2026-01-02T00:00:00.000Z", "new", 90))
|
|
);
|
|
|
|
const result = spawnSync(
|
|
process.execPath,
|
|
["--import", "tsx", trendsScript, "--artifact-dir", dir, "--dashboard"],
|
|
{
|
|
encoding: "utf8",
|
|
}
|
|
);
|
|
|
|
try {
|
|
assert.equal(result.status, 0);
|
|
assert.ok((result.stdout ?? "").includes("Router Eval Dashboard"));
|
|
assert.ok((result.stdout ?? "").includes("Latest: run-b"));
|
|
assert.ok((result.stdout ?? "").includes("AIQ: 90.000 (+10.000)"));
|
|
assert.ok((result.stdout ?? "").includes("Rolling Averages"));
|
|
} finally {
|
|
rmSync(dir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
}
|
|
});
|
|
|
|
test("router eval trends exits clearly for empty artifact dirs", () => {
|
|
const dir = mkdtempSync(join(tmpdir(), "router-eval-trends-empty-"));
|
|
const result = spawnSync(
|
|
process.execPath,
|
|
["--import", "tsx", trendsScript, "--artifact-dir", dir],
|
|
{ encoding: "utf8" }
|
|
);
|
|
|
|
try {
|
|
assert.equal(result.status, 2);
|
|
assert.ok((result.stderr ?? "").includes("No router-eval artifacts found"));
|
|
} finally {
|
|
rmSync(dir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
}
|
|
});
|