mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-14 10:52:17 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
62 lines
2.7 KiB
TypeScript
62 lines
2.7 KiB
TypeScript
import { test } from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import { spawnSync } from "node:child_process";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
import { fileURLToPath } from "node:url";
|
|
|
|
// Regression guards for the Sonar quality-gate fixes (release PR #6569 findings).
|
|
// Two classes of real defect are locked down here:
|
|
// 1. jssecurity:S8707 — classify-pr-changes.mjs read any path handed on argv;
|
|
// the CLI now confines the list file to the working directory.
|
|
// 2. typescript:S6544 — `isCloudEnabled()` is async; a bare `if (isCloudEnabled())`
|
|
// is always truthy, so cloud sync ran even with cloud disabled.
|
|
|
|
const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), "../..");
|
|
const CLASSIFY = path.join(ROOT, "scripts", "quality", "classify-pr-changes.mjs");
|
|
|
|
test("classify-pr-changes rejects a list path that escapes the workspace", () => {
|
|
const cwd = fs.mkdtempSync(path.join(os.tmpdir(), "classify-guard-"));
|
|
try {
|
|
const outside = path.join(os.tmpdir(), "classify-outside.txt");
|
|
fs.writeFileSync(outside, "src/lib/db/core.ts\n");
|
|
const res = spawnSync(process.execPath, [CLASSIFY, outside], {
|
|
cwd,
|
|
encoding: "utf8",
|
|
});
|
|
assert.equal(res.status, 1, `expected exit 1, got ${res.status}\n${res.stdout}${res.stderr}`);
|
|
assert.match(res.stderr, /escapes the workspace/);
|
|
fs.rmSync(outside, { force: true });
|
|
} finally {
|
|
fs.rmSync(cwd, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
}
|
|
});
|
|
|
|
test("classify-pr-changes still accepts a workspace-relative list file", () => {
|
|
const cwd = fs.mkdtempSync(path.join(os.tmpdir(), "classify-ok-"));
|
|
try {
|
|
fs.writeFileSync(path.join(cwd, "changed-files.txt"), "docs/README.md\n");
|
|
const res = spawnSync(process.execPath, [CLASSIFY, "changed-files.txt"], {
|
|
cwd,
|
|
encoding: "utf8",
|
|
});
|
|
assert.equal(res.status, 0, `expected exit 0, got ${res.status}\n${res.stderr}`);
|
|
assert.match(res.stdout, /docs=true/);
|
|
assert.match(res.stdout, /code=false/);
|
|
} finally {
|
|
fs.rmSync(cwd, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
}
|
|
});
|
|
|
|
test("kiro auto-import awaits the async isCloudEnabled() gate (S6544)", () => {
|
|
const src = fs.readFileSync(
|
|
path.join(ROOT, "src", "app", "api", "oauth", "kiro", "auto-import", "route.ts"),
|
|
"utf8"
|
|
);
|
|
// `isCloudEnabled()` returns a Promise — a bare truthiness check is always true,
|
|
// which made syncToCloud() run even when cloud sync is disabled.
|
|
assert.doesNotMatch(src, /if\s*\(\s*isCloudEnabled\(\)/, "bare `if (isCloudEnabled())` found");
|
|
assert.match(src, /if\s*\(\s*await isCloudEnabled\(\)/);
|
|
});
|