mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-14 02:42:24 +03:00
65e81158ab
Landed with the design call resolved per the owner's pick — **option 1**: the synced store is now endpoint-agnostic (persistDiscoveredModels and managedModelImport no longer drop non-chat models at write time), and chat selectability moved to read time (auto-pool expansion in autoStrategy applies filterChatSelectableModels; the models-route projection already had its chatOnly filter). Your discovery test now passes end-to-end (3/3): /api/show capabilities persist per connection and image/embedding requests route through the advertising host. Reconciliation notes: conflicted areas merged onto the current tip (adobe discovery import, requestedModel preflight signature, resolvedProvider fast-path coexists with the synced-route override — explicit resolution wins); carried base-red drains (#10055 memoization, #11071 test variants) dropped as already-landed; the managed-model-import exclusion test was propagated to the new contract (image/video models persist; the read filter still hides them from chat pickers — pinned by a new assertion). Full battery: 205/206 focused (the one red is a confirmed periodic-timer timing flake on the loaded devbox — 20/20 isolated), autoCombo vitest 30/30, combo suites 46/46, gates + typecheck clean. Thank you @yourspraveen — the capability probe + routing design was right; it just needed the store contract opened up. Fixes #11087.
40 lines
1.6 KiB
TypeScript
40 lines
1.6 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import { sseCommentsEnabled } from "../../open-sse/utils/sseHeartbeat.ts";
|
|
|
|
// #10524: SSE comment lines (`: x-omniroute-*`) break strict SSE clients.
|
|
// Default should be disabled (opt-in via OMNIROUTE_SSE_COMMENTS=on).
|
|
|
|
test("#10524: sseCommentsEnabled defaults to false when env var is unset", () => {
|
|
const original = process.env.OMNIROUTE_SSE_COMMENTS;
|
|
delete process.env.OMNIROUTE_SSE_COMMENTS;
|
|
|
|
assert.strictEqual(sseCommentsEnabled(), false, "SSE comments must be disabled by default");
|
|
|
|
if (original !== undefined) process.env.OMNIROUTE_SSE_COMMENTS = original;
|
|
});
|
|
|
|
test("#10524: sseCommentsEnabled returns true when explicitly enabled", () => {
|
|
const original = process.env.OMNIROUTE_SSE_COMMENTS;
|
|
|
|
for (const value of ["on", "true", "1", "yes", "ON", "TRUE"]) {
|
|
process.env.OMNIROUTE_SSE_COMMENTS = value;
|
|
assert.strictEqual(sseCommentsEnabled(), true, `SSE comments must be enabled for "${value}"`);
|
|
}
|
|
|
|
if (original !== undefined) process.env.OMNIROUTE_SSE_COMMENTS = original;
|
|
else delete process.env.OMNIROUTE_SSE_COMMENTS;
|
|
});
|
|
|
|
test("#10524: sseCommentsEnabled returns false when explicitly disabled", () => {
|
|
const original = process.env.OMNIROUTE_SSE_COMMENTS;
|
|
|
|
for (const value of ["off", "false", "0", "no", "OFF", "FALSE"]) {
|
|
process.env.OMNIROUTE_SSE_COMMENTS = value;
|
|
assert.strictEqual(sseCommentsEnabled(), false, `SSE comments must be disabled for "${value}"`);
|
|
}
|
|
|
|
if (original !== undefined) process.env.OMNIROUTE_SSE_COMMENTS = original;
|
|
else delete process.env.OMNIROUTE_SSE_COMMENTS;
|
|
});
|