Files
OmniRoute/tests/unit/stream-failure-499-classification.test.ts
Praveen K Palaniswamy 65e81158ab fix(ollama): route models by advertised capability (#11088)
Landed with the design call resolved per the owner's pick — **option 1**: the synced store is now endpoint-agnostic (persistDiscoveredModels and managedModelImport no longer drop non-chat models at write time), and chat selectability moved to read time (auto-pool expansion in autoStrategy applies filterChatSelectableModels; the models-route projection already had its chatOnly filter). Your discovery test now passes end-to-end (3/3): /api/show capabilities persist per connection and image/embedding requests route through the advertising host.

Reconciliation notes: conflicted areas merged onto the current tip (adobe discovery import, requestedModel preflight signature, resolvedProvider fast-path coexists with the synced-route override — explicit resolution wins); carried base-red drains (#10055 memoization, #11071 test variants) dropped as already-landed; the managed-model-import exclusion test was propagated to the new contract (image/video models persist; the read filter still hides them from chat pickers — pinned by a new assertion). Full battery: 205/206 focused (the one red is a confirmed periodic-timer timing flake on the loaded devbox — 20/20 isolated), autoCombo vitest 30/30, combo suites 46/46, gates + typecheck clean.

Thank you @yourspraveen — the capability probe + routing design was right; it just needed the store contract opened up. Fixes #11087.
2026-08-23 11:45:01 -03:00

63 lines
2.0 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
const { createStreamFailureFinalizers } = await import(
"../../open-sse/utils/streamFailureFinalization.ts"
);
test("createStreamFailureFinalizers: 499 client disconnect body is client_disconnected", () => {
let captured: { status: number; responseBody: unknown; errorCode?: string | null } | null =
null;
const { onPipelineStreamError } = createStreamFailureFinalizers({
isFailureCompletionRecorded: () => false,
onStreamComplete: (payload) => {
captured = {
status: payload.status,
responseBody: payload.responseBody,
errorCode: payload.errorCode,
};
},
persistFailureUsage: () => {},
});
onPipelineStreamError({
message: "Client disconnected: request_signal_aborted",
statusCode: 499,
});
assert.ok(captured, "onStreamComplete must fire");
assert.equal(captured.status, 499);
assert.equal(captured.errorCode, "client_disconnected");
const body = captured.responseBody as {
error: { type?: string; code?: string; message: string };
};
assert.equal(body.error.type, "client_disconnected");
assert.equal(body.error.code, "client_disconnected");
});
test("createStreamFailureFinalizers: caller classification survives into response body", () => {
let captured: unknown = null;
const { handleStreamFailure } = createStreamFailureFinalizers({
isFailureCompletionRecorded: () => false,
onStreamComplete: (payload) => {
captured = payload.responseBody;
},
persistFailureUsage: () => {},
});
const handled = handleStreamFailure({
status: 502,
message: "Upstream stream error",
code: "stream_pipeline_error",
type: "stream_error",
});
assert.equal(handled, true, "the callback contract reports that the stream failure was handled");
const body = captured as { error: { type?: string; code?: string } };
assert.equal(body.error.type, "stream_error");
assert.equal(body.error.code, "stream_pipeline_error");
});