mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-13 18:32:12 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
43 lines
2.0 KiB
TypeScript
43 lines
2.0 KiB
TypeScript
// Guard: the test suite must NEVER touch the OS trust store. On 2026-07-05 the
|
|
// integration test "POST /cert: installs trust when cert exists" ran the REAL
|
|
// install path on a persistent self-hosted runner and wrote a 105-byte fake PEM
|
|
// into /usr/local/share/ca-certificates — update-ca-certificates then baked the
|
|
// invalid entry into ca-certificates.crt and broke ALL system TLS on the VM
|
|
// (curl error 77, apt cert failures, corrupted artifact downloads). Hosted
|
|
// runners are ephemeral, so the same write went unnoticed for months.
|
|
//
|
|
// OMNIROUTE_SKIP_SYSTEM_TRUST=1 (set globally in tests/_setup/isolateDataDir.ts)
|
|
// makes installCert/uninstallCert no-ops before any filesystem/spawn work.
|
|
import { test } from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
import { installCert } from "../../src/mitm/cert/install.ts";
|
|
|
|
test("isolateDataDir setup exports the system-trust guard for every test process", () => {
|
|
assert.equal(process.env.OMNIROUTE_SKIP_SYSTEM_TRUST, "1");
|
|
});
|
|
|
|
test("installCert under the guard skips the OS mutation but keeps input contracts", async () => {
|
|
// Contract preserved: a missing cert file still throws (agent-bridge fallback
|
|
// #4546 depends on it to build the environment-skip result).
|
|
await assert.rejects(() => installCert("", "/nonexistent/omniroute-guard-test.pem"));
|
|
|
|
// With a REAL (fake-content) cert file, the un-guarded path would go on to
|
|
// sudo/update-ca-certificates — under the guard it must resolve without
|
|
// mutating the OS trust store (this exact write bricked the VM's TLS).
|
|
const dir = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-trust-guard-"));
|
|
const pem = path.join(dir, "omniroute-guard-test.pem");
|
|
fs.writeFileSync(
|
|
pem,
|
|
"-----BEGIN CERTIFICATE-----\nMIIBpDCCAQ2gAwIBAgIUFakeGuardCertXX==\n-----END CERTIFICATE-----\n"
|
|
);
|
|
try {
|
|
await installCert("", pem);
|
|
} finally {
|
|
fs.rmSync(dir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
}
|
|
});
|