Files
OmniRoute/tests/unit/tag-routing.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

166 lines
5.1 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-tag-routing-"));
process.env.DATA_DIR = TEST_DATA_DIR;
const core = await import("../../src/lib/db/core.ts");
const providersDb = await import("../../src/lib/db/providers.ts");
const { handleComboChat } = await import("../../open-sse/services/combo.ts");
const { getConnectionRoutingTags, matchesRoutingTags, resolveRequestRoutingTags } =
await import("../../src/domain/tagRouter.ts");
function createLog() {
return {
info() {},
warn() {},
debug() {},
error() {},
};
}
function okResponse(content: string) {
return new Response(
JSON.stringify({
choices: [{ message: { content } }],
}),
{
status: 200,
headers: { "content-type": "application/json" },
}
);
}
async function resetStorage() {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
}
async function seedConnection(provider: string, name: string, tags: string[]) {
return providersDb.createProviderConnection({
provider,
authType: "apikey",
name,
apiKey: `sk-${name}`,
providerSpecificData: { tags },
isActive: true,
});
}
test.beforeEach(async () => {
await resetStorage();
});
test.after(async () => {
await resetStorage();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
test("tag router normalizes request metadata and matches connection tags", () => {
const resolved = resolveRequestRoutingTags({
metadata: {
tags: [" Fast ", "cheap", "FAST"],
tag_match_mode: "all",
},
});
assert.deepEqual(resolved.tags, ["fast", "cheap"]);
assert.equal(resolved.matchMode, "all");
assert.deepEqual(getConnectionRoutingTags({ tags: ["Cheap", "EU-Region"] }), [
"cheap",
"eu-region",
]);
assert.equal(matchesRoutingTags(["cheap", "fast"], ["cheap"], "any"), true);
assert.equal(matchesRoutingTags(["cheap"], ["cheap", "fast"], "all"), false);
});
test("handleComboChat filters priority targets by metadata.tags using any-match by default", async () => {
const reliable = await seedConnection("openai", "reliable", ["reliable", "us-region"]);
const cheap = await seedConnection("fireworks", "cheap", ["cheap", "fast"]);
const attempts: Array<{ model: string; allowedConnectionIds: string[] | null }> = [];
const response = await handleComboChat({
body: {
model: "router",
messages: [{ role: "user", content: "route this cheaply" }],
metadata: { tags: ["cheap"] },
},
combo: {
name: "router",
strategy: "priority",
models: ["openai/gpt-4o-mini", "fireworks/gpt-4o-mini"],
},
handleSingleModel: async (_body, modelStr, target) => {
attempts.push({
model: modelStr,
allowedConnectionIds: Array.isArray(target?.allowedConnectionIds)
? target.allowedConnectionIds
: null,
});
return okResponse(modelStr);
},
log: createLog(),
});
const payload = (await response.json()) as any;
assert.equal(response.status, 200);
assert.equal(attempts.length, 1);
assert.equal(attempts[0].model, "fireworks/gpt-4o-mini");
assert.deepEqual(attempts[0].allowedConnectionIds, [cheap.id]);
assert.equal(payload.choices[0].message.content, "fireworks/gpt-4o-mini");
assert.notEqual(reliable.id, cheap.id);
});
test("handleComboChat honors tag_match_mode=all and falls back to the full target set when nothing matches", async () => {
await seedConnection("openai", "openai-all", ["cheap", "fast"]);
await seedConnection("fireworks", "fireworks-partial", ["cheap"]);
const attemptsAll: string[] = [];
const allModeResponse = await handleComboChat({
body: {
model: "router-all",
messages: [{ role: "user", content: "need cheap and fast" }],
metadata: { tags: ["cheap", "fast"], tag_match_mode: "all" },
},
combo: {
name: "router-all",
strategy: "priority",
models: ["fireworks/gpt-4o-mini", "openai/gpt-4o-mini"],
},
handleSingleModel: async (_body, modelStr) => {
attemptsAll.push(modelStr);
return okResponse(modelStr);
},
log: createLog(),
});
assert.equal(allModeResponse.status, 200);
assert.deepEqual(attemptsAll, ["openai/gpt-4o-mini"]);
const attemptsFallback: string[] = [];
const fallbackResponse = await handleComboChat({
body: {
model: "router-fallback",
messages: [{ role: "user", content: "need eu-only" }],
metadata: { tags: ["eu-only"] },
},
combo: {
name: "router-fallback",
strategy: "priority",
models: ["openai/gpt-4o-mini", "fireworks/gpt-4o-mini"],
},
handleSingleModel: async (_body, modelStr) => {
attemptsFallback.push(modelStr);
return okResponse(modelStr);
},
log: createLog(),
});
assert.equal(fallbackResponse.status, 200);
assert.deepEqual(attemptsFallback, ["openai/gpt-4o-mini"]);
});