Files
OmniRoute/tests/unit/terminal-status-origin.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

81 lines
2.3 KiB
TypeScript

import { test } from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
const DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-t11-"));
process.env.DATA_DIR = DIR;
const core = await import("../../src/lib/db/core.ts");
const { createProviderConnection } = await import("../../src/lib/db/providers.ts");
const { runAsProbe } = await import("../../src/shared/utils/probeOrigin.ts");
const { writeTerminalStatus } = await import("../../src/shared/utils/terminalStatus.ts");
test.after(() => {
core.resetDbInstance();
fs.rmSync(DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
function row(id: string): { is_active: number; test_status: string } {
const result = core
.getDbInstance()
.prepare("SELECT is_active, test_status FROM provider_connections WHERE id=?")
.get(id);
assert.ok(result && typeof result === "object");
return result as { is_active: number; test_status: string };
}
test("probe-origin writeTerminalStatus records error but never deactivates", async () => {
const conn = await createProviderConnection({
provider: "openai",
authType: "apikey",
name: "t11",
apiKey: "sk-t11",
isActive: true,
testStatus: "active",
});
const id = String(conn.id);
await runAsProbe(async () => {
await writeTerminalStatus(
id,
{
testStatus: "banned",
isActive: false,
lastError: "probe 403",
errorCode: "403",
lastErrorType: "FORBIDDEN",
},
"probe"
);
});
const r = row(id);
assert.equal(r.is_active, 1); // probe n'a jamais désactivé
assert.equal(r.test_status, "active"); // terminal non posé
});
test("production writeTerminalStatus deactivates on terminal", async () => {
const conn = await createProviderConnection({
provider: "openai",
authType: "apikey",
name: "t11b",
apiKey: "sk-t11b",
isActive: true,
testStatus: "active",
});
const id = String(conn.id);
await writeTerminalStatus(
id,
{
testStatus: "banned",
isActive: false,
lastError: "real 403",
errorCode: "403",
lastErrorType: "FORBIDDEN",
},
"production"
);
const r = row(id);
assert.equal(r.is_active, 0);
assert.equal(r.test_status, "banned");
});