mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-19 05:12:16 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
75 lines
3.0 KiB
TypeScript
75 lines
3.0 KiB
TypeScript
/**
|
|
* TDD regression for #5312 (FIX A / RC-A): the dashboard Thinking-Budget setting
|
|
* is dropped on restart because nothing reads `settings.thinkingBudget` back at
|
|
* boot — `_config` resets to DEFAULT (passthrough) on every process start.
|
|
*
|
|
* Fix: `hydrateThinkingBudgetConfig(settings)` (open-sse/services/thinkingBudget.ts),
|
|
* called once during server bootstrap (src/instrumentation-node.ts), restores the
|
|
* mode. This test seeds the setting through the real settings DB round-trip, runs
|
|
* the hydrator, and asserts the in-memory config reflects the operator's choice.
|
|
*/
|
|
import { test } from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-5312a-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const { getSettings, updateSettings } = await import("../../src/lib/db/settings.ts");
|
|
const {
|
|
hydrateThinkingBudgetConfig,
|
|
getThinkingBudgetConfig,
|
|
setThinkingBudgetConfig,
|
|
DEFAULT_THINKING_CONFIG,
|
|
} = await import("../../open-sse/services/thinkingBudget.ts");
|
|
|
|
test.afterEach(() => {
|
|
// Reset the module-global config so tests do not leak state into each other.
|
|
setThinkingBudgetConfig(DEFAULT_THINKING_CONFIG);
|
|
});
|
|
|
|
test.after(() => {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
test("#5312 RC-A: persisted thinkingBudget mode is restored at boot", async () => {
|
|
// Simulate the operator saving mode=auto via the dashboard PUT handler.
|
|
await updateSettings({ thinkingBudget: { mode: "auto" } });
|
|
|
|
// Simulate a fresh boot: config is at its DEFAULT until the hydrator runs.
|
|
setThinkingBudgetConfig(DEFAULT_THINKING_CONFIG);
|
|
assert.equal(getThinkingBudgetConfig().mode, "passthrough", "pre-hydration baseline");
|
|
|
|
const settings = await getSettings();
|
|
const applied = hydrateThinkingBudgetConfig(settings);
|
|
|
|
assert.equal(applied, true, "hydrator must report it applied a config");
|
|
assert.equal(getThinkingBudgetConfig().mode, "auto", "operator mode must survive restart");
|
|
});
|
|
|
|
test("#5312 RC-A: custom budget fields are restored verbatim", async () => {
|
|
await updateSettings({
|
|
thinkingBudget: { mode: "custom", customBudget: 4096, effortLevel: "low" },
|
|
});
|
|
setThinkingBudgetConfig(DEFAULT_THINKING_CONFIG);
|
|
|
|
const settings = await getSettings();
|
|
assert.equal(hydrateThinkingBudgetConfig(settings), true);
|
|
|
|
const cfg = getThinkingBudgetConfig();
|
|
assert.equal(cfg.mode, "custom");
|
|
assert.equal(cfg.customBudget, 4096);
|
|
assert.equal(cfg.effortLevel, "low");
|
|
});
|
|
|
|
test("#5312 RC-A: no behavior change when the setting is unset", async () => {
|
|
setThinkingBudgetConfig(DEFAULT_THINKING_CONFIG);
|
|
const applied = hydrateThinkingBudgetConfig({});
|
|
assert.equal(applied, false, "hydrator must be a no-op when thinkingBudget is absent");
|
|
assert.equal(getThinkingBudgetConfig().mode, "passthrough");
|
|
});
|