mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-14 02:42:24 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
89 lines
3.6 KiB
TypeScript
89 lines
3.6 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-v1beta-models-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
process.env.API_KEY_SECRET = process.env.API_KEY_SECRET || "v1beta-models-test-secret";
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const modelsDb = await import("../../src/lib/db/models.ts");
|
|
const providersDb = await import("../../src/lib/db/providers.ts");
|
|
const v1betaModelsRoute = await import("../../src/app/api/v1beta/models/route.ts");
|
|
|
|
async function addActiveConnection(provider: string) {
|
|
await providersDb.createProviderConnection({
|
|
provider,
|
|
authType: "apikey",
|
|
apiKey: `test-key-${provider}`,
|
|
testStatus: "active",
|
|
});
|
|
}
|
|
|
|
async function resetStorage() {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
|
|
}
|
|
|
|
test.beforeEach(async () => {
|
|
await resetStorage();
|
|
});
|
|
|
|
test.after(async () => {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
test("v1beta models route deduplicates custom models against built-in and synced entries", async () => {
|
|
// #2483: the route now lists only models whose provider has an active connection.
|
|
await addActiveConnection("openai");
|
|
await modelsDb.replaceSyncedAvailableModelsForConnection("openai", "conn-main", [
|
|
{
|
|
id: "gpt-4o",
|
|
name: "GPT-4o From Sync",
|
|
source: "imported",
|
|
},
|
|
{
|
|
id: "review-sync-only",
|
|
name: "Review Sync Only",
|
|
source: "imported",
|
|
},
|
|
]);
|
|
await modelsDb.addCustomModel("openai", "gpt-4o", "GPT-4o Manual Duplicate");
|
|
await modelsDb.addCustomModel("openai", "review-sync-only", "Review Manual Duplicate");
|
|
await modelsDb.addCustomModel("openai", "review-manual-only", "Review Manual Only");
|
|
|
|
const response = await v1betaModelsRoute.GET();
|
|
const body = (await response.json()) as { models: Array<{ name: string }> };
|
|
const names = body.models.map((model) => model.name);
|
|
|
|
assert.equal(response.status, 200);
|
|
assert.equal(names.filter((name) => name === "models/openai/gpt-4o").length, 1);
|
|
assert.equal(names.filter((name) => name === "models/openai/review-sync-only").length, 1);
|
|
assert.equal(names.filter((name) => name === "models/openai/review-manual-only").length, 1);
|
|
});
|
|
|
|
test("v1beta models route excludes providers without an active connection (#2483)", async () => {
|
|
// No connections configured at all → no built-in catalog models should leak.
|
|
const emptyResp = await v1betaModelsRoute.GET();
|
|
const emptyBody = (await emptyResp.json()) as { models: Array<{ name: string }> };
|
|
assert.equal(emptyResp.status, 200);
|
|
assert.equal(emptyBody.models.length, 0, "no active connections → empty model list");
|
|
|
|
// Configure ONLY an anthropic connection; custom models for an unconfigured provider
|
|
// (kie) must NOT appear, while anthropic catalog models do.
|
|
await addActiveConnection("anthropic");
|
|
await modelsDb.addCustomModel("kie", "claude-opus-4-7", "Kie Claude Opus");
|
|
const resp = await v1betaModelsRoute.GET();
|
|
const body = (await resp.json()) as { models: Array<{ name: string }> };
|
|
const names = body.models.map((m) => m.name);
|
|
assert.ok(!names.some((n) => n.startsWith("models/kie/")), "unconfigured kie must be excluded");
|
|
assert.ok(
|
|
names.some((n) => n.startsWith("models/anthropic/")),
|
|
"configured anthropic must be present"
|
|
);
|
|
});
|