mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-14 02:42:24 +03:00
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
115 lines
3.6 KiB
TypeScript
115 lines
3.6 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const TEST_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omni-deliveries-"));
|
|
process.env.DATA_DIR = TEST_DIR;
|
|
|
|
const coreDb = await import("../../src/lib/db/core.ts");
|
|
const webhooksDb = await import("../../src/lib/db/webhooks.ts");
|
|
const deliveriesDb = await import("../../src/lib/db/webhookDeliveries.ts");
|
|
|
|
async function resetStorage() {
|
|
coreDb.resetDbInstance();
|
|
fs.rmSync(TEST_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
fs.mkdirSync(TEST_DIR, { recursive: true });
|
|
}
|
|
|
|
test.beforeEach(async () => {
|
|
await resetStorage();
|
|
});
|
|
|
|
test.after(() => {
|
|
coreDb.resetDbInstance();
|
|
fs.rmSync(TEST_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
test("insertDelivery stores a row and getDeliveries returns it", () => {
|
|
const wh = webhooksDb.createWebhook({ url: "https://example.com/hook" });
|
|
deliveriesDb.insertDelivery({
|
|
webhookId: wh.id,
|
|
eventType: "request.failed",
|
|
status: "delivered",
|
|
httpStatus: 200,
|
|
latencyMs: 142,
|
|
payloadSnapshot: JSON.stringify({ event: "request.failed" }),
|
|
});
|
|
const rows = deliveriesDb.getDeliveries(wh.id, 10);
|
|
assert.equal(rows.length, 1);
|
|
assert.equal(rows[0].event_type, "request.failed");
|
|
assert.equal(rows[0].http_status, 200);
|
|
assert.equal(rows[0].latency_ms, 142);
|
|
assert.equal(rows[0].status, "delivered");
|
|
assert.equal("payload_snapshot" in rows[0], false);
|
|
});
|
|
|
|
test("rotation keeps only last 100 deliveries per webhook", () => {
|
|
const wh = webhooksDb.createWebhook({ url: "https://example.com/hook" });
|
|
for (let i = 0; i < 105; i++) {
|
|
deliveriesDb.insertDelivery({
|
|
webhookId: wh.id,
|
|
eventType: "test.ping",
|
|
status: "delivered",
|
|
httpStatus: 200,
|
|
latencyMs: 10,
|
|
});
|
|
}
|
|
const rows = deliveriesDb.getDeliveries(wh.id, 200);
|
|
assert.equal(rows.length, 100);
|
|
});
|
|
|
|
test("getDeliveries respects limit parameter", () => {
|
|
const wh = webhooksDb.createWebhook({ url: "https://example.com/hook" });
|
|
for (let i = 0; i < 10; i++) {
|
|
deliveriesDb.insertDelivery({
|
|
webhookId: wh.id,
|
|
eventType: "test.ping",
|
|
status: "delivered",
|
|
httpStatus: 200,
|
|
latencyMs: 10,
|
|
});
|
|
}
|
|
const rows = deliveriesDb.getDeliveries(wh.id, 5);
|
|
assert.equal(rows.length, 5);
|
|
});
|
|
|
|
test("CASCADE delete removes deliveries when webhook is deleted", () => {
|
|
const wh = webhooksDb.createWebhook({ url: "https://example.com/hook" });
|
|
deliveriesDb.insertDelivery({
|
|
webhookId: wh.id,
|
|
eventType: "test.ping",
|
|
status: "delivered",
|
|
httpStatus: 200,
|
|
latencyMs: 10,
|
|
});
|
|
webhooksDb.deleteWebhook(wh.id);
|
|
const rows = deliveriesDb.getDeliveries(wh.id, 10);
|
|
assert.equal(rows.length, 0);
|
|
});
|
|
|
|
test("createWebhook uses kind=custom by default", () => {
|
|
const wh = webhooksDb.createWebhook({ url: "https://example.com/hook" });
|
|
assert.equal(wh.kind, "custom");
|
|
assert.equal(wh.metadata_encrypted, null);
|
|
});
|
|
|
|
test("createWebhook accepts kind=slack", () => {
|
|
const wh = webhooksDb.createWebhook({
|
|
url: "https://hooks.slack.com/services/T/B/xxx",
|
|
kind: "slack",
|
|
});
|
|
assert.equal(wh.kind, "slack");
|
|
});
|
|
|
|
test("updateWebhook can change kind and metadataEncrypted", () => {
|
|
const wh = webhooksDb.createWebhook({ url: "https://example.com/hook" });
|
|
const updated = webhooksDb.updateWebhook(wh.id, {
|
|
kind: "telegram",
|
|
metadataEncrypted: "enc:v1:test",
|
|
});
|
|
assert.equal(updated?.kind, "telegram");
|
|
assert.equal(updated?.metadata_encrypted, "enc:v1:test");
|
|
});
|