mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-14 02:42:24 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
88 lines
2.7 KiB
TypeScript
88 lines
2.7 KiB
TypeScript
/**
|
|
* #3269: webhooks could not target a private/internal address (10.x, 192.168.x, a
|
|
* docker-internal host) — common for self-hosted automation (n8n, Home Assistant).
|
|
* The webhook URL guard now allows private targets only when the operator opts in via
|
|
* the existing `OMNIROUTE_ALLOW_PRIVATE_PROVIDER_URLS` flag (default OFF). Protocol and
|
|
* embedded-credential checks stay unconditional.
|
|
*/
|
|
|
|
import { describe, it, after } from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
process.env.DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omni-wh-3269-"));
|
|
|
|
const { OutboundUrlGuardError } = await import("../../src/shared/network/outboundUrlGuard.ts");
|
|
const { parseAndValidateWebhookUrl } =
|
|
await import("../../src/shared/network/outboundUrlGuardPolicy.ts");
|
|
const { resetDbInstance } = await import("../../src/lib/db/core.ts");
|
|
|
|
const FLAG = "OMNIROUTE_ALLOW_PRIVATE_PROVIDER_URLS";
|
|
|
|
describe("parseAndValidateWebhookUrl — private target opt-in (#3269)", () => {
|
|
it("blocks a private webhook URL when the opt-in is off (default)", () => {
|
|
delete process.env[FLAG];
|
|
assert.throws(
|
|
() => parseAndValidateWebhookUrl("http://192.168.0.10/hook"),
|
|
OutboundUrlGuardError
|
|
);
|
|
});
|
|
|
|
it("allows a private webhook URL when OMNIROUTE_ALLOW_PRIVATE_PROVIDER_URLS=true", () => {
|
|
process.env[FLAG] = "true";
|
|
try {
|
|
const url = parseAndValidateWebhookUrl("http://192.168.0.10/hook");
|
|
assert.equal(url.hostname, "192.168.0.10");
|
|
} finally {
|
|
delete process.env[FLAG];
|
|
}
|
|
});
|
|
|
|
it("still blocks embedded credentials even with the opt-in on", () => {
|
|
process.env[FLAG] = "true";
|
|
try {
|
|
assert.throws(
|
|
() => parseAndValidateWebhookUrl("http://user:pass@192.168.0.10/hook"),
|
|
OutboundUrlGuardError
|
|
);
|
|
} finally {
|
|
delete process.env[FLAG];
|
|
}
|
|
});
|
|
|
|
it("still blocks non-http(s) schemes even with the opt-in on", () => {
|
|
process.env[FLAG] = "true";
|
|
try {
|
|
assert.throws(() => parseAndValidateWebhookUrl("file:///etc/passwd"), OutboundUrlGuardError);
|
|
} finally {
|
|
delete process.env[FLAG];
|
|
}
|
|
});
|
|
|
|
it("allows a normal public URL regardless of the flag", () => {
|
|
delete process.env[FLAG];
|
|
const url = parseAndValidateWebhookUrl("https://hooks.example.com/abc");
|
|
assert.equal(url.hostname, "hooks.example.com");
|
|
});
|
|
});
|
|
|
|
after(() => {
|
|
try {
|
|
resetDbInstance();
|
|
} catch {
|
|
/* ignore */
|
|
}
|
|
try {
|
|
fs.rmSync(process.env.DATA_DIR as string, {
|
|
recursive: true,
|
|
force: true,
|
|
maxRetries: 5,
|
|
retryDelay: 100,
|
|
});
|
|
} catch {
|
|
/* ignore */
|
|
}
|
|
});
|