Files
OmniRoute/src/lib/db/playgroundPresets.ts
Paijo 4b06761ad5 feat(api): add pagination params to 8 DB modules + recharts code-split (#7046)
* perf: extract recharts into dynamic import wrappers

Bundle recharts behind next/dynamic boundaries to prevent its
large module graph from being included in the initial JS payload.

- CostOverviewTab.tsx → dynamic(() => import('./components/CostCharts'))
- ProviderUtilizationTab.tsx → dynamic(() => import('./components/ProviderCharts'))
- BurnRateChart.tsx → dynamic(() => import('./components/BurnRateChartInner'))
- Created 3 wrapper files with 'use client' and all recharts imports

Reduces initial bundle by ~35 kB (recharts + dependencies).

* perf: add pagination (limit/offset) to apiKeys, combos, providers, provider-nodes

Add optional limit/offset parameters to DB list functions and their
API route handlers. All list functions now return { items, total } when
called with parameters; backward compatible when called without args.

Affected modules:
- lib/db/apiKeys.ts      - listApiKeys, getApiKeysByGroup
- lib/db/combos.ts       - listCombos
- lib/db/providers.ts    - listProviders, getProvidersByGroup
- lib/db/providers/nodes.ts - listProviderNodes, getProviderNodesByGroup
- Corresponding API routes pass through query params

Reduces memory pressure on large datasets by returning one page at a time.

* perf: add pagination (limit/offset) to webhooks, proxies, modelComboMappings, playgroundPresets

Add optional limit/offset parameters to DB list functions and their
API route handlers for the remaining data modules.

Affected modules:
- lib/db/webhooks.ts         - getWebhooks returns { webhooks, total }
- lib/db/proxies.ts          - listProxies
- lib/db/modelComboMappings.ts - listMappings
- lib/db/playgroundPresets.ts - listPresets
- Corresponding API routes pass through query params
- Re-exports updated: lib/localDb.ts, models/index.ts

Backward compatible: calling without args returns all rows.

* perf: batch pool building and add pagination to quotaPools

Replace per-pool N+1 queries with batch-loading pattern.

- Added batchBuildPools(rows) — collects all pool IDs, does 2 batch
  queries (allocations + connections) instead of 2N individual queries
- getPoolsByGroup and listPools now use batchBuildPools
- Added optional limit/offset pagination params
- Fixed SQLite OFFSET-syntax bug: only emit OFFSET when LIMIT also present
- Added quota-pools.test.ts with 10 tests covering pagination edge cases,
  batch loading, and the offset-without-limit guard

Reduces pool-page query count from 2N+1 to 3 (constant).

* perf: replace manual offset/limit parsing with Zod paginationSchema in combos GET handler

* fix: replace manual Number()/parseInt pagination with paginationSchema

Endpoints: model-combo-mappings, playground/presets, provider-nodes.
Uses existing Zod schema with z.coerce.number() for proper validation.

* chore: bump proxies.ts frozen baseline 1177->1208 for perf/api-pagination

PR #7046 backward-compatible pagination refactor grew proxies.ts
by +31 lines (1177->1208). Entries return plain array when no
pagination params provided, {items,total} when pagination requested.

* fix(db): finish listProxies()/getWebhooks() pagination shape migration

The pagination refactor changed listProxies(), listPools(),
getModelComboMappings(), listPlaygroundPresets() and getWebhooks() to
return a paginated envelope ({ items, total } / { webhooks, total })
instead of a bare array, but left three real production callers and
several tests on the old array-shaped API:

- src/lib/proxyEgress.ts (validateProxyPool default listProxies impl)
  iterated the envelope directly -> "is not iterable" at runtime, hit
  by /api/settings/proxies/egress (no injected deps).
- src/lib/proxyHealth/scheduler.ts (sweep()) read proxies.length on the
  envelope (undefined), so the health-check sweep silently processed
  zero proxies every run.
- open-sse/utils/proxyFallback.ts (getProxyCandidates()) iterated the
  envelope inside a try/catch that swallowed the resulting TypeError,
  so every user-configured proxy silently vanished from the fallback
  candidate list.

Also fixes two TS2558/TS2339 typecheck errors in proxies.ts/webhooks.ts
(db.prepare<T>() generic not supported by this DB wrapper — cast the
query result instead, matching the existing pattern in both files) and
trims one blank re-export separator line in localDb.ts to stay within
the frozen file-size ratchet after 4 new *Count() exports.

Updates the pre-existing unit tests that called the changed functions
directly (db-quota-pools, quota-groups-migration, quota-pool-connections,
quota-pool-delete-prune, db-webhooks, model-combo-mappings-db,
db-playground-presets, db-proxies-crud, proxy-batch-routes-5918,
proxy-registry, error-message-sanitization) to destructure the new
envelope shape instead of treating the result as an array.

Implements the small, well-scoped performance-mark/measure
instrumentation ("omni-pipeline-start"/"omni-pipeline-end"/"omni-pipeline")
that tests/unit/chatcore-streaming-pipeline.test.ts already asserted for
assembleStreamingPipeline() but that had no corresponding source change.

Adds three new regression tests (TDD: each reproduces its bug against
the pre-fix code before the corresponding fix, then passes) covering
the three real production callers above:
tests/unit/proxy-egress-validate-pool-default.test.ts,
tests/unit/proxy-health-scheduler-listproxies-shape.test.ts,
tests/unit/proxy-fallback-candidates-listproxies-shape.test.ts.

Co-authored-by: diegosouzapw <diegosouza.pw@gmail.com>

* fix: resolve rebase conflict in proxies.ts — keep hasBlockingProxyAssignment but drop duplicate extraction leftovers

- Removed duplicate resolveScopePoolInternal, resolveProxyForConnectionFromRegistry,
  resolveProxyForScopeFromRegistry already extracted to proxies/rotation.ts
- Removed duplicate hasBlockingProxyAssignment function body already re-exported from proxies/guards.ts
- Removed duplicate PROXY_ALIVE_PREDICATE import
- All typechecks and 45 affected tests pass

* fix(test): account for _reorderConnections in pagination test expectedOrder

createProviderConnection calls _reorderConnections after every insert
which reassigns priorities sequentially. The test was assuming creation
order determines priority order, leading to incorrect expected results.

Fix: query the DB after all inserts and use the actual priority order.

Also removes debug console.log from getRawProviderConnections.

* chore: remove debug tmp-*.mjs files left in PR branch

* test(proxy): migrate the dedup test to the paginated listProxies() shape

#7046 changed listProxies() to return { items, total }, and updated every
production caller plus three of the four test files — tests/unit/proxy-bulk-import-dedup-7594.test.ts
was missed, so its four `listed.length` assertions read `undefined` and the
file went red on the merge train (it passes on the pure release tip).

Test-only: destructure `{ items: listed }` at the four callsites. Verified
proxyEgress.ts needs no change — its local deps shim already unwraps .items,
and tests/unit/proxy-egress-validate-pool-default.test.ts guards exactly that.

Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>

---------

Co-authored-by: oyi77 <oyi77@users.noreply.github.com>
Co-authored-by: diegosouzapw <diegosouza.pw@gmail.com>
Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
2026-07-20 10:07:49 -03:00

180 lines
5.0 KiB
TypeScript

/**
* db/playgroundPresets.ts — Playground Studio preset persistence.
*
* CRUD operations for the playground_presets table (migration 076).
* All queries use db.prepare() (better-sqlite3) — never raw db.exec() or
* string interpolation.
*
* @module lib/db/playgroundPresets
*/
import { getDbInstance } from "./core";
import { randomUUID } from "node:crypto";
// TODO(F1-merge): swap to import from "@/shared/schemas/playground" after F1 lands
export interface PlaygroundPresetListItem {
id: string;
name: string;
endpoint: string;
model: string;
system: string | null;
params: Record<string, unknown>;
created_at: string;
}
type PlaygroundPresetRow = {
id: string;
name: string;
endpoint: string;
model: string;
system: string | null;
params_json: string;
created_at: string;
};
function rowToItem(row: PlaygroundPresetRow): PlaygroundPresetListItem {
let params: Record<string, unknown> = {};
try {
const parsed = JSON.parse(row.params_json);
if (parsed !== null && typeof parsed === "object" && !Array.isArray(parsed)) {
params = parsed as Record<string, unknown>;
}
} catch {
params = {};
}
return {
id: row.id,
name: row.name,
endpoint: row.endpoint,
model: row.model,
system: row.system,
params,
created_at: row.created_at,
};
}
/**
* Returns all presets ordered by created_at descending (newest first).
* Accepts optional limit/offset for pagination.
*/
export function listPlaygroundPresets(options?: { limit?: number; offset?: number }): {
items: PlaygroundPresetListItem[];
total: number;
} {
const db = getDbInstance();
const limit = options?.limit;
const offset = options?.offset ?? 0;
let sql = "SELECT * FROM playground_presets ORDER BY created_at DESC";
const params: unknown[] = [];
if (limit !== undefined) {
sql += " LIMIT ? OFFSET ?";
params.push(limit, offset);
}
const rows = db.prepare(sql).all(...params) as PlaygroundPresetRow[];
const totalRow = db.prepare("SELECT count(*) as cnt FROM playground_presets").get() as {
cnt: number;
};
return { items: rows.map(rowToItem), total: totalRow.cnt };
}
/**
* Returns a single preset by id, or null when not found.
*/
export function getPlaygroundPreset(id: string): PlaygroundPresetListItem | null {
const db = getDbInstance();
const row = db.prepare("SELECT * FROM playground_presets WHERE id = ? LIMIT 1").get(id) as
PlaygroundPresetRow | undefined;
if (!row) return null;
return rowToItem(row);
}
/**
* Creates a new preset. Generates a UUID v4 for the id.
* Returns the persisted row via getPlaygroundPreset.
*/
export function createPlaygroundPreset(input: {
name: string;
endpoint: string;
model: string;
system: string | null | undefined;
params: Record<string, unknown>;
}): PlaygroundPresetListItem {
const db = getDbInstance();
const id = randomUUID();
const params_json = JSON.stringify(input.params ?? {});
const system = input.system ?? null;
db.prepare(
"INSERT INTO playground_presets (id, name, endpoint, model, system, params_json) VALUES (?, ?, ?, ?, ?, ?)"
).run(id, input.name, input.endpoint, input.model, system, params_json);
const created = getPlaygroundPreset(id);
// created cannot be null here — we just inserted the row
return created as PlaygroundPresetListItem;
}
/**
* Updates only the supplied fields on an existing preset.
* Returns the updated row, or null when the id does not exist.
*/
export function updatePlaygroundPreset(
id: string,
patch: Partial<{
name: string;
endpoint: string;
model: string;
system: string | null;
params: Record<string, unknown>;
}>
): PlaygroundPresetListItem | null {
const db = getDbInstance();
// Verify row exists before building the dynamic UPDATE
const existing = getPlaygroundPreset(id);
if (!existing) return null;
const setClauses: string[] = [];
const values: unknown[] = [];
if (patch.name !== undefined) {
setClauses.push("name = ?");
values.push(patch.name);
}
if (patch.endpoint !== undefined) {
setClauses.push("endpoint = ?");
values.push(patch.endpoint);
}
if (patch.model !== undefined) {
setClauses.push("model = ?");
values.push(patch.model);
}
if ("system" in patch) {
setClauses.push("system = ?");
values.push(patch.system ?? null);
}
if (patch.params !== undefined) {
setClauses.push("params_json = ?");
values.push(JSON.stringify(patch.params));
}
if (setClauses.length === 0) {
// Empty patch — return current row unchanged
return existing;
}
values.push(id);
db.prepare(`UPDATE playground_presets SET ${setClauses.join(", ")} WHERE id = ?`).run(...values);
return getPlaygroundPreset(id);
}
/**
* Deletes a preset by id.
* Returns true when a row was deleted, false when the id did not exist.
*/
export function deletePlaygroundPreset(id: string): boolean {
const db = getDbInstance();
const result = db.prepare("DELETE FROM playground_presets WHERE id = ?").run(id);
return result.changes > 0;
}