mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-08-24 08:02:14 +03:00
Validated on the resolved merge against the current tip (527da656 + the post-#11281 rebaseline): the single conflict was a comment-only collision in providers/[id]/models/route.ts (kept the tip's #10828-ordering note). Focused suites 125/125 across all 13 touched test files (build-sqlite-stub, cc-compatible, copilot-claude-messages, copilot-gemini-route, executor-github, ghe-copilot, github-copilot-discovery-token, github-copilot-model-discovery, noauth-sibling-7620, provider-header-profiles, provider-models-config, request-log-payloads, upstream-error-passthrough), typecheck:core clean, file-size/changelog-integrity OK. Merged --admin over the inherited 2026-08-23 base-red cluster (#9985) — the reds are proven tip failures (CLI catalog cluster + @testing-library allowlist, being drained by #11280), not from this diff. Note: the rebase means several items the body listed (relay x-relay-path SSRF, /v1/search blocked-providers, #10736 rotation fence, #10903, #10865, #10899, #10916) already landed upstream and are NOT in this delta — the delta is: better-sqlite3 build guard + build heap/worker caps + telemetry-off (#10060 re-derived), credential-echo passthrough refusal + OCR/moderation redaction + call-log key redaction, Copilot CLI 1.0.81-6 wire identity + Claude→/v1/messages name-matched routing + discovery token fix, CC model_not_found 400, compat overrides for no-auth aliases (#7620-pinned). The Copilot wire-identity change is the one to watch in production. Thank you @arminanton — and the ported-author credits in the commit history (@rqzbeh, yidecode, the #10899/#10916 authors) are preserved. Your config-posture finding (REQUIRE_API_KEY default vs 0.0.0.0) is noted for a maintainer decision, as you scoped it.
212 lines
7.6 KiB
TypeScript
212 lines
7.6 KiB
TypeScript
/**
|
|
* Issues #3120 / #3121 — GitHub Copilot model discovery (thanks @gabrielmoreira).
|
|
*
|
|
* #3120: "Import Models" never refreshes the Copilot model list because the
|
|
* `github` (Copilot) provider had a STATIC hardcoded catalog and no live
|
|
* discovery source.
|
|
* #3121: That static catalog advertised models (e.g. gemini previews) that the
|
|
* account is not entitled to, so testing them returned upstream 400s.
|
|
*
|
|
* Fix: discover the catalog live from https://api.githubcopilot.com/models using
|
|
* the Copilot bearer + Copilot chat headers, parse `data[].id` into managed
|
|
* models, and fall back to the static catalog only when the live fetch fails.
|
|
*
|
|
* These tests target the discovery helper directly (injected fetch) so they need
|
|
* no HTTP server or DB.
|
|
*/
|
|
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
|
|
const {
|
|
GITHUB_COPILOT_MODELS_URL,
|
|
GITHUB_COPILOT_MODEL_ALLOWLIST,
|
|
GITHUB_COPILOT_STATIC_FALLBACK_MODELS,
|
|
parseGitHubCopilotModels,
|
|
fetchGitHubCopilotModels,
|
|
} = await import("../../open-sse/services/githubCopilotModels.ts");
|
|
|
|
// A representative slice of a real Copilot /models response. The upstream list
|
|
// includes selectable chat models plus utility/legacy models; discovery now
|
|
// keeps every entitled CHAT model (capability-driven) and drops only non-chat
|
|
// rows (embeddings / completion).
|
|
const MOCK_COPILOT_MODELS_RESPONSE = {
|
|
data: [
|
|
{
|
|
id: "gpt-5.4",
|
|
name: "GPT-5.4",
|
|
model_picker_enabled: true,
|
|
policy: { state: "enabled" },
|
|
capabilities: { type: "chat", limits: { max_context_window_tokens: 128000 } },
|
|
},
|
|
{
|
|
id: "claude-sonnet-4.5",
|
|
name: "Claude Sonnet 4.5",
|
|
model_picker_enabled: true,
|
|
capabilities: { type: "chat" },
|
|
},
|
|
{
|
|
// Newly-entitled model NOT in any hardcoded list — must still be kept now
|
|
// that discovery is capability-driven (this is the whole point of the fix).
|
|
id: "grok-4.6",
|
|
name: "Grok 4.6",
|
|
model_picker_enabled: true,
|
|
capabilities: { type: "chat" },
|
|
supported_endpoints: ["/responses"],
|
|
},
|
|
{
|
|
// Embeddings model — present upstream but not a routable chat model.
|
|
id: "text-embedding-3-small",
|
|
name: "Embedding V3 small",
|
|
capabilities: { type: "embeddings" },
|
|
},
|
|
{
|
|
// Raw completion utility — also excluded.
|
|
id: "gpt-41-copilot",
|
|
name: "Copilot Completion",
|
|
capabilities: { type: "completion" },
|
|
},
|
|
],
|
|
};
|
|
|
|
test("#3120 parseGitHubCopilotModels keeps every entitled CHAT model (capability-driven)", () => {
|
|
const models = parseGitHubCopilotModels(MOCK_COPILOT_MODELS_RESPONSE);
|
|
const ids = models.map((m) => m.id);
|
|
// grok-4.6 is kept even though it is in no hardcoded allowlist — it's an
|
|
// entitled chat model in the live response.
|
|
assert.deepEqual(ids, ["gpt-5.4", "claude-sonnet-4.5", "grok-4.6"]);
|
|
const gpt = models.find((m) => m.id === "gpt-5.4");
|
|
assert.ok(gpt, "gpt-5.4 entry present");
|
|
assert.equal(gpt.name, "GPT-5.4");
|
|
assert.equal(gpt.owned_by, "github");
|
|
assert.ok(!ids.includes("text-embedding-3-small"), "embeddings models are skipped");
|
|
assert.ok(!ids.includes("gpt-41-copilot"), "completion utility models are skipped");
|
|
});
|
|
|
|
test("#3121 a model NOT in the live response is not advertised (entitlement filtering)", () => {
|
|
const models = parseGitHubCopilotModels(MOCK_COPILOT_MODELS_RESPONSE);
|
|
const ids = models.map((m) => m.id);
|
|
// gemini-3.1-pro-preview is not entitled here (absent from the live response).
|
|
assert.ok(
|
|
!ids.includes("gemini-3.1-pro-preview"),
|
|
"non-entitled gemini preview must NOT be advertised"
|
|
);
|
|
});
|
|
|
|
test("#3120 fetchGitHubCopilotModels does a live fetch and returns parsed models", async () => {
|
|
let capturedUrl = "";
|
|
let capturedHeaders: Record<string, string> = {};
|
|
const fakeFetch = (async (url: string, init: RequestInit) => {
|
|
capturedUrl = String(url);
|
|
capturedHeaders = (init?.headers as Record<string, string>) || {};
|
|
return new Response(JSON.stringify(MOCK_COPILOT_MODELS_RESPONSE), {
|
|
status: 200,
|
|
headers: { "content-type": "application/json" },
|
|
});
|
|
}) as unknown as typeof fetch;
|
|
|
|
const result = await fetchGitHubCopilotModels({
|
|
token: "copilot-tok-abc",
|
|
fetchImpl: fakeFetch,
|
|
});
|
|
|
|
assert.equal(capturedUrl, GITHUB_COPILOT_MODELS_URL);
|
|
assert.equal(
|
|
capturedHeaders.Authorization,
|
|
"Bearer copilot-tok-abc",
|
|
"must authenticate with the Copilot bearer token"
|
|
);
|
|
// Copilot chat headers must be present (e.g. copilot-integration-id).
|
|
assert.ok(capturedHeaders["copilot-integration-id"], "must send Copilot integration header");
|
|
assert.equal(result.source, "api");
|
|
const ids = result.models.map((m) => m.id);
|
|
assert.deepEqual(ids, ["gpt-5.4", "claude-sonnet-4.5", "grok-4.6"]);
|
|
assert.ok(!ids.includes("gemini-3.1-pro-preview"));
|
|
});
|
|
|
|
test("#3120/#3121 fetch falls back to static catalog when the live fetch fails", async () => {
|
|
const fakeFetch = (async () => new Response("nope", { status: 503 })) as unknown as typeof fetch;
|
|
const fallback = [
|
|
{ id: "gpt-5.4", name: "GPT-5.4" },
|
|
{ id: "gemini-3.1-pro-preview", name: "Gemini 3.1 Pro" },
|
|
{ id: "gpt-3.5-turbo", name: "GPT 3.5 Turbo" },
|
|
];
|
|
|
|
const result = await fetchGitHubCopilotModels({
|
|
token: "copilot-tok-abc",
|
|
fetchImpl: fakeFetch,
|
|
fallbackModels: fallback,
|
|
});
|
|
|
|
assert.equal(result.source, "fallback");
|
|
assert.deepEqual(
|
|
result.models.map((m) => m.id),
|
|
["gpt-5.4", "gemini-3.1-pro-preview"],
|
|
"offline/failed discovery must preserve only the curated static catalog"
|
|
);
|
|
});
|
|
|
|
test("static fallback catalog is the alias of the allowlist and covers the approved chat ids", () => {
|
|
// Back-compat: the old name still points at the fallback catalog.
|
|
assert.equal(GITHUB_COPILOT_MODEL_ALLOWLIST, GITHUB_COPILOT_STATIC_FALLBACK_MODELS);
|
|
const set = new Set<string>(GITHUB_COPILOT_STATIC_FALLBACK_MODELS);
|
|
// The fallback must include the newly-entitled families so an offline import
|
|
// (which can only draw from this static list) still surfaces them.
|
|
for (const id of [
|
|
"claude-fable-5",
|
|
"claude-opus-5",
|
|
"claude-opus-4.8-fast",
|
|
"claude-opus-4.6",
|
|
"gemini-3.6-flash",
|
|
"gemini-3.5-flash",
|
|
"gpt-5.4-nano",
|
|
"grok-4.6",
|
|
"grok-4.5",
|
|
"mai-code-1.1-flash",
|
|
"mai-code-1-flash-picker",
|
|
]) {
|
|
assert.ok(set.has(id), `static fallback must include ${id}`);
|
|
}
|
|
// No embeddings / completion utilities belong in the chat fallback catalog.
|
|
assert.ok(!set.has("text-embedding-3-small"));
|
|
assert.ok(!set.has("gpt-41-copilot"));
|
|
});
|
|
|
|
test("newly approved Copilot models survive live and fallback discovery", async () => {
|
|
const expected = ["claude-opus-5", "gpt-5.6-sol", "gpt-5.6-terra", "gpt-5.6-luna"];
|
|
const live = parseGitHubCopilotModels({ data: expected.map((id) => ({ id, name: id })) });
|
|
assert.deepEqual(
|
|
live.map((model) => model.id),
|
|
expected
|
|
);
|
|
|
|
const fallback = await fetchGitHubCopilotModels({
|
|
token: "",
|
|
fallbackModels: expected.map((id) => ({ id, name: id })),
|
|
});
|
|
assert.deepEqual(
|
|
fallback.models.map((model) => model.id),
|
|
expected
|
|
);
|
|
});
|
|
|
|
test("fetch falls back when no token is provided (unauthed refresh stays safe)", async () => {
|
|
let called = false;
|
|
const fakeFetch = (async () => {
|
|
called = true;
|
|
return new Response("{}", { status: 200 });
|
|
}) as unknown as typeof fetch;
|
|
|
|
const result = await fetchGitHubCopilotModels({
|
|
token: "",
|
|
fetchImpl: fakeFetch,
|
|
fallbackModels: [{ id: "gpt-5.4", name: "GPT-5.4" }],
|
|
});
|
|
|
|
assert.equal(called, false, "must not fetch without a token");
|
|
assert.equal(result.source, "fallback");
|
|
assert.deepEqual(
|
|
result.models.map((m) => m.id),
|
|
["gpt-5.4"]
|
|
);
|
|
});
|