Files
OmniRoute/tests/unit/payload-rules.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

143 lines
4.0 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
const { applyPayloadRules, getPayloadRulesConfig, resetPayloadRulesConfigForTests } =
await import("../../open-sse/services/payloadRules.ts");
const ORIGINAL_PAYLOAD_RULES_PATH = process.env.OMNIROUTE_PAYLOAD_RULES_PATH;
const ORIGINAL_PAYLOAD_RULES_RELOAD_MS = process.env.OMNIROUTE_PAYLOAD_RULES_RELOAD_MS;
test.afterEach(() => {
resetPayloadRulesConfigForTests();
if (ORIGINAL_PAYLOAD_RULES_PATH === undefined) {
delete process.env.OMNIROUTE_PAYLOAD_RULES_PATH;
} else {
process.env.OMNIROUTE_PAYLOAD_RULES_PATH = ORIGINAL_PAYLOAD_RULES_PATH;
}
if (ORIGINAL_PAYLOAD_RULES_RELOAD_MS === undefined) {
delete process.env.OMNIROUTE_PAYLOAD_RULES_RELOAD_MS;
} else {
process.env.OMNIROUTE_PAYLOAD_RULES_RELOAD_MS = ORIGINAL_PAYLOAD_RULES_RELOAD_MS;
}
});
test("payload rules apply default, default-raw, override, and filter operations", () => {
const { payload, applied } = applyPayloadRules(
{
temperature: 0.4,
metadata: { removeMe: true },
dangerous: { enabled: true },
},
"gpt-5.4",
"openai",
{
default: [
{
models: [{ name: "gpt-*", protocol: "openai" }],
params: {
"metadata.routeTag": "feature-110",
},
},
],
defaultRaw: [
{
models: [{ name: "gpt-*", protocol: "openai" }],
params: {
response_format:
'{"type":"json_schema","json_schema":{"name":"shape","schema":{"type":"object"}}}',
},
},
],
override: [
{
models: [{ name: "gpt-*", protocol: "openai" }],
params: {
"reasoning.effort": "high",
},
},
],
filter: [
{
models: [{ name: "gpt-*", protocol: "openai" }],
params: ["dangerous", "metadata.removeMe"],
},
],
}
);
assert.equal(payload.temperature, 0.4);
assert.equal((payload.metadata as any).routeTag, "feature-110");
assert.equal("removeMe" in payload.metadata, false);
assert.equal("dangerous" in payload, false);
assert.equal((payload as any).reasoning.effort, "high");
assert.deepEqual(payload.response_format, {
type: "json_schema",
json_schema: {
name: "shape",
schema: { type: "object" },
},
});
assert.deepEqual(
applied.map((rule) => `${rule.type}:${rule.path}`),
[
"default:metadata.routeTag",
"default-raw:response_format",
"override:reasoning.effort",
"filter:dangerous",
"filter:metadata.removeMe",
]
);
});
test("payload rules load from JSON file and reload changed content", async () => {
const tempDir = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-payload-rules-"));
const configPath = path.join(tempDir, "payloadRules.json");
process.env.OMNIROUTE_PAYLOAD_RULES_PATH = configPath;
fs.writeFileSync(
configPath,
JSON.stringify({
override: [
{
models: [{ name: "gpt-*", protocol: "openai" }],
params: { temperature: 0.1 },
},
],
}),
"utf-8"
);
const first = await getPayloadRulesConfig({ forceRefresh: true });
assert.equal(first.override.length, 1);
assert.equal(first.override[0].params.temperature, 0.1);
assert.equal(first.defaultRaw.length, 0);
await new Promise((resolve) => setTimeout(resolve, 20));
fs.writeFileSync(
configPath,
JSON.stringify({
"default-raw": [
{
models: [{ name: "gpt-*", protocol: "openai" }],
params: { response_format: { type: "json_object" } },
},
],
}),
"utf-8"
);
const second = await getPayloadRulesConfig({ forceRefresh: true });
assert.equal(second.override.length, 0);
assert.equal(second.defaultRaw.length, 1);
assert.deepEqual(second.defaultRaw[0].params.response_format, { type: "json_object" });
fs.rmSync(tempDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});