mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-17 20:32:25 +03:00
9250a231c5
Merged. Test-only, and the right kind: a browser-spawn guard is precisely the thing that gets removed by accident during a refactor, and nothing was holding it in place until now. Validated as a combined board first (this PR merged with the 21 siblings of the same wave on the release tip): eslint with the frozen suppressions, typecheck:core, check:open-sse-typecheck, complexity, cognitive-complexity, changelog-integrity, i18n new-key coverage, docs-counts, docs-sync, migration-numbering, provider-consistency and a duplicate-identifier audit all green, plus 176 passing / 0 failing focused node:test cases across the 25 test files the wave touches and the dashboard test under Vitest (2/0). Then re-validated alone on the fresh tip before this merge: conflicts re-resolved, file sizes rebaselined for this PR's own growth, eslint and this PR's focused tests re-run. Thank you.
61 lines
3.2 KiB
TypeScript
61 lines
3.2 KiB
TypeScript
// Test-only DATA_DIR isolation.
|
|
//
|
|
// Loaded via `node --import ./tests/_setup/isolateDataDir.ts` from the test/mutation
|
|
// invocations (package.json test scripts, stryker.conf.json tap.nodeArgs, the
|
|
// quality.yml TIA step, and the CI test jobs) — NEVER from production. It MUST stay
|
|
// out of open-sse/utils/setupPolyfill.ts, which is also imported by production
|
|
// (bin/omniroute.mjs, proxyFetch.ts, proxyDispatcher.ts) where redirecting DATA_DIR
|
|
// would point the live SQLite DB at a throwaway temp dir.
|
|
//
|
|
// Why: node:test spawns a process per test file and Stryker spawns one per sandbox,
|
|
// but every process resolves DATA_DIR to the SAME default (~/.omniroute) when the env
|
|
// var is unset (see src/lib/dataPaths.ts::resolveDataDir). Concurrent processes then
|
|
// open the SAME on-disk storage.sqlite, causing cross-file state races: SQLite lock
|
|
// contention that hangs `test:unit` under high `--test-concurrency`, and the
|
|
// non-deterministic baseline that forced Stryker to `concurrency: 1`.
|
|
//
|
|
// Giving each process its own DATA_DIR under the OS temp dir removes the shared file,
|
|
// so concurrent test processes never collide. Tests that set DATA_DIR explicitly keep
|
|
// winning — this only fills in an isolated default when none was chosen.
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
// File logger worker threads can outlive a test's temporary DATA_DIR cleanup and then
|
|
// raise ENOENT/ENOTEMPTY after the test has already passed. Keep the global test default
|
|
// console-only; tests that cover file logging explicitly set APP_LOG_TO_FILE themselves.
|
|
process.env.APP_LOG_TO_FILE ||= "false";
|
|
|
|
if (!process.env.DATA_DIR) {
|
|
const dir = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-test-"));
|
|
process.env.DATA_DIR = dir;
|
|
|
|
// Best-effort cleanup so a long suite run does not leak hundreds of temp DBs.
|
|
process.on("exit", () => {
|
|
try {
|
|
fs.rmSync(dir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
} catch {
|
|
// ignore — the OS reaps its temp dir eventually.
|
|
}
|
|
});
|
|
}
|
|
|
|
// System-trust guard: the suite must NEVER mutate the OS trust store. On a
|
|
// persistent self-hosted runner the cert-flow integration test installed a fake
|
|
// 105-byte PEM into /usr/local/share/ca-certificates and update-ca-certificates
|
|
// baked it into the bundle, breaking ALL system TLS on the VM (2026-07-05).
|
|
// installCert/uninstallCert/installTproxyCa/uninstallTproxyCa no-op under this.
|
|
process.env.OMNIROUTE_SKIP_SYSTEM_TRUST = "1";
|
|
|
|
// Browser-spawn guard: the Adobe Firefly session warm (adobeFireflySession.ts)
|
|
// spawns the SYSTEM Chrome with --remote-debugging-port whenever a test reaches it
|
|
// without a valid user JWT — which any mocked-fetch test does by construction.
|
|
// Per-call-site allowBrowserRefresh/tryBrowser flags are not enough: the warm is also
|
|
// reachable indirectly via client/handler paths, so the guard must be global.
|
|
// ||= (not =) so a browser-path integration test can still opt back in.
|
|
process.env.ADOBE_FIREFLY_BROWSER_REFRESH ||= "0";
|
|
|
|
// DNS-write guard: the suite must NEVER mutate /etc/hosts. Tests that exercise
|
|
// the real MITM path call addDNSEntries(); this env var makes it a no-op.
|
|
process.env.OMNIROUTE_SKIP_DNS_WRITE = "1";
|