Files
OmniRoute/open-sse/executors/tinycms.ts
Diego Rodrigues de Sa e Souza 85c4292ce3 fix(security): correct XML double-unescape and non-CSPRNG nonce from CodeQL sweep (#10154)
* fix(security): correct XML double-unescape and non-CSPRNG nonce from CodeQL sweep

Two real defects surfaced by the 2026-08-12 code-scanning triage.

decodeXmlText decoded `&` before `"`/`'`, so `"` — the encoding of
the literal text `"` — collapsed to `"` in a second pass. The decoded values feed the
workspace-root trust comparison in parseTrustedCodexEnvironment, so an encoded path could
decode into a different path than the client declared. Decoding `&` last fixes it.

The tinycms nonce fell back to `Date.now()` plus a non-cryptographic PRNG when
`crypto.randomUUID` was absent. That nonce is signed into the provider's anti-replay
payload, so the fallback produced a predictable value silently. It is now always
`randomUUID()` from node:crypto, which is present on every supported runtime.

Both guards are mutation-validated: reverting either fix makes the new test fail.

Refs #9985

* fix(security): reword tinycms nonce comment so the CSPRNG regression test holds

---------

Co-authored-by: backryun <bakryun0718@proton.me>
2026-08-12 16:03:58 -03:00

132 lines
4.5 KiB
TypeScript

import { randomUUID } from "node:crypto";
import { BaseExecutor, type ExecuteInput, type ExecutorExecuteResult } from "./base.ts";
import { makeExecutorErrorResult as makeErrorResult } from "../utils/error.ts";
import { initTinyCmsWasm, generateSecurePayload } from "./tinycmsSigner.ts";
const CHAT_URL = "https://gov.freegpt.win/api/openai/oneapi/v1/chat/completions";
const CHALLENGE_URL = "https://gov.freegpt.win/api/challenge";
let publicIp: string | null = null;
let lastIpFetch = 0;
async function getPublicIp(): Promise<string> {
const now = Date.now();
if (publicIp && now - lastIpFetch < 300000) {
return publicIp;
}
try {
const res = await fetch("https://api64.ipify.org?format=json");
const json = (await res.json()) as { ip: string };
publicIp = json.ip;
lastIpFetch = now;
return publicIp;
} catch {
return publicIp || "127.0.0.1";
}
}
async function fetchChallenge(uuid: string): Promise<any> {
const res = await fetch(CHALLENGE_URL, {
method: "GET",
headers: {
uuid: uuid,
"x-origin": "https://gov.freegpt.win",
Accept: "application/json",
"User-Agent": "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36",
},
});
if (!res.ok) {
throw new Error(`Failed to fetch challenge: ${res.status}`);
}
return await res.json();
}
export class TinyCmsExecutor extends BaseExecutor {
constructor() {
super("tinycms-web", { id: "tinycms-web", baseUrl: CHAT_URL });
}
async execute(input: ExecuteInput): Promise<ExecutorExecuteResult> {
const { body, credentials, signal } = input;
const bodyObj = (body || {}) as Record<string, any>;
// TinyCMS uses 'uuid' header for identification
const uuid = String(credentials?.apiKey ?? "").trim();
if (!uuid || !uuid.startsWith("R")) {
return makeErrorResult(
401,
"TinyCMS: Invalid or missing device UUID (must start with 'R')",
body,
CHAT_URL
);
}
try {
await initTinyCmsWasm();
const ip = await getPublicIp();
const challengeObj = await fetchChallenge(uuid);
const timestamp = Date.now().toString();
// Security context: this nonce is signed into `x-secure-signature` and
// reused as the session id, so it must be unpredictable. `node:crypto`
// randomUUID() is always available on the supported runtime — never fall
// back to a non-CSPRNG source (CodeQL js/insecure-randomness).
const nonceJs = randomUUID();
const securePayload = generateSecurePayload(
uuid,
timestamp,
nonceJs,
challengeObj.challenge,
ip,
challengeObj.difficulty
);
const signedHeaders: Record<string, string> = {
uuid: uuid,
"x-origin": "https://gov.freegpt.win",
referer: "https://gov.freegpt.win/",
"x-secure-challenge-id": challengeObj.challengeId,
"x-secure-challenge-expires-at": String(challengeObj.expiresAt),
"x-secure-challenge-version": challengeObj.version,
"x-secure-signature": securePayload.signature,
"x-secure-fingerprint": securePayload.fingerprint,
"x-secure-client-ip": securePayload.client_ip,
"x-secure-pow-seed-nonce": String(securePayload.pow.seed_nonce),
"x-secure-pow-nonce": String(securePayload.pow.nonce),
"x-secure-pow-hash": securePayload.pow.hash,
"x-secure-pow-difficulty": String(securePayload.pow.difficulty),
"x-secure-timestamp": timestamp,
"x-secure-nonce": nonceJs,
"x-secure-version": securePayload.v,
"x-session-id": nonceJs,
// Use configurable userid from providerSpecificData if present, otherwise generate one
// from the UUID (the server uses it for request attribution, not auth).
userid: String(credentials?.providerSpecificData?.userid ?? "") || uuid.slice(0, 20),
Accept: bodyObj.stream ? "text/event-stream" : "application/json",
"Content-Type": "application/json",
"User-Agent": "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36",
};
const fetchOptions: RequestInit = {
method: "POST",
headers: signedHeaders,
body: JSON.stringify(bodyObj),
signal,
};
const response = await fetch(CHAT_URL, fetchOptions);
return {
response,
url: CHAT_URL,
headers: Object.fromEntries(response.headers.entries()),
transformedBody: bodyObj,
};
} catch (err: any) {
return makeErrorResult(500, `TinyCMS Error: ${err.message}`, body, CHAT_URL);
}
}
}