mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-07-31 12:22:14 +03:00
* feat(plugins): WordPress-style plugin system backend * fix(plugins): address code review feedback - Path traversal guard: validate entryPoint stays within plugin dir - install() now handles direct plugin directories (not just parent dirs) - Non-null assertion replaced with explicit null check - require efficiency: allowedModules map moved outside function - Source wrapper: add newlines to prevent trailing comment issues - Config validation: validate values against configSchema on save - Dynamic import comment: clarify Node.js caching behavior Co-Authored-By: OpenClaude (mimo-v2.5-pro) <openclaude@gitlawb.com> * fix(plugins): replace vm with child_process, add auth to all routes Addresses all remaining code review feedback: 1. **Loader rewrite**: Replaced Node.js vm module with child_process.fork() for proper process-level isolation. Complies with Rule 3 (no eval). Each plugin runs in a separate Node.js process with IPC communication. 2. **Auth on all routes**: Added requireManagementAuth to all 6 plugin API route files (list, install, scan, details, activate, deactivate, config). 3. **Env filtering**: Only safe env vars passed to plugin processes unless "env" permission is granted. Co-Authored-By: OpenClaude (mimo-v2.5-pro) <openclaude@gitlawb.com> * fix(plugins): security + ESM fixes for loader and manager loader.ts: - Fix IPC: use process.send()/process.on("message") instead of worker_threads.parentPort - Fix ESM: write host script as .mjs (not .js) to force ESM execution - Add timeout: 10s default on callHook() with Promise.race - Add SIGKILL escalation: SIGTERM first, then SIGKILL after 3s grace - Fix env filtering: use allowlist (safeKeys) instead of passing all env vars - Clear timeout on successful IPC response (no timer leak) manager.ts: - Fix path traversal: use fs.realpath() instead of startsWith() - Fix imports: use registerHook/unregisterHooks from hooks.ts - Register hooks individually via registerHook(event, name, handler) hooks.ts: - Copied from feat/plugin-custom-hooks (canonical registry) * feat(discovery): add discovery tool stub service Phase 1 scaffold for automated provider discovery: - DiscoveryConfig, DiscoveryResult types - probeEndpoint() for URL availability checking - scanProvider() stub (Phase 2 will implement real scanning) - getDiscoveryResults() stub - Default config: disabled (opt-in) * chore(plugins): slop cleanup — pino logger, remove redundant sorts - index.ts: replace console.log/error with pino structured logging - hooks.ts: remove redundant .sort() in emitHookBlocking/runOnResponse (already sorted on registration) - manager.ts: add readFile import * test(plugins): add scanner, loader, manager unit tests - scanner: 9 tests (discovery, hidden dirs, validation, entry point, multiple) - loader: 5 tests (type contracts, Plugin/PluginContext/PluginResult interfaces) - manager: 6 tests (singleton, lifecycle methods, error on unknown) - Total: 20 tests, all passing * fix(settings): add missing home page pin keys to updateSettingsSchema * feat(plugins): add i18n keys to all 42 locales * fix(settings): add missing security keys to updateSettingsSchema and add tests * fix(usage): analytics route reads combo_name/requested_model from call_logs only The 3.8.6 variant of #2904 added SELECTs of combo_name/requested_model against usage_history, but those columns only exist in call_logs (no migration adds them to usage_history). This returned HTTP 500 on /api/usage/analytics. Restore the working query shape from the 3.8.7 variant. Fixes 18 failing usage-analytics-route tests. * fix(types,test): resolve noImplicitAny in progressiveAging + align semaphore test to #2903 gate pruning - progressiveAging: type compression results so messages[0].content is indexable (was TS7053 against {}); restores typecheck:noimplicit:core gate. - services-branch-hardening: #2903 (perf-ram) prunes idle rate-limit gates on zero; assert no-running/empty-queue without assuming the entry persists. * fix(analytics): address merged review regressions * fix(executor): normalize max effort for openai shape providers * Make zero-latency combo optimizations opt-in * Address zero-latency combo review feedback * chore(release): sync v3.8.7 touchpoints + credit contributors - llm.txt → 3.8.7 (Current version + Key Features header) - CHANGELOG: add Dmitry Kuznetsov & Nikolay Alafuzov to 3.8.6 Hall of Contributors - version already 3.8.7 across package.json/open-sse/electron/openapi (from #2909) * fix(cleanup): restore usage history cutoff boundary * docs(changelog): rank 3.8.6 contributors in a commits table with their PRs * fix(dashboard): theme ReactFlow Controls +/- buttons for dark mode * fix(settings): add missing home page pin keys to updateSettingsSchema * fix(settings): add missing security keys to updateSettingsSchema and add tests * fix(executor): normalize max effort for openai shape providers * Make zero-latency combo optimizations opt-in * Address zero-latency combo review feedback * fix(analytics): address merged review regressions * fix(cleanup): restore usage history cutoff boundary * feat(plugins): WordPress-style plugin system backend * fix(plugins): address code review feedback - Path traversal guard: validate entryPoint stays within plugin dir - install() now handles direct plugin directories (not just parent dirs) - Non-null assertion replaced with explicit null check - require efficiency: allowedModules map moved outside function - Source wrapper: add newlines to prevent trailing comment issues - Config validation: validate values against configSchema on save - Dynamic import comment: clarify Node.js caching behavior Co-Authored-By: OpenClaude (mimo-v2.5-pro) <openclaude@gitlawb.com> * fix(plugins): replace vm with child_process, add auth to all routes Addresses all remaining code review feedback: 1. **Loader rewrite**: Replaced Node.js vm module with child_process.fork() for proper process-level isolation. Complies with Rule 3 (no eval). Each plugin runs in a separate Node.js process with IPC communication. 2. **Auth on all routes**: Added requireManagementAuth to all 6 plugin API route files (list, install, scan, details, activate, deactivate, config). 3. **Env filtering**: Only safe env vars passed to plugin processes unless "env" permission is granted. Co-Authored-By: OpenClaude (mimo-v2.5-pro) <openclaude@gitlawb.com> * fix(plugins): security + ESM fixes for loader and manager loader.ts: - Fix IPC: use process.send()/process.on("message") instead of worker_threads.parentPort - Fix ESM: write host script as .mjs (not .js) to force ESM execution - Add timeout: 10s default on callHook() with Promise.race - Add SIGKILL escalation: SIGTERM first, then SIGKILL after 3s grace - Fix env filtering: use allowlist (safeKeys) instead of passing all env vars - Clear timeout on successful IPC response (no timer leak) manager.ts: - Fix path traversal: use fs.realpath() instead of startsWith() - Fix imports: use registerHook/unregisterHooks from hooks.ts - Register hooks individually via registerHook(event, name, handler) hooks.ts: - Copied from feat/plugin-custom-hooks (canonical registry) * feat(discovery): add discovery tool stub service Phase 1 scaffold for automated provider discovery: - DiscoveryConfig, DiscoveryResult types - probeEndpoint() for URL availability checking - scanProvider() stub (Phase 2 will implement real scanning) - getDiscoveryResults() stub - Default config: disabled (opt-in) * chore(plugins): slop cleanup — pino logger, remove redundant sorts - index.ts: replace console.log/error with pino structured logging - hooks.ts: remove redundant .sort() in emitHookBlocking/runOnResponse (already sorted on registration) - manager.ts: add readFile import * test(plugins): add scanner, loader, manager unit tests - scanner: 9 tests (discovery, hidden dirs, validation, entry point, multiple) - loader: 5 tests (type contracts, Plugin/PluginContext/PluginResult interfaces) - manager: 6 tests (singleton, lifecycle methods, error on unknown) - Total: 20 tests, all passing * feat(plugins): add i18n keys to all 42 locales * chore(plugins): remove duplicate migration 059_create_plugins.sql * chore(plugins): remove duplicate migration 059_create_plugins.sql (post-merge) * fix(sse): guard non-string error.code in proxyFetch + harden model parsing (#2463) (#2923) Integrated into release/v3.8.7 * fix(docker): add runner-web stage with Playwright Chromium (#2832) (#2846) Integrated into release/v3.8.7 * docs(changelog): document NVIDIA NIM and error code type-crash fix (#2463) * test: ignore NVIDIA_BASE_URL and NVIDIA_MODEL in env contract check --------- Co-authored-by: oyi77 <oyi77@users.noreply.github.com> Co-authored-by: OpenClaude (mimo-v2.5-pro) <openclaude@gitlawb.com> Co-authored-by: Apostol Apostolov <theapoapostolov@gmail.com> Co-authored-by: Halil Tezcan KARABULUT <info@hlltzcnkb.com> Co-authored-by: R.D. <rogerproself@gmail.com>
172 lines
5.1 KiB
TypeScript
172 lines
5.1 KiB
TypeScript
/**
|
|
* Combo Configuration Resolver
|
|
*
|
|
* Implements 3-layer cascade: Global Defaults → Provider Overrides → Per-Combo Config
|
|
* Most specific wins.
|
|
*/
|
|
|
|
import { MAX_TIMER_TIMEOUT_MS } from "../../src/shared/utils/runtimeTimeouts.ts";
|
|
|
|
const DEFAULT_COMBO_CONFIG = {
|
|
strategy: "priority",
|
|
maxRetries: 1,
|
|
retryDelayMs: 2000,
|
|
fallbackDelayMs: 0,
|
|
concurrencyPerModel: 3, // max simultaneous requests per model (round-robin)
|
|
queueTimeoutMs: 30000, // max wait time in semaphore queue (round-robin)
|
|
handoffThreshold: 0.85,
|
|
handoffModel: "",
|
|
handoffProviders: ["codex"],
|
|
maxMessagesForSummary: 30,
|
|
maxComboDepth: 3,
|
|
trackMetrics: true,
|
|
manifestRouting: false,
|
|
resetAwareSessionWeight: 0.35,
|
|
resetAwareWeeklyWeight: 0.65,
|
|
resetAwareTieBandPercent: 5,
|
|
resetAwareExhaustionGuardPercent: 10,
|
|
failoverBeforeRetry: true,
|
|
maxSetRetries: 0,
|
|
setRetryDelayMs: 2000,
|
|
// Zero-latency optimizations are opt-in because some modes can race targets or
|
|
// mutate fallback request bodies for lower tail latency.
|
|
zeroLatencyOptimizationsEnabled: false,
|
|
// Hedging (Speculative Execution) defaults
|
|
hedging: false,
|
|
hedgeDelayMs: 500,
|
|
// Mid-Stream Fallback Compression defaults
|
|
fallbackCompressionMode: "lite",
|
|
fallbackCompressionThreshold: 1000,
|
|
// Predictive TTFT Circuit Breaker defaults
|
|
predictiveTtftMs: 0,
|
|
// Pipeline defaults
|
|
pipeline_enabled: false,
|
|
task_detection: "pattern",
|
|
max_reflection_loops: 1,
|
|
skip_pipeline_for_tokens_under: 50,
|
|
pipeline_fallback: "single-provider",
|
|
resetAwareQuotaCacheTtlMs: 0,
|
|
resetAwareQuotaCacheMaxStaleMs: 0,
|
|
shadowRouting: {
|
|
enabled: false,
|
|
targets: [],
|
|
sampleRate: 1,
|
|
maxTargets: 2,
|
|
timeoutMs: 30000,
|
|
},
|
|
evalRouting: {
|
|
enabled: false,
|
|
suiteIds: [],
|
|
maxAgeHours: 720,
|
|
minCases: 1,
|
|
qualityWeight: 0.85,
|
|
latencyWeight: 0.15,
|
|
cacheTtlMs: 60000,
|
|
},
|
|
};
|
|
|
|
const LEGACY_COMBO_RESILIENCE_KEYS = new Set([
|
|
"timeoutMs",
|
|
"healthCheckEnabled",
|
|
"healthCheckTimeoutMs",
|
|
]);
|
|
|
|
type ComboConfigRecord = Record<string, unknown>;
|
|
|
|
type ComboConfigLike =
|
|
| {
|
|
config?: ComboConfigRecord | null;
|
|
}
|
|
| null
|
|
| undefined;
|
|
|
|
type ComboSettingsLike =
|
|
| {
|
|
comboDefaults?: ComboConfigRecord | null;
|
|
providerOverrides?: Record<string, ComboConfigRecord | null | undefined> | null;
|
|
}
|
|
| null
|
|
| undefined;
|
|
|
|
function isRecord(value: unknown): value is ComboConfigRecord {
|
|
return !!value && typeof value === "object" && !Array.isArray(value);
|
|
}
|
|
|
|
function normalizePositiveTimeoutMs(value: unknown): number {
|
|
const numericValue = Number(value);
|
|
if (!Number.isFinite(numericValue) || numericValue <= 0) return 0;
|
|
return Math.min(Math.floor(numericValue), MAX_TIMER_TIMEOUT_MS);
|
|
}
|
|
|
|
export function resolveComboTargetTimeoutMs(
|
|
config: Record<string, unknown> | null | undefined,
|
|
upstreamTimeoutMs: number
|
|
): number {
|
|
const inheritedTimeoutMs = normalizePositiveTimeoutMs(upstreamTimeoutMs);
|
|
const configuredTimeoutMs = isRecord(config)
|
|
? normalizePositiveTimeoutMs(config.targetTimeoutMs)
|
|
: 0;
|
|
|
|
if (configuredTimeoutMs <= 0) return inheritedTimeoutMs;
|
|
if (inheritedTimeoutMs <= 0) return configuredTimeoutMs;
|
|
return Math.min(configuredTimeoutMs, inheritedTimeoutMs);
|
|
}
|
|
|
|
/**
|
|
* Resolve effective config for a combo, applying cascade:
|
|
* DEFAULT_COMBO_CONFIG → settings.comboDefaults → settings.providerOverrides[provider] → combo.config
|
|
*
|
|
* @param {Object} combo - The combo object { config, ... }
|
|
* @param {Object} settings - App settings from localDb
|
|
* @param {string} [provider] - Optional provider to apply provider-level overrides
|
|
* @returns {Object} Resolved config
|
|
*/
|
|
export function resolveComboConfig(
|
|
combo: ComboConfigLike,
|
|
settings: ComboSettingsLike,
|
|
provider?: string | null
|
|
) {
|
|
const global = settings?.comboDefaults || {};
|
|
const providerOverride = provider ? settings?.providerOverrides?.[provider] || {} : {};
|
|
const comboConfig = combo?.config || {};
|
|
|
|
// Clean undefined values before spreading
|
|
const clean = (obj: ComboConfigRecord) =>
|
|
Object.fromEntries(
|
|
Object.entries(obj).filter(
|
|
([key, value]) =>
|
|
value !== undefined && value !== null && !LEGACY_COMBO_RESILIENCE_KEYS.has(key)
|
|
)
|
|
);
|
|
|
|
const merged = {
|
|
...DEFAULT_COMBO_CONFIG,
|
|
...clean(global),
|
|
...clean(providerOverride),
|
|
...clean(comboConfig),
|
|
};
|
|
|
|
return {
|
|
...merged,
|
|
shadowRouting: {
|
|
...DEFAULT_COMBO_CONFIG.shadowRouting,
|
|
...(isRecord(global.shadowRouting) ? clean(global.shadowRouting) : {}),
|
|
...(isRecord(providerOverride.shadowRouting) ? clean(providerOverride.shadowRouting) : {}),
|
|
...(isRecord(comboConfig.shadowRouting) ? clean(comboConfig.shadowRouting) : {}),
|
|
},
|
|
evalRouting: {
|
|
...DEFAULT_COMBO_CONFIG.evalRouting,
|
|
...(isRecord(global.evalRouting) ? clean(global.evalRouting) : {}),
|
|
...(isRecord(providerOverride.evalRouting) ? clean(providerOverride.evalRouting) : {}),
|
|
...(isRecord(comboConfig.evalRouting) ? clean(comboConfig.evalRouting) : {}),
|
|
},
|
|
};
|
|
}
|
|
|
|
/**
|
|
* Get the default combo config (used when no overrides exist)
|
|
*/
|
|
export function getDefaultComboConfig() {
|
|
return { ...DEFAULT_COMBO_CONFIG };
|
|
}
|