mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-07-31 12:22:14 +03:00
838fddacee
* fix(dashboard): OAuth modal surfaces real error on non-JSON responses (port from 9router#1318) The OAuth connect/reauth modal called `await res.json()` unconditionally, so a non-JSON error response (e.g. a plain-text 500 page from a build/OAuth endpoint) threw `Unexpected token 'I'...` and hid the real failure. New shared helpers parseResponseBody / getErrorMessage (src/shared/utils/api.ts) read the body safely (JSON when JSON, raw text otherwise) and produce a clean message either way; every modal fetch site now uses them. Reported-by: DNNYF (https://github.com/decolua/9router/issues/1318) Co-authored-by: DNNYF <74033321+DNNYF@users.noreply.github.com> * fix(dashboard): type OAuth modal response body as Record<string, unknown> (t11 any-budget) Switch the parseResponseBody casts from Record<string, any> to Record<string, unknown> so OAuthModal.tsx stays within its t11 explicit-any budget. getErrorMessage already takes unknown; the success paths typecheck clean under strict:false. No runtime change. --------- Co-authored-by: DNNYF <74033321+DNNYF@users.noreply.github.com>
35 lines
1.7 KiB
TypeScript
35 lines
1.7 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
|
|
// Regression for port-from-9router#1318: the OAuth modal called `await res.json()`
|
|
// unconditionally, so a non-JSON error response (e.g. a plain-text `Internal Server
|
|
// Error` 500 from a Build-OAuth endpoint) threw `Unexpected token 'I'…` instead of
|
|
// surfacing the real failure. The shared `parseResponseBody`/`getErrorMessage`
|
|
// helpers read the body safely and produce a clean message either way.
|
|
const { parseResponseBody, getErrorMessage } = await import("../../src/shared/utils/api.ts");
|
|
|
|
test("#1318: parseResponseBody returns parsed JSON for a JSON body", async () => {
|
|
const res = new Response(JSON.stringify({ error: "nope" }), {
|
|
status: 400,
|
|
headers: { "Content-Type": "application/json" },
|
|
});
|
|
assert.deepEqual(await parseResponseBody(res), { error: "nope" });
|
|
});
|
|
|
|
test("#1318: parseResponseBody returns raw text for a non-JSON body (no throw)", async () => {
|
|
const res = new Response("Internal Server Error", { status: 500 });
|
|
assert.equal(await parseResponseBody(res), "Internal Server Error");
|
|
});
|
|
|
|
test("#1318: parseResponseBody returns null for an empty body", async () => {
|
|
const res = new Response("", { status: 200 });
|
|
assert.equal(await parseResponseBody(res), null);
|
|
});
|
|
|
|
test("#1318: getErrorMessage handles string-error, nested-error, plain-text and fallback", () => {
|
|
assert.equal(getErrorMessage({ error: "bad key" }), "bad key");
|
|
assert.equal(getErrorMessage({ error: { message: "expired" } }), "expired");
|
|
assert.equal(getErrorMessage("Internal Server Error"), "Internal Server Error");
|
|
assert.equal(getErrorMessage(null, 500, "Save failed"), "Save failed (HTTP 500)");
|
|
});
|