mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-08-14 19:22:32 +03:00
26096e6706
Drains the HARD failures reported by Release-Green run 31693210948 on issue #9985 (ESLint errors: 2) plus the merge-integrity red every open PR is inheriting. - ESLint error 1: @omniroute/opencode-plugin/src/index.ts had a stray extra '});' (introduced by #9316) that broke parsing with 'unexpected file in NFT list' on the build path. - ESLint error 2: cli-env-inline-comment-10100.test.ts used new Function to extract parseEnvValue from the bin entrypoint (no-new-func, Hard Rule #3). Extracted the helper to bin/cli/utils/parseEnvValue.mjs and import it from both the entrypoint and the test (same behavior, no eval). - open-sse-typecheck (Fast Quality Gates): open-sse/utils/stream.ts imported sseCommentsEnabled twice (#9378) causing TS2300 Duplicate identifier; removed the duplicate import. - Merge integrity (changelog + generated skills): skills/omni-settings/SKILL.md was edited manually by #10169 without updating the generator source, so check:agent-skills-sync failed on every PR (Generated: 1). Moved the curated thinking-budget content into a <!-- skill:custom-start --> block (the documented preservation mechanism), which the generator now keeps in sync. Refs #9985
53 lines
2.3 KiB
TypeScript
53 lines
2.3 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import path from "node:path";
|
|
import { parseEnvValue } from "../../bin/cli/utils/parseEnvValue.mjs";
|
|
|
|
// #10100 — the .env loader kept inline comments inside values, so the shipped
|
|
// `QUOTA_STORE_DRIVER=sqlite # sqlite | redis` line produced the literal value
|
|
// "sqlite # sqlite | redis". Consumers compare with `===`, so a
|
|
// user annotating `QUOTA_STORE_DRIVER=redis # ...` silently got SQLite with no
|
|
// warning (the existing warning lives inside the `redis` branch).
|
|
|
|
test("an unquoted inline comment is stripped", () => {
|
|
assert.equal(parseEnvValue("sqlite # sqlite | redis"), "sqlite");
|
|
assert.equal(parseEnvValue("redis # sqlite | redis"), "redis");
|
|
assert.equal(parseEnvValue("value\t# tab-separated comment"), "value");
|
|
});
|
|
|
|
test("a '#' with no preceding whitespace is part of the value", () => {
|
|
// dotenv semantics — passwords and fragments must survive.
|
|
assert.equal(parseEnvValue("pass#word"), "pass#word");
|
|
assert.equal(
|
|
parseEnvValue("https://example.com/page#section"),
|
|
"https://example.com/page#section"
|
|
);
|
|
});
|
|
|
|
test("quoted values are returned verbatim, including '#'", () => {
|
|
assert.equal(parseEnvValue('"sqlite # not a comment"'), "sqlite # not a comment");
|
|
assert.equal(parseEnvValue("'a # b'"), "a # b");
|
|
// A comment may still follow a closing quote.
|
|
assert.equal(parseEnvValue('"sqlite" # sqlite | redis'), "sqlite");
|
|
});
|
|
|
|
test("plain values are unchanged", () => {
|
|
assert.equal(parseEnvValue("sqlite"), "sqlite");
|
|
assert.equal(parseEnvValue(" spaced "), "spaced");
|
|
assert.equal(parseEnvValue(""), "");
|
|
});
|
|
|
|
test(".env.example no longer annotates QUOTA_STORE_DRIVER inline", () => {
|
|
const example = fs.readFileSync(path.resolve(".env.example"), "utf8");
|
|
const line = example.split("\n").find((l) => l.startsWith("QUOTA_STORE_DRIVER="));
|
|
assert.ok(line, "QUOTA_STORE_DRIVER should still be documented");
|
|
assert.equal(line, "QUOTA_STORE_DRIVER=sqlite");
|
|
// Guard the whole file against reintroducing the pattern on unquoted values.
|
|
const offenders = example
|
|
.split("\n")
|
|
.filter((l) => /^[A-Z0-9_]+=[^"'#\n]*\s#/.test(l))
|
|
.slice(0, 5);
|
|
assert.deepEqual(offenders, [], `unquoted inline comments would land in the value: ${offenders}`);
|
|
});
|