mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-07-31 04:12:10 +03:00
a7d9c803d6
3 fixes from independent round-3 code review:
- R1: Exclude BUTTON from the wizard global Enter handler. With Back/Cancel/Create focused, the browser already activates the focused button on Enter; a global Next dispatch on top would conflict (Back focused + Enter → both back and next dispatched in the same tick, last-write-wins is indeterminate). Now Enter only fires the Next dispatch when focus is on a non-interactive element (modal body). Verified the reducer SET_STEP uses an absolute step value so even if a double-dispatch were possible, it converges — but excluding BUTTON eliminates the redundant work and the focus-on-Back failure mode.
- R2: deriveProvider in BatchListTab refactored to return a discriminator ("OpenAI"/"Anthropic"/"Gemini"/"other"/"unknown") with vendor names left un-translated (proper nouns) and other/unknown routed through t("batchListProviderOther") / t("batchListProviderUnknown") at the call-site. Heuristic expanded: gpt-, chatgpt-, /^o[1-9](-|$)/ (catches o1-preview, o3-mini, o4-mini), text-embedding-, dall-e, whisper, tts- → OpenAI; claude- → Anthropic; gemini → Gemini. Kills the "chatgpt-4o-latest → Other" misclassification + the previously dead batchListProviderUnknown key + a hardcoded English "Other" leak.
- B-2b: InputStep race guard moved from useState to useRef (isReadingRef) so concurrent processFile calls in the same tick (drop + file-pick before the next React render) cannot both pass the early-return. State mirror kept for UI rendering.
Tests: 2 new cases in list-regression — test 19 covers chatgpt-4o-latest / o1-preview / o3-mini all rendering "OpenAI" 3×; test 20 asserts unknown + null model produce t("batchListProviderOther") / t("batchListProviderUnknown") (proves no hardcoded English leak). 1 new i18n key (batchListProviderOther) added in en + pt-BR and propagated to 40 locales via fill-missing-from-en.mjs.