Files
OmniRoute/tests/unit/radar-flag-default.test.ts
Praveen K Palaniswamy 65e81158ab fix(ollama): route models by advertised capability (#11088)
Landed with the design call resolved per the owner's pick — **option 1**: the synced store is now endpoint-agnostic (persistDiscoveredModels and managedModelImport no longer drop non-chat models at write time), and chat selectability moved to read time (auto-pool expansion in autoStrategy applies filterChatSelectableModels; the models-route projection already had its chatOnly filter). Your discovery test now passes end-to-end (3/3): /api/show capabilities persist per connection and image/embedding requests route through the advertising host.

Reconciliation notes: conflicted areas merged onto the current tip (adobe discovery import, requestedModel preflight signature, resolvedProvider fast-path coexists with the synced-route override — explicit resolution wins); carried base-red drains (#10055 memoization, #11071 test variants) dropped as already-landed; the managed-model-import exclusion test was propagated to the new contract (image/video models persist; the read filter still hides them from chat pickers — pinned by a new assertion). Full battery: 205/206 focused (the one red is a confirmed periodic-timer timing flake on the loaded devbox — 20/20 isolated), autoCombo vitest 30/30, combo suites 46/46, gates + typecheck clean.

Thank you @yourspraveen — the capability probe + routing design was right; it just needed the store contract opened up. Fixes #11087.
2026-08-23 11:45:01 -03:00

61 lines
2.2 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
// Regression guard: the RADAR_ENABLED feature flag must default to OFF so that
// a vanilla OmniRoute install is byte-identical to today. The Radar module
// (catalog feed screens and data sync) is a freemium add-on and must never
// activate without explicit operator opt-in.
// Isolate DB state so the resolution chain (DB override > env > default) reads
// a clean store and we exercise the definition default, not a leaked override.
const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-test-radar-default-"));
process.env.DATA_DIR = tmpDir;
const { FEATURE_FLAG_DEFINITIONS } = await import(
"../../src/shared/constants/featureFlagDefinitions.ts"
);
test("RADAR_ENABLED feature flag defaults to OFF", async (t) => {
const def = (key: string) => FEATURE_FLAG_DEFINITIONS.find((d) => d.key === key);
await t.test("RADAR_ENABLED definition exists", () => {
const d = def("RADAR_ENABLED");
assert.ok(d, "RADAR_ENABLED definition must exist in FEATURE_FLAG_DEFINITIONS");
});
await t.test("RADAR_ENABLED default value is 'false'", () => {
const d = def("RADAR_ENABLED");
assert.strictEqual(
d!.defaultValue,
"false",
"RADAR_ENABLED must default OFF — Radar is an opt-in add-on"
);
});
await t.test("RADAR_ENABLED category is 'policies'", () => {
const d = def("RADAR_ENABLED");
assert.strictEqual(
d!.category,
"policies",
"RADAR_ENABLED must be in the 'policies' category"
);
});
await t.test("RADAR_ENABLED type is 'boolean'", () => {
const d = def("RADAR_ENABLED");
assert.strictEqual(d!.type, "boolean", "RADAR_ENABLED must be a boolean flag");
});
await t.test("effective runtime resolution is OFF with no override", async () => {
delete process.env.RADAR_ENABLED;
const { clearAllFeatureFlagOverrides } = await import("@/lib/db/featureFlags");
clearAllFeatureFlagOverrides();
const { isFeatureFlagEnabled } = await import("@/shared/utils/featureFlags");
assert.strictEqual(isFeatureFlagEnabled("RADAR_ENABLED"), false);
});
});