Files
OmniRoute/scripts/check/check-vitest-exclusions.mjs
Diego Rodrigues de Sa e Souza f7dbfc88c7 chore(tests): revive 51 vitest files parked behind a closed tracker (#13204) (#13233)
Merged after reconciling against the tip. `docs/architecture/QUALITY_GATES.md` conflicted: this PR adds the `check:vitest-exclusions` row while the tip had meanwhile rewritten the `check:model-lifecycle` description (#12535). Resolved to the tip's table plus the new row.

- `check:vitest-exclusions`: OK, 11 excluded files, each tracked and referenced
- ESLint over the changed files: exit 0
- `npm run test:vitest` (the config this PR edits): 472 of 473. The one red, `tests/unit/autoCombo/provider-family-combos.test.ts`, is not touched by this PR and passes 11/11 in isolation on both this branch and the pure tip — a load flake from the full run, not a regression.

⚠️ base-red inherited: #12732
2026-09-14 13:40:46 -03:00

157 lines
5.9 KiB
JavaScript

#!/usr/bin/env node
/**
* OmniRoute — Vitest exclusion gate (CI gate, blocking).
*
* Every file parked in `vitest.config.ts`'s `exclude` list is a test that does not run.
* A skipped test is indistinguishable from a test that does not exist, with the added
* hazard of LOOKING like coverage to whoever reads the file tree.
*
* Why this gate exists (the incident it encodes): 62 files accumulated behind the comment
* `// #8618 — pre-existing failure; remove this exclusion when fixed`. Issue #8618 was
* CLOSED on 2026-08-11 while the list it tracked kept growing — from 45 entries to 62 —
* each new exclusion inheriting a comment that pointed at a dead issue. When the list was
* finally measured file by file (#13204), **51 of the 62 passed against the current tree
* with no source change**: the exclusions had outlived the failures that justified them by
* months, and nothing in CI could say so.
*
* The gate enforces the two properties that would have caught it:
*
* 1. Every excluded path that resolves to a real file carries an issue reference
* (`#<number>`) in a trailing comment. An exclusion without a tracker is invisible
* debt.
* 2. The set of excluded files matches the checked-in inventory
* (`config/quality/vitest-exclusions.json`). Adding an exclusion becomes a visible,
* reviewable diff in a dedicated file instead of one more line lost in a 60-entry
* array.
*
* What it deliberately does NOT do: re-run the excluded tests to see whether they pass
* again. That costs ~10 minutes and belongs in a periodic job, not in a per-PR gate. The
* inventory records the measured status and the date so a reader knows how stale it is.
*
* Standard tooling exclusions (`node_modules/**`, glob patterns, the live-server E2E specs
* that have their own runner) are exempt — they are configuration, not debt.
*
* Usage:
* node scripts/check/check-vitest-exclusions.mjs # strict, exit 1 on violation
* node scripts/check/check-vitest-exclusions.mjs --json # machine-readable
*/
import fs from "node:fs";
import path from "node:path";
import process from "node:process";
import { fileURLToPath } from "node:url";
const SCRIPT_DIR = path.dirname(fileURLToPath(import.meta.url));
const ROOT = path.resolve(SCRIPT_DIR, "..", "..");
const CONFIG = path.join(ROOT, "vitest.config.ts");
const INVENTORY = path.join(ROOT, "config/quality/vitest-exclusions.json");
/** Exclusions that are tooling configuration rather than parked debt. */
const EXEMPT = new Set([
"node_modules/**",
"dist/**",
"cypress/**",
".idea/**",
".git/**",
".cache/**",
// Live-server E2E: their own runner + vitest.e2e-live.config.ts, never this jsdom job.
"tests/e2e/ecosystem.test.ts",
"tests/e2e/protocol-clients.test.ts",
]);
/**
* Parse the `exclude` array out of vitest.config.ts, keeping each entry's trailing comment.
*
* @returns {Array<{ pattern: string, comment: string }>}
*/
export function parseExclusions(source) {
const block = source.match(/exclude:\s*\[([\s\S]*?)\n {4}\]/);
if (!block) return [];
const out = [];
for (const line of block[1].split("\n")) {
const pattern = line.match(/"([^"]+)"/);
if (!pattern) continue;
const comment = line.slice(line.indexOf(pattern[0]) + pattern[0].length);
out.push({ pattern: pattern[1], comment: comment.trim() });
}
return out;
}
/**
* Pure core: which exclusions violate the gate?
*
* @param {Array<{pattern: string, comment: string}>} entries
* @param {(p: string) => boolean} exists
* @param {string[]} inventory paths recorded in the checked-in inventory
*/
export function findViolations(entries, exists, inventory) {
const tracked = new Set(inventory);
const untracked = [];
const unreferenced = [];
const seen = new Set();
for (const { pattern, comment } of entries) {
if (EXEMPT.has(pattern) || pattern.includes("*")) continue;
if (!exists(pattern)) continue; // a stale path excludes nothing
seen.add(pattern);
if (!/#\d+/.test(comment)) unreferenced.push(pattern);
if (!tracked.has(pattern)) untracked.push(pattern);
}
const orphaned = inventory.filter((p) => !seen.has(p));
return { unreferenced, untracked, orphaned };
}
function main() {
const json = process.argv.includes("--json");
const entries = parseExclusions(fs.readFileSync(CONFIG, "utf8"));
const inventory = fs.existsSync(INVENTORY)
? JSON.parse(fs.readFileSync(INVENTORY, "utf8")).excluded.map((e) => e.file)
: [];
const { unreferenced, untracked, orphaned } = findViolations(
entries,
(p) => fs.existsSync(path.join(ROOT, p)),
inventory
);
if (json) {
console.log(JSON.stringify({ unreferenced, untracked, orphaned }, null, 2));
}
const failed = unreferenced.length + untracked.length + orphaned.length;
if (!failed) {
console.log(
`[vitest-exclusions] OK — ${inventory.length} excluded file(s), each tracked and referenced.`
);
return;
}
if (unreferenced.length) {
console.error(
`\n[vitest-exclusions] FAIL — ${unreferenced.length} exclusion(s) carry no issue reference:`
);
for (const p of unreferenced) console.error(`${p}`);
console.error(
" Add a trailing comment naming an OPEN tracking issue, e.g. // #13204 — reason"
);
}
if (untracked.length) {
console.error(
`\n[vitest-exclusions] FAIL — ${untracked.length} exclusion(s) missing from ${path.relative(ROOT, INVENTORY)}:`
);
for (const p of untracked) console.error(`${p}`);
console.error(" Record it there with its measured status, so the debt is reviewable.");
}
if (orphaned.length) {
console.error(
`\n[vitest-exclusions] FAIL — ${orphaned.length} inventory entr(ies) no longer excluded:`
);
for (const p of orphaned) console.error(`${p}`);
console.error(" The test runs again — drop it from the inventory.");
}
process.exit(1);
}
if (import.meta.url === `file://${process.argv[1]}`) main();