mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-14 19:02:17 +03:00
b3f6f697ef
`main` has been red since b342c1a361 on the vitest and integration gates:
✖ tests/unit/autoCombo/provider-family-combos.test.ts > auto/<family>
✖ chat pipeline applies Codex OAuth fingerprint and priority tier inside combos
Both call resetStorage() from beforeEach, which does an fs.rmSync(TEST_DATA_DIR,
{recursive: true, force: true}) with no retry, and intermittently loses the race
with a not-yet-released SQLite handle (ENOTEMPTY).
release/v3.8.51 fixed this in #11968 with a mechanical codemod adding
maxRetries/retryDelay to every recursive rm/rmSync/rmdirSync under tests/, but
that PR landed only on the release branch. Because main only receives work at
the release squash, it stayed broken for the whole cycle — and repo-wide gates
then turn every open PR into main red on checks unrelated to their diff.
This is the --base main twin: re-runs the same codemod that already shipped on
the release branch (scripts/ad-hoc/codemod-rm-maxretries.mjs), so the two
branches converge on identical test-teardown semantics. Test-only; no product
logic is touched.
The remaining three failures reported on #12133 (unit full suite exceeding its
4800s ceiling, package-artifact exceeding 1200s, and the boot-smoke that is
skipped as a consequence) are runner-contention timeouts, not code defects —
validate-release-green.mjs runs those heavy gates concurrently on one shared
hosted runner. There is no fix to port for those.
53 lines
2.7 KiB
TypeScript
53 lines
2.7 KiB
TypeScript
// Test-only DATA_DIR isolation.
|
|
//
|
|
// Loaded via `node --import ./tests/_setup/isolateDataDir.ts` from the test/mutation
|
|
// invocations (package.json test scripts, stryker.conf.json tap.nodeArgs, the
|
|
// quality.yml TIA step, and the CI test jobs) — NEVER from production. It MUST stay
|
|
// out of open-sse/utils/setupPolyfill.ts, which is also imported by production
|
|
// (bin/omniroute.mjs, proxyFetch.ts, proxyDispatcher.ts) where redirecting DATA_DIR
|
|
// would point the live SQLite DB at a throwaway temp dir.
|
|
//
|
|
// Why: node:test spawns a process per test file and Stryker spawns one per sandbox,
|
|
// but every process resolves DATA_DIR to the SAME default (~/.omniroute) when the env
|
|
// var is unset (see src/lib/dataPaths.ts::resolveDataDir). Concurrent processes then
|
|
// open the SAME on-disk storage.sqlite, causing cross-file state races: SQLite lock
|
|
// contention that hangs `test:unit` under high `--test-concurrency`, and the
|
|
// non-deterministic baseline that forced Stryker to `concurrency: 1`.
|
|
//
|
|
// Giving each process its own DATA_DIR under the OS temp dir removes the shared file,
|
|
// so concurrent test processes never collide. Tests that set DATA_DIR explicitly keep
|
|
// winning — this only fills in an isolated default when none was chosen.
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
// File logger worker threads can outlive a test's temporary DATA_DIR cleanup and then
|
|
// raise ENOENT/ENOTEMPTY after the test has already passed. Keep the global test default
|
|
// console-only; tests that cover file logging explicitly set APP_LOG_TO_FILE themselves.
|
|
process.env.APP_LOG_TO_FILE ||= "false";
|
|
|
|
if (!process.env.DATA_DIR) {
|
|
const dir = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-test-"));
|
|
process.env.DATA_DIR = dir;
|
|
|
|
// Best-effort cleanup so a long suite run does not leak hundreds of temp DBs.
|
|
process.on("exit", () => {
|
|
try {
|
|
fs.rmSync(dir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
} catch {
|
|
// ignore — the OS reaps its temp dir eventually.
|
|
}
|
|
});
|
|
}
|
|
|
|
// System-trust guard: the suite must NEVER mutate the OS trust store. On a
|
|
// persistent self-hosted runner the cert-flow integration test installed a fake
|
|
// 105-byte PEM into /usr/local/share/ca-certificates and update-ca-certificates
|
|
// baked it into the bundle, breaking ALL system TLS on the VM (2026-07-05).
|
|
// installCert/uninstallCert/installTproxyCa/uninstallTproxyCa no-op under this.
|
|
process.env.OMNIROUTE_SKIP_SYSTEM_TRUST = "1";
|
|
|
|
// DNS-write guard: the suite must NEVER mutate /etc/hosts. Tests that exercise
|
|
// the real MITM path call addDNSEntries(); this env var makes it a no-op.
|
|
process.env.OMNIROUTE_SKIP_DNS_WRITE = "1";
|