Files
OmniRoute/tests/unit/cli-data-dir-env.test.ts
diegosouzapw b3f6f697ef test(infra): retry recursive temp-dir removal on main (main twin of #11968)
`main` has been red since b342c1a361 on the vitest and integration gates:

  ✖ tests/unit/autoCombo/provider-family-combos.test.ts > auto/<family>
  ✖ chat pipeline applies Codex OAuth fingerprint and priority tier inside combos

Both call resetStorage() from beforeEach, which does an fs.rmSync(TEST_DATA_DIR,
{recursive: true, force: true}) with no retry, and intermittently loses the race
with a not-yet-released SQLite handle (ENOTEMPTY).

release/v3.8.51 fixed this in #11968 with a mechanical codemod adding
maxRetries/retryDelay to every recursive rm/rmSync/rmdirSync under tests/, but
that PR landed only on the release branch. Because main only receives work at
the release squash, it stayed broken for the whole cycle — and repo-wide gates
then turn every open PR into main red on checks unrelated to their diff.

This is the --base main twin: re-runs the same codemod that already shipped on
the release branch (scripts/ad-hoc/codemod-rm-maxretries.mjs), so the two
branches converge on identical test-teardown semantics. Test-only; no product
logic is touched.

The remaining three failures reported on #12133 (unit full suite exceeding its
4800s ceiling, package-artifact exceeding 1200s, and the boot-smoke that is
skipped as a consequence) are runner-contention timeouts, not code defects —
validate-release-green.mjs runs those heavy gates concurrently on one shared
hosted runner. There is no fix to port for those.
2026-09-01 00:16:48 -03:00

69 lines
2.4 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
import { fileURLToPath } from "node:url";
import { resolveDataDir as cliResolveDataDir } from "../../bin/cli/data-dir.mjs";
import { resolveDataDir as runtimeResolveDataDir } from "../../src/lib/dataPaths.ts";
const REPO_ROOT = path.join(path.dirname(fileURLToPath(import.meta.url)), "..", "..");
const BIN = path.join(REPO_ROOT, "bin", "omniroute.mjs");
async function withTempEnv(
fn: (paths: { root: string; home: string; cwd: string }) => void | Promise<void>
) {
const originalEnv = { ...process.env };
const originalCwd = process.cwd();
const root = fs.mkdtempSync(path.join(os.tmpdir(), "omni-cli-env-"));
const home = path.join(root, "home");
const cwd = path.join(root, "cwd");
fs.mkdirSync(home, { recursive: true });
fs.mkdirSync(cwd, { recursive: true });
delete process.env.DATA_DIR;
delete process.env.XDG_CONFIG_HOME;
delete process.env.APPDATA;
process.env.HOME = home;
process.chdir(cwd);
try {
await fn({ root, home, cwd });
} finally {
process.chdir(originalCwd);
for (const key of Object.keys(process.env)) {
if (!(key in originalEnv)) delete process.env[key];
}
for (const [key, value] of Object.entries(originalEnv)) {
process.env[key] = value;
}
fs.rmSync(root, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
}
}
test("CLI data dir preserves existing legacy ~/.omniroute before XDG", async () => {
await withTempEnv(({ home, root }) => {
const legacyDir = path.join(home, ".omniroute");
fs.mkdirSync(legacyDir, { recursive: true });
process.env.XDG_CONFIG_HOME = path.join(root, "xdg");
assert.equal(cliResolveDataDir(), legacyDir);
assert.equal(cliResolveDataDir(), runtimeResolveDataDir());
});
});
test("CLI env loader scans all env paths while preserving first value wins", () => {
const source = fs.readFileSync(BIN, "utf8");
const loaderStart = source.indexOf("function loadEnvFile()");
const loaderEnd = source.indexOf("loadEnvFile();", loaderStart);
const loaderSource = source.slice(loaderStart, loaderEnd);
assert.match(loaderSource, /for \(const envPath of envPaths\)/);
assert.match(loaderSource, /if \(process\.env\[key\] === undefined\)/);
assert.doesNotMatch(
loaderSource,
/Loaded env from \$\{envPath\}[\s\S]{0,80}\breturn;/
);
});