Files
OmniRoute/tests/unit/executor-devin-cli-acp-protocol-8406.test.ts
diegosouzapw b3f6f697ef test(infra): retry recursive temp-dir removal on main (main twin of #11968)
`main` has been red since b342c1a361 on the vitest and integration gates:

  ✖ tests/unit/autoCombo/provider-family-combos.test.ts > auto/<family>
  ✖ chat pipeline applies Codex OAuth fingerprint and priority tier inside combos

Both call resetStorage() from beforeEach, which does an fs.rmSync(TEST_DATA_DIR,
{recursive: true, force: true}) with no retry, and intermittently loses the race
with a not-yet-released SQLite handle (ENOTEMPTY).

release/v3.8.51 fixed this in #11968 with a mechanical codemod adding
maxRetries/retryDelay to every recursive rm/rmSync/rmdirSync under tests/, but
that PR landed only on the release branch. Because main only receives work at
the release squash, it stayed broken for the whole cycle — and repo-wide gates
then turn every open PR into main red on checks unrelated to their diff.

This is the --base main twin: re-runs the same codemod that already shipped on
the release branch (scripts/ad-hoc/codemod-rm-maxretries.mjs), so the two
branches converge on identical test-teardown semantics. Test-only; no product
logic is touched.

The remaining three failures reported on #12133 (unit full suite exceeding its
4800s ceiling, package-artifact exceeding 1200s, and the boot-smoke that is
skipped as a consequence) are runner-contention timeouts, not code defects —
validate-release-green.mjs runs those heavy gates concurrently on one shared
hosted runner. There is no fix to port for those.
2026-09-01 00:16:48 -03:00

121 lines
3.8 KiB
TypeScript

// #8406: devin-cli ACP wire-format protocol fixes
import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
import { writeFileSync } from "node:fs";
const mod = await import("../../open-sse/executors/devin-cli.ts");
type AcpFrame = {
method?: string;
params?: Record<string, unknown>;
};
test("#8406: DevinCliExecutor emits correct ACP wire-format frames and handles agent_message_chunk", async () => {
const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), "devin-acp-test-"));
const framesFile = path.join(tmpDir, "received_frames.json");
const scriptFile = path.join(tmpDir, "mock-devin");
const scriptContent = `#!/usr/bin/env node
const fs = require('fs');
const readline = require('readline');
const frames = [];
const rl = readline.createInterface({ input: process.stdin });
rl.on('line', (line) => {
if (!line.trim()) return;
let msg;
try { msg = JSON.parse(line); } catch (e) { return; }
frames.push(msg);
fs.writeFileSync(${JSON.stringify(framesFile)}, JSON.stringify(frames, null, 2));
if (msg.method === 'initialize') {
process.stdout.write(JSON.stringify({ jsonrpc: '2.0', result: {}, id: msg.id }) + '\\n');
} else if (msg.method === 'session/new') {
process.stdout.write(JSON.stringify({ jsonrpc: '2.0', result: { sessionId: 'sess-8406' }, id: msg.id }) + '\\n');
} else if (msg.method === 'session/prompt') {
const updateMsg = {
jsonrpc: '2.0',
method: 'session/update',
params: {
update: {
sessionUpdate: 'agent_message_chunk',
content: { type: 'text', text: 'Hello ACP 8406' }
}
}
};
process.stdout.write(JSON.stringify(updateMsg) + '\\n');
const resultMsg = {
jsonrpc: '2.0',
result: { stopReason: 'end_turn' },
id: msg.id
};
process.stdout.write(JSON.stringify(resultMsg) + '\\n');
}
});
`;
writeFileSync(scriptFile, scriptContent, { mode: 0o755 });
const oldBin = process.env.CLI_DEVIN_BIN;
process.env.CLI_DEVIN_BIN = scriptFile;
try {
const executor = new mod.DevinCliExecutor();
const res = await executor.execute({
model: "swe-1-6-fast",
body: { messages: [{ role: "user", content: "hi" }] },
stream: true,
credentials: { apiKey: "test-key" },
});
const reader = res.response.body!.getReader();
const decoder = new TextDecoder();
let sseOutput = "";
while (true) {
const { done, value } = await reader.read();
if (done) break;
sseOutput += decoder.decode(value, { stream: true });
}
const receivedFrames: AcpFrame[] = JSON.parse(fs.readFileSync(framesFile, "utf-8"));
const newFrame = receivedFrames.find((f) => f.method === "session/new");
assert.ok(newFrame, "session/new frame must be sent");
assert.ok(
Array.isArray(newFrame.params.mcpServers),
"session/new must include mcpServers array"
);
const promptFrame = receivedFrames.find((f) => f.method === "session/prompt");
assert.ok(promptFrame, "session/prompt frame must be sent");
assert.ok(
Array.isArray(promptFrame.params.prompt),
"session/prompt must name the field prompt"
);
assert.equal(
promptFrame.params.content,
undefined,
"session/prompt must not use content field"
);
assert.match(
sseOutput,
/Hello ACP 8406/,
"SSE output must contain chunk text from agent_message_chunk"
);
assert.match(sseOutput, /data: \[DONE\]/, "SSE output must terminate with [DONE]");
} finally {
if (oldBin !== undefined) {
process.env.CLI_DEVIN_BIN = oldBin;
} else {
delete process.env.CLI_DEVIN_BIN;
}
fs.rmSync(tmpDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
}
});