Files
OmniRoute/tests/unit/cli-npm-install-runtime-allow-scripts-10713.test.ts
Praveen K Palaniswamy 65e81158ab fix(ollama): route models by advertised capability (#11088)
Landed with the design call resolved per the owner's pick — **option 1**: the synced store is now endpoint-agnostic (persistDiscoveredModels and managedModelImport no longer drop non-chat models at write time), and chat selectability moved to read time (auto-pool expansion in autoStrategy applies filterChatSelectableModels; the models-route projection already had its chatOnly filter). Your discovery test now passes end-to-end (3/3): /api/show capabilities persist per connection and image/embedding requests route through the advertising host.

Reconciliation notes: conflicted areas merged onto the current tip (adobe discovery import, requestedModel preflight signature, resolvedProvider fast-path coexists with the synced-route override — explicit resolution wins); carried base-red drains (#10055 memoization, #11071 test variants) dropped as already-landed; the managed-model-import exclusion test was propagated to the new contract (image/video models persist; the read filter still hides them from chat pickers — pinned by a new assertion). Full battery: 205/206 focused (the one red is a confirmed periodic-timer timing flake on the loaded devbox — 20/20 isolated), autoCombo vitest 30/30, combo suites 46/46, gates + typecheck clean.

Thank you @yourspraveen — the capability probe + routing design was right; it just needed the store contract opened up. Fixes #11087.
2026-08-23 11:45:01 -03:00

41 lines
1.7 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import { mkdtempSync, writeFileSync, chmodSync, readFileSync, rmSync, existsSync } from "node:fs";
import { tmpdir } from "node:os";
import { join } from "node:path";
import { npmInstallRuntime } from "../../bin/cli/runtime/nativeDeps.mjs";
test("issue #10713: npmInstallRuntime requests --allow-scripts for its own fully-controlled runtime dependency", () => {
const fakeBinDir = mkdtempSync(join(tmpdir(), "omniroute-fakenpm-"));
const argvLog = join(fakeBinDir, "argv.log");
const npmScript = join(fakeBinDir, "npm");
writeFileSync(npmScript, `#!/usr/bin/env bash\nprintf '%s\\n' "$@" > "${argvLog}"\nexit 0\n`);
chmodSync(npmScript, 0o755);
const originalPath = process.env.PATH;
const originalDataDir = process.env.DATA_DIR;
const fakeDataDir = mkdtempSync(join(tmpdir(), "omniroute-fakedata-"));
try {
process.env.PATH = `${fakeBinDir}:${originalPath}`;
process.env.DATA_DIR = fakeDataDir;
const ok = npmInstallRuntime(["better-sqlite3@12.10.1"], { silent: true });
assert.equal(ok, true, "npm 12 exits 0 even when it silently skipped install scripts");
assert.ok(existsSync(argvLog), "fake npm should have been invoked");
const argv = readFileSync(argvLog, "utf8");
assert.ok(
argv.includes("--allow-scripts=better-sqlite3@12.10.1"),
"npm must be told to allow-scripts for its own runtime dep. argv was:\n" + argv
);
} finally {
process.env.PATH = originalPath;
if (originalDataDir === undefined) delete process.env.DATA_DIR;
else process.env.DATA_DIR = originalDataDir;
rmSync(fakeBinDir, { recursive: true, force: true });
rmSync(fakeDataDir, { recursive: true, force: true });
}
});