mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-14 10:52:17 +03:00
65e81158ab
Landed with the design call resolved per the owner's pick — **option 1**: the synced store is now endpoint-agnostic (persistDiscoveredModels and managedModelImport no longer drop non-chat models at write time), and chat selectability moved to read time (auto-pool expansion in autoStrategy applies filterChatSelectableModels; the models-route projection already had its chatOnly filter). Your discovery test now passes end-to-end (3/3): /api/show capabilities persist per connection and image/embedding requests route through the advertising host. Reconciliation notes: conflicted areas merged onto the current tip (adobe discovery import, requestedModel preflight signature, resolvedProvider fast-path coexists with the synced-route override — explicit resolution wins); carried base-red drains (#10055 memoization, #11071 test variants) dropped as already-landed; the managed-model-import exclusion test was propagated to the new contract (image/video models persist; the read filter still hides them from chat pickers — pinned by a new assertion). Full battery: 205/206 focused (the one red is a confirmed periodic-timer timing flake on the loaded devbox — 20/20 isolated), autoCombo vitest 30/30, combo suites 46/46, gates + typecheck clean. Thank you @yourspraveen — the capability probe + routing design was right; it just needed the store contract opened up. Fixes #11087.
76 lines
2.8 KiB
TypeScript
76 lines
2.8 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
// #5166: Zoo Code sends `max_tokens: -1` to mean "let the server choose". The
|
|
// old clampMaxTokens did `Math.max(1, ...)`, forcing -1 → 1 and truncating
|
|
// output to a single token (the observed `completion_tokens: 1`, `content:null`,
|
|
// `reasoning_content:"The"` symptom). A non-positive limit must be OMITTED so
|
|
// Command Code's upstream applies the model's own native default.
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-cc-maxtokens-5166-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
|
|
const { getExecutor } = await import("../../open-sse/executors/index.ts");
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
|
|
const originalFetch = globalThis.fetch;
|
|
|
|
type FetchCall = { url: string; init: Record<string, unknown>; body?: any };
|
|
|
|
function commandCodeStream(lines: unknown[]) {
|
|
const text = lines.map((line) => `${JSON.stringify(line)}\n`).join("");
|
|
return new Response(text, { status: 200, headers: { "Content-Type": "application/x-ndjson" } });
|
|
}
|
|
|
|
test.afterEach(() => {
|
|
globalThis.fetch = originalFetch;
|
|
});
|
|
|
|
test.after(() => {
|
|
globalThis.fetch = originalFetch;
|
|
core.resetDbInstance();
|
|
});
|
|
|
|
async function captureBody(body: Record<string, unknown>): Promise<FetchCall> {
|
|
const calls: FetchCall[] = [];
|
|
globalThis.fetch = async (url: any, init: any = {}) => {
|
|
calls.push({ url: String(url), init, body: JSON.parse(String(init.body)) });
|
|
return commandCodeStream([{ type: "text-delta", text: "ok" }, { type: "finish" }]);
|
|
};
|
|
await getExecutor("command-code").execute({
|
|
model: "deepseek/deepseek-v4-pro",
|
|
stream: false,
|
|
credentials: { apiKey: "cc_test_key" },
|
|
body: { messages: [{ role: "user", content: "Hi" }], ...body },
|
|
});
|
|
return calls[0];
|
|
}
|
|
|
|
test("Command Code omits max_tokens when the client sends max_tokens: -1 (#5166)", async () => {
|
|
const call = await captureBody({ max_tokens: -1 });
|
|
assert.ok(
|
|
!("max_tokens" in call.body),
|
|
`max_tokens:-1 must be omitted, got max_tokens=${call.body.max_tokens}`
|
|
);
|
|
});
|
|
|
|
test("Command Code omits max_tokens when the client sends max_completion_tokens: -1 (#5166)", async () => {
|
|
const call = await captureBody({ max_completion_tokens: -1 });
|
|
assert.ok(
|
|
!("max_tokens" in call.body),
|
|
`max_completion_tokens:-1 must be omitted, got max_tokens=${call.body.max_tokens}`
|
|
);
|
|
});
|
|
|
|
test("Command Code omits max_tokens when the client sends 0 (#5166)", async () => {
|
|
const call = await captureBody({ max_tokens: 0 });
|
|
assert.ok(!("max_tokens" in call.body), "max_tokens:0 must be omitted");
|
|
});
|
|
|
|
test("Command Code still honors a positive client max_tokens after the #5166 fix", async () => {
|
|
const call = await captureBody({ max_tokens: 2048 });
|
|
assert.equal(call.body.max_tokens, 2048);
|
|
}); |