mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-13 18:32:12 +03:00
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
114 lines
4.2 KiB
TypeScript
114 lines
4.2 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
import http from "node:http";
|
|
|
|
// Isolate the DB to a temp dir BEFORE importing any module that opens it.
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-embed-proxy-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const providersDb = await import("../../src/lib/db/providers.ts");
|
|
const settingsDb = await import("../../src/lib/db/settings.ts");
|
|
const { createEmbeddingResponse } = await import("../../src/lib/embeddings/service.ts");
|
|
const { resolveProxyForRequest } = await import("../../open-sse/utils/proxyFetch.ts");
|
|
|
|
test.after(() => {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
async function withHttpServer(
|
|
handler: http.RequestListener,
|
|
fn: (baseUrl: string) => Promise<void>
|
|
) {
|
|
const server = http.createServer(handler);
|
|
await new Promise<void>((resolve, reject) => {
|
|
server.once("error", reject);
|
|
server.listen(0, "127.0.0.1", () => resolve());
|
|
});
|
|
const address = server.address();
|
|
assert.ok(address && typeof address === "object");
|
|
try {
|
|
await fn(`http://127.0.0.1:${(address as { port: number }).port}`);
|
|
} finally {
|
|
await new Promise<void>((resolve, reject) => {
|
|
server.close((err) => (err ? reject(err) : resolve()));
|
|
});
|
|
}
|
|
}
|
|
|
|
test("embeddings forward the connection-level (key) pinned proxy to the upstream fetch", async () => {
|
|
// T14 Proxy Fast-Fail performs a real TCP reachability check before running
|
|
// the request inside the proxy context, so the "proxy" must be a real,
|
|
// reachable local listener (its actual response body is irrelevant here —
|
|
// the assertion is about which proxy context the upstream fetch observes).
|
|
await withHttpServer(
|
|
(_req, res) => {
|
|
res.writeHead(200);
|
|
res.end("ok");
|
|
},
|
|
async (proxyBaseUrl) => {
|
|
const proxyUrl = new URL(proxyBaseUrl);
|
|
|
|
const connection = await providersDb.createProviderConnection({
|
|
provider: "mistral",
|
|
authType: "apikey",
|
|
name: "Test Mistral Proxy",
|
|
apiKey: "mistral-test-key",
|
|
});
|
|
|
|
// Pin a proxy at the connection ("key") level — the most specific level,
|
|
// exactly like a user would configure per-connection in the dashboard.
|
|
await settingsDb.setProxyForLevel("key", (connection as any).id, {
|
|
type: "http",
|
|
host: proxyUrl.hostname,
|
|
port: Number(proxyUrl.port),
|
|
});
|
|
|
|
let capturedProxySource: string | null = null;
|
|
let capturedProxyUrl: string | null = null;
|
|
|
|
const originalFetch = globalThis.fetch;
|
|
globalThis.fetch = async (input: RequestInfo | URL) => {
|
|
const targetUrl = typeof input === "string" ? input : (input as URL).toString();
|
|
const resolved = resolveProxyForRequest(targetUrl);
|
|
capturedProxySource = resolved.source;
|
|
capturedProxyUrl = resolved.proxyUrl;
|
|
return new Response(
|
|
JSON.stringify({
|
|
data: [{ object: "embedding", embedding: [0.1, 0.2], index: 0 }],
|
|
usage: { prompt_tokens: 3, total_tokens: 3 },
|
|
}),
|
|
{ status: 200, headers: { "content-type": "application/json" } }
|
|
);
|
|
};
|
|
|
|
try {
|
|
const res = await createEmbeddingResponse({
|
|
model: "mistral/mistral-embed",
|
|
input: "hello world",
|
|
});
|
|
assert.equal(res.status, 200, "embedding request should succeed");
|
|
} finally {
|
|
globalThis.fetch = originalFetch;
|
|
}
|
|
|
|
// The upstream fetch must have run inside the AsyncLocalStorage proxy
|
|
// context carrying the connection's pinned proxy — not "direct" (no
|
|
// context) and not the env-var proxy fallback.
|
|
assert.equal(
|
|
capturedProxySource,
|
|
"context",
|
|
`expected the embeddings upstream fetch to run inside a proxy context, got source="${capturedProxySource}"`
|
|
);
|
|
assert.ok(
|
|
capturedProxyUrl && capturedProxyUrl.includes(`${proxyUrl.hostname}:${proxyUrl.port}`),
|
|
`expected the connection's pinned proxy to be forwarded, got "${capturedProxyUrl}"`
|
|
);
|
|
}
|
|
);
|
|
});
|