Files
OmniRoute/tests/unit/plugins-logger.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

47 lines
1.7 KiB
TypeScript

import { describe, it, afterEach } from "node:test";
import assert from "node:assert";
import { existsSync, readFileSync, rmSync } from "fs";
import { join } from "path";
import { tmpdir } from "os";
import { PluginLogger } from "../../src/lib/plugins/logger.ts";
describe("PluginLogger", () => {
const testDir = join(tmpdir(), `plugin-logger-test-${Date.now()}`);
afterEach(() => {
try {
rmSync(testDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
} catch {}
});
it("creates log file and writes JSON entries", () => {
const logger = new PluginLogger("test-plugin", testDir);
logger.info("hello world");
const logPath = join(testDir, "test-plugin", "plugin.log");
assert.ok(existsSync(logPath));
const content = readFileSync(logPath, "utf-8").trim();
const entry = JSON.parse(content);
assert.strictEqual(entry.level, "INFO");
assert.strictEqual(entry.message, "hello world");
assert.ok(entry.timestamp);
});
it("writes error entries", () => {
const logger = new PluginLogger("err-plugin", testDir);
logger.error("bad thing", { code: 500 });
const logPath = join(testDir, "err-plugin", "plugin.log");
const entry = JSON.parse(readFileSync(logPath, "utf-8").trim());
assert.strictEqual(entry.level, "ERROR");
assert.deepStrictEqual(entry.data, { code: 500 });
});
it("appends multiple entries", () => {
const logger = new PluginLogger("multi-plugin", testDir);
logger.info("first");
logger.warn("second");
const logPath = join(testDir, "multi-plugin", "plugin.log");
const lines = readFileSync(logPath, "utf-8").trim().split("\n");
assert.strictEqual(lines.length, 2);
});
});