mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-08-21 22:52:19 +03:00
362c5acbfe
Obrigado — bug real de contrato: o openapi.yaml já documentava patch em /api/combos/{id}, mas a rota nunca exportou PATCH, então um cliente gerado a partir do spec publicado recebia 405 do App Router antes de qualquer handler rodar. Fix mínimo (delegação de 4 linhas para PUT, mesmo padrão já usado em /api/providers/[id] e 25 outras rotas /api/**).
Validação (worktree combinado a partir de origin/release/v3.8.50, 0 conflitos):
- typecheck:core limpo, complexity/cognitive-complexity dentro do baseline
- tests/unit/combo-patch-verb.test.ts — 2/2 passando (falham antes com "comboRoute.PATCH is not a function")
- Suíte combo completa — mesmas 5 falhas herdadas de #9985, confirmadas DRIFT
59 lines
1.9 KiB
TypeScript
59 lines
1.9 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-combo-patch-verb-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const combosDb = await import("../../src/lib/db/combos.ts");
|
|
const comboRoute = await import("../../src/app/api/combos/[id]/route.ts");
|
|
|
|
test.after(() => {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true });
|
|
});
|
|
|
|
function patch(id: string, body: Record<string, unknown>) {
|
|
return new Request(`http://localhost/api/combos/${id}`, {
|
|
method: "PATCH",
|
|
headers: { "content-type": "application/json" },
|
|
body: JSON.stringify(body),
|
|
});
|
|
}
|
|
|
|
test("PATCH changes one field and leaves the rest of the combo alone", async () => {
|
|
const combo = await combosDb.createCombo({
|
|
name: "patchable",
|
|
strategy: "priority",
|
|
models: [{ provider: "openai", model: "gpt-4o" }],
|
|
system_message: "keep me",
|
|
});
|
|
|
|
const response = await comboRoute.PATCH(patch(combo.id, { strategy: "round-robin" }), {
|
|
params: Promise.resolve({ id: combo.id }),
|
|
});
|
|
assert.equal(response.status, 200);
|
|
|
|
const stored = (await combosDb.getComboById(combo.id)) as {
|
|
strategy?: string;
|
|
system_message?: string;
|
|
models?: unknown[];
|
|
};
|
|
assert.equal(stored.strategy, "round-robin");
|
|
assert.equal(stored.system_message, "keep me");
|
|
assert.equal(stored.models?.length, 1);
|
|
});
|
|
|
|
test("PATCH on an unknown combo answers 404, like PUT", async () => {
|
|
const response = await comboRoute.PATCH(patch("does-not-exist", { strategy: "priority" }), {
|
|
params: Promise.resolve({ id: "does-not-exist" }),
|
|
});
|
|
assert.equal(response.status, 404);
|
|
|
|
const body = (await response.json()) as { error?: { code?: string } };
|
|
assert.equal(body.error?.code, "COMBO_007");
|
|
});
|