Files
OmniRoute/tests/integration/memory-engine-status.test.ts
Syed Raheemuddin 26eeead268 fix(memory): honest probe-driven FTS5 keyword status + memory_id rowid sync (#12231)
* fix(memory): honest probe-driven FTS5 keyword status + memory_id rowid sync

The "no such module: fts5" complaint on FTS5-less runtime builds (sql.js/WASM
under a global install) was masked by a hardcoded keyword.available=true in
engineStatus and an unsanitized FTS5 MATCH path. Address root cause:

- engineStatus(): probe runtime via supportsFts5(db) instead of hardcoding
  available=true; keywordEngineStatus() reports the true backend (FTS5 vs
  none) with a reason. Schema, OpenAPI, dashboard chip updated to match.
- store.ts: sync memory_id to the SQLite rowid on insert (+ self-heal legacy
  NULL rows). Migration 023 keys the FTS5 external-content trigger off
  memory_id, but plain INSERT left it NULL so the JOIN returned 0 rows —
  keyword/hybrid search silently returned nothing on FTS5-capable builds.
- retrieval.ts: apply sanitizeFts5Query() to the preview MATCH path.

Tests updated/added across memory-engine-status, memory-retrieve-preview,
memory-schemas-roundtrip, memory-store, and the integration engine-status
test (dropping the hardcoded "always available" assertion). 66 unit tests
pass; lint and typecheck clean.

* fix(memory): sanitize FTS5 queries for memory retrieval

Prevent SQLite FTS5 syntax errors by sanitizing query terms and replacing FTS control operators with double-quoted tokens.
2026-09-01 00:47:16 -03:00

127 lines
4.7 KiB
TypeScript

/**
* Integration tests — GET /api/memory/engine-status
* Tests: 200 + valid MemoryEngineStatusSchema shape, 401 unauth.
*
* NOTE: We use the real engineStatus() here (no mocking) because:
* 1. engineStatus() is a named ESM export that cannot be redefined via mock.method
* 2. engineStatus() returns a valid structure even with no providers/embeddings configured
*/
import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
import { createManagementSessionHeaders } from "../helpers/managementSession.ts";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-engine-status-"));
process.env.DATA_DIR = TEST_DATA_DIR;
process.env.API_KEY_SECRET = "test-secret-engine-status";
const core = await import("../../src/lib/db/core.ts");
const { updateSettings } = await import("@/lib/db/settings");
const localDb = { updateSettings };
// Import route AFTER setting DATA_DIR
const engineStatusRoute = await import("../../src/app/api/memory/engine-status/route.ts");
const { GET } = engineStatusRoute;
// ── Helpers ──
async function resetStorage() {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
}
// ── Test lifecycle ──
test.beforeEach(async () => {
await resetStorage();
await localDb.updateSettings({ requireLogin: false });
});
test.after(async () => {
await resetStorage();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
// ── Tests ──
test("GET /api/memory/engine-status — 200 + valid MemoryEngineStatusSchema shape", async () => {
const headers = await createManagementSessionHeaders();
const req = new Request("http://localhost/api/memory/engine-status", {
method: "GET",
headers: Object.fromEntries(headers.entries()),
});
const res = await GET(req);
assert.strictEqual(res.status, 200);
const body = await res.json();
// Validate shape matches MemoryEngineStatusSchema. Keyword availability is
// probe-driven (runtime FTS5 support), so assert the honest schema contract
// rather than a hardcoded "always available" claim: available is a boolean,
// backend is the FTS5/none enum, and reason is a non-empty string. When the
// probe reports available, the backend must be FTS5.
assert.ok(body.keyword, "should have keyword section");
assert.strictEqual(
typeof body.keyword.available,
"boolean",
"keyword.available should be boolean"
);
assert.ok(
["FTS5", "none"].includes(body.keyword.backend),
"keyword.backend should be FTS5 or none (probe-driven)"
);
assert.ok(typeof body.keyword.reason === "string", "keyword.reason should be a string");
assert.ok(body.keyword.reason.length > 0, "keyword.reason should be non-empty");
if (body.keyword.available) {
assert.strictEqual(
body.keyword.backend,
"FTS5",
"available keyword tier must report FTS5 backend"
);
}
assert.ok(body.embedding, "should have embedding section");
assert.strictEqual(
typeof body.embedding.available,
"boolean",
"embedding.available should be boolean"
);
assert.ok(typeof body.embedding.reason === "string", "embedding.reason should be a string");
assert.ok(body.embedding.cacheStats, "should have cacheStats in embedding");
assert.strictEqual(typeof body.embedding.cacheStats.hits, "number");
assert.strictEqual(typeof body.embedding.cacheStats.misses, "number");
assert.strictEqual(typeof body.embedding.cacheStats.size, "number");
assert.ok(body.vectorStore, "should have vectorStore section");
assert.ok(
["sqlite-vec", "qdrant", "none"].includes(body.vectorStore.backend),
`vectorStore.backend should be valid: ${body.vectorStore.backend}`
);
assert.strictEqual(typeof body.vectorStore.available, "boolean");
assert.strictEqual(typeof body.vectorStore.rowCount, "number");
assert.strictEqual(typeof body.vectorStore.needsReindex, "number");
assert.ok(body.qdrant, "should have qdrant section");
assert.strictEqual(typeof body.qdrant.enabled, "boolean");
assert.ok(body.rerank, "should have rerank section");
assert.strictEqual(typeof body.rerank.enabled, "boolean");
assert.strictEqual(typeof body.rerank.available, "boolean");
});
test("GET /api/memory/engine-status — 401 without auth when requireLogin=true", async () => {
await localDb.updateSettings({ requireLogin: true, password: "hashed-pw" });
const req = new Request("http://localhost/api/memory/engine-status", {
method: "GET",
});
const res = await GET(req);
assert.strictEqual(res.status, 401);
});