Files
OmniRoute/tests/unit/compression/compression-combos-db.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

133 lines
4.3 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-compression-combos-"));
const ORIGINAL_DATA_DIR = process.env.DATA_DIR;
process.env.DATA_DIR = TEST_DATA_DIR;
const core = await import("../../../src/lib/db/core.ts");
const combosDb = await import("../../../src/lib/db/compressionCombos.ts");
async function resetStorage() {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
}
test.beforeEach(async () => {
await resetStorage();
});
test.after(() => {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
if (ORIGINAL_DATA_DIR === undefined) {
delete process.env.DATA_DIR;
} else {
process.env.DATA_DIR = ORIGINAL_DATA_DIR;
}
});
test("creates default compression combo automatically", () => {
const combos = combosDb.listCompressionCombos();
const combo = combos.find((item) => item.id === "default-caveman");
assert.equal(combo?.isDefault, true);
assert.equal(combo?.description, "Default RTK + Caveman compression pipeline");
assert.deepEqual(combo?.pipeline, [
{ engine: "rtk", intensity: "standard" },
{ engine: "caveman", intensity: "full" },
]);
});
test("upgrades the legacy seeded default compression combo pipeline", () => {
const db = core.getDbInstance();
db.prepare(
`
UPDATE compression_combos
SET description = ?, pipeline = ?
WHERE id = ?
`
).run(
"Default Caveman compression pipeline",
JSON.stringify([{ engine: "caveman", intensity: "full" }]),
"default-caveman"
);
const combo = combosDb.getDefaultCompressionCombo();
assert.equal(combo?.id, "default-caveman");
assert.equal(combo?.description, "Default RTK + Caveman compression pipeline");
assert.deepEqual(combo?.pipeline, [
{ engine: "rtk", intensity: "standard" },
{ engine: "caveman", intensity: "full" },
]);
});
test("does not overwrite a customized default compression combo", () => {
const db = core.getDbInstance();
db.prepare(
`
UPDATE compression_combos
SET name = ?, description = ?, pipeline = ?
WHERE id = ?
`
).run(
"Custom Default",
"User changed",
JSON.stringify([{ engine: "caveman", intensity: "lite" }]),
"default-caveman"
);
const combo = combosDb.getDefaultCompressionCombo();
assert.equal(combo?.id, "default-caveman");
assert.equal(combo?.name, "Custom Default");
assert.equal(combo?.description, "User changed");
assert.deepEqual(combo?.pipeline, [{ engine: "caveman", intensity: "lite" }]);
});
test("creates, updates and protects default compression combos", () => {
const combo = combosDb.createCompressionCombo({
name: "RTK first",
pipeline: [{ engine: "rtk", intensity: "standard" }],
languagePacks: ["en", "pt-BR"],
});
assert.equal(combo.name, "RTK first");
assert.equal(combo.pipeline[0].engine, "rtk");
const updated = combosDb.updateCompressionCombo(combo.id, {
description: "Updated",
isDefault: true,
});
assert.equal(updated?.description, "Updated");
assert.equal(combosDb.getDefaultCompressionCombo()?.id, combo.id);
assert.equal(combosDb.deleteCompressionCombo("default-caveman"), true);
assert.equal(combosDb.deleteCompressionCombo(combo.id), false);
});
test("assigns routing combos to compression combos", () => {
const combo = combosDb.createCompressionCombo({
name: "Stacked",
pipeline: [
{ engine: "rtk", intensity: "standard" },
{ engine: "caveman", intensity: "full" },
],
});
assert.equal(combosDb.assignRoutingCombo(combo.id, "routing-a"), true);
assert.equal(combosDb.getCompressionComboForRoutingCombo("routing-a")?.id, combo.id);
assert.deepEqual(
combosDb
.getAssignmentsForCompressionCombo(combo.id)
.map((assignment) => assignment.routingComboId),
["routing-a"]
);
assert.equal(combosDb.updateAssignments(combo.id, ["routing-b", "routing-c"]), true);
assert.equal(combosDb.getCompressionComboForRoutingCombo("routing-a"), null);
assert.equal(combosDb.getCompressionComboForRoutingCombo("routing-b")?.id, combo.id);
});