Files
OmniRoute/bin/cli/provider-test.mjs
Xiangzhe 5dc11561ec fix(cli): real OpenRouter key validation + auth export argument wiring (#11226)
Two defects exposed by #11226 (the 401 "User not found." itself is upstream
OpenRouter's response to a bad key — not an OmniRoute bug):

1. OpenRouter key validation was vacuous. Both the dashboard Check (via
   validateProviderApiKey -> validateOpenAILikeProvider) and 'omniroute
   providers test' (bin/cli/provider-test.mjs) probed /api/v1/models, which is
   PUBLIC and answers 200 to any key — so invalid keys were saved/marked valid
   and only failed on real chat traffic. OpenRouter's authenticated key-info
   endpoint (GET /api/v1/auth/key, 200 = valid / 401 = invalid) is now the
   probe: registered as testKeyModelsUrl on the openrouter registry entry
   (same mechanism as perplexity) and as keyCheckPath in the CLI test configs.
   No other provider's probe changes; error results keep using canned strings,
   never the raw upstream body (Hard Rule #12).

2. 'omniroute auth export' crashed with "cmd.optsWithGlobals is not a
   function". .command("auth export") does not register a two-word command:
   commander parses the bare word 'export' as a required positional argument,
   so the action received (exportArgValue, options, command) while expecting
   (options, command). Registered 'export' as a proper nested subcommand of
   'auth' — the documented CLI surface 'omniroute auth export [--force]
   [--id] [--format] [--out]' is unchanged, and unknown positionals
   (e.g. 'omniroute auth bogus') are now rejected instead of silently running
   the export.

TDD: tests/unit/openrouter-key-validation-auth-endpoint.test.ts (stub mimics
the real OpenRouter: /models public-200, /auth/key 401 'User not found.') and
tests/unit/cli-auth-export-wiring.test.ts (real commander wiring via
createProgram) were RED before the fix and are GREEN after.
2026-08-23 13:07:45 -03:00

192 lines
5.2 KiB
JavaScript

const DEFAULT_TIMEOUT_MS = 15000;
const PROVIDER_TEST_CONFIGS = {
openai: {
format: "openai",
baseUrl: "https://api.openai.com/v1",
model: "gpt-4o-mini",
},
openrouter: {
format: "openai",
baseUrl: "https://openrouter.ai/api/v1",
model: "openai/gpt-4o-mini",
// #11226: /models is public on OpenRouter (200 with any or no key) — probe the
// authenticated key-info endpoint instead so a bad key fails the test here
// instead of on the first real chat request.
keyCheckPath: "/auth/key",
},
groq: {
format: "openai",
baseUrl: "https://api.groq.com/openai/v1",
model: "llama-3.1-8b-instant",
},
mistral: {
format: "openai",
baseUrl: "https://api.mistral.ai/v1",
model: "mistral-small-latest",
},
anthropic: {
format: "anthropic",
baseUrl: "https://api.anthropic.com/v1",
model: "claude-3-5-haiku-latest",
},
google: {
format: "google",
baseUrl: "https://generativelanguage.googleapis.com/v1beta",
model: "gemini-1.5-flash",
},
};
function joinUrl(baseUrl, suffix) {
return `${baseUrl.replace(/\/+$/, "")}/${suffix.replace(/^\/+/, "")}`;
}
function providerEnvName(provider, suffix) {
const normalizedProvider = String(provider || "")
.toUpperCase()
.replace(/[^A-Z0-9]/g, "_");
return `OMNIROUTE_PROVIDER_TEST_${normalizedProvider}_${suffix}`;
}
function resolveTestModel(input, config) {
const providerOverride = process.env[providerEnvName(input.provider, "MODEL")];
return (
input.defaultModel ||
providerOverride ||
process.env.OMNIROUTE_PROVIDER_TEST_MODEL ||
config.model
);
}
function resolveProviderConfig(input) {
const config = PROVIDER_TEST_CONFIGS[input.provider];
if (!config) return null;
return {
...config,
baseUrl: input.baseUrl || config.baseUrl,
model: resolveTestModel(input, config),
};
}
async function fetchWithTimeout(url, init = {}, timeoutMs = DEFAULT_TIMEOUT_MS) {
const controller = new AbortController();
const timeout = setTimeout(() => controller.abort(), timeoutMs);
try {
return await fetch(url, {
...init,
signal: controller.signal,
});
} finally {
clearTimeout(timeout);
}
}
function classifyResponse(response) {
if (response.ok) return { valid: true, error: null, statusCode: response.status };
if (response.status === 401 || response.status === 403) {
return { valid: false, error: "Invalid API key", statusCode: response.status };
}
if (response.status >= 500) {
return {
valid: false,
error: `Provider unavailable (${response.status})`,
statusCode: response.status,
};
}
return { valid: true, error: null, statusCode: response.status };
}
async function testOpenAILikeProvider(input, config) {
const headers = {
Authorization: `Bearer ${input.apiKey}`,
"Content-Type": "application/json",
};
// Providers whose /models endpoint is public (e.g. OpenRouter) declare a
// keyCheckPath pointing at an authenticated endpoint so the probe actually
// exercises the key instead of the public catalog.
const probeRes = await fetchWithTimeout(
joinUrl(config.baseUrl, config.keyCheckPath || "/models"),
{
method: "GET",
headers,
}
);
if (probeRes.ok || probeRes.status === 401 || probeRes.status === 403) {
return classifyResponse(probeRes);
}
const chatRes = await fetchWithTimeout(joinUrl(config.baseUrl, "/chat/completions"), {
method: "POST",
headers,
body: JSON.stringify({
model: config.model,
messages: [{ role: "user", content: "test" }],
max_tokens: 1,
}),
});
return classifyResponse(chatRes);
}
async function testAnthropicProvider(input, config) {
const response = await fetchWithTimeout(joinUrl(config.baseUrl, "/messages"), {
method: "POST",
headers: {
"x-api-key": input.apiKey,
"anthropic-version": "2023-06-01",
"Content-Type": "application/json",
},
body: JSON.stringify({
model: config.model,
messages: [{ role: "user", content: "test" }],
max_tokens: 1,
}),
});
return classifyResponse(response);
}
async function testGoogleProvider(input, config) {
const url = new URL(joinUrl(config.baseUrl, "/models"));
url.searchParams.set("key", input.apiKey);
const response = await fetchWithTimeout(url.toString(), {
method: "GET",
});
return classifyResponse(response);
}
export async function testProviderApiKey(input) {
if (!input.apiKey) {
return { valid: false, error: "Missing API key", statusCode: null };
}
const config = resolveProviderConfig(input);
if (!config) {
return { valid: false, error: "Provider test not supported", unsupported: true };
}
try {
if (config.format === "openai") {
return await testOpenAILikeProvider(input, config);
}
if (config.format === "anthropic") {
return await testAnthropicProvider(input, config);
}
if (config.format === "google") {
return await testGoogleProvider(input, config);
}
return { valid: false, error: "Provider test not supported", unsupported: true };
} catch (error) {
const message = error instanceof Error ? error.message : String(error);
return { valid: false, error: message || "Provider test failed", statusCode: null };
}
}