mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-07-31 12:22:14 +03:00
6c1d597d42
Incident 2026-07-05 on the self-hosted release runner (VM 113): the integration test 'POST /cert: installs trust when cert exists' exercised the REAL install path, wrote a 105-byte fake PEM (FakeMITMCertForTestingOnly) into /usr/local/share/ca-certificates and update-ca-certificates baked the invalid entry into ca-certificates.crt — breaking ALL system TLS on the VM (curl error 77, apt cert failures, and the intermittent gzip-corrupted next-build artifacts that failed 6/9 e2e shards in run 28754447912). Hosted runners are ephemeral, so the same mutation went unnoticed for months. - installCert/uninstallCert: skip the OS dispatch under OMNIROUTE_SKIP_SYSTEM_TRUST=1 — AFTER the input checks, so the #4546 environment-skip contract (missing file throws -> structured skip) and the already-installed/not-installed early returns are preserved. - installTproxyCa/uninstallTproxyCa: same guard, only when no run dep is injected (DI'd tests keep exercising the full command sequence with mocks). - tests/_setup/isolateDataDir.ts sets the env for every node:test process; ci.yml/quality.yml/nightly-release-green.yml set it workflow-wide (e2e runs the real app outside the test setup). TDD: tests/unit/system-trust-test-guard.test.ts (guard exported to every test process; guarded install resolves on a real file without touching the OS; missing-file contract preserved). 82/82 across the affected cert/tproxy/ agent-bridge suites.
44 lines
2.1 KiB
TypeScript
44 lines
2.1 KiB
TypeScript
// Test-only DATA_DIR isolation.
|
|
//
|
|
// Loaded via `node --import ./tests/_setup/isolateDataDir.ts` from the test/mutation
|
|
// invocations (package.json test scripts, stryker.conf.json tap.nodeArgs, the
|
|
// quality.yml TIA step, and the CI test jobs) — NEVER from production. It MUST stay
|
|
// out of open-sse/utils/setupPolyfill.ts, which is also imported by production
|
|
// (bin/omniroute.mjs, proxyFetch.ts, proxyDispatcher.ts) where redirecting DATA_DIR
|
|
// would point the live SQLite DB at a throwaway temp dir.
|
|
//
|
|
// Why: node:test spawns a process per test file and Stryker spawns one per sandbox,
|
|
// but every process resolves DATA_DIR to the SAME default (~/.omniroute) when the env
|
|
// var is unset (see src/lib/dataPaths.ts::resolveDataDir). Concurrent processes then
|
|
// open the SAME on-disk storage.sqlite, causing cross-file state races: SQLite lock
|
|
// contention that hangs `test:unit` under high `--test-concurrency`, and the
|
|
// non-deterministic baseline that forced Stryker to `concurrency: 1`.
|
|
//
|
|
// Giving each process its own DATA_DIR under the OS temp dir removes the shared file,
|
|
// so concurrent test processes never collide. Tests that set DATA_DIR explicitly keep
|
|
// winning — this only fills in an isolated default when none was chosen.
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
if (!process.env.DATA_DIR) {
|
|
const dir = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-test-"));
|
|
process.env.DATA_DIR = dir;
|
|
|
|
// Best-effort cleanup so a long suite run does not leak hundreds of temp DBs.
|
|
process.on("exit", () => {
|
|
try {
|
|
fs.rmSync(dir, { recursive: true, force: true });
|
|
} catch {
|
|
// ignore — the OS reaps its temp dir eventually.
|
|
}
|
|
});
|
|
}
|
|
|
|
// System-trust guard: the suite must NEVER mutate the OS trust store. On a
|
|
// persistent self-hosted runner the cert-flow integration test installed a fake
|
|
// 105-byte PEM into /usr/local/share/ca-certificates and update-ca-certificates
|
|
// baked it into the bundle, breaking ALL system TLS on the VM (2026-07-05).
|
|
// installCert/uninstallCert/installTproxyCa/uninstallTproxyCa no-op under this.
|
|
process.env.OMNIROUTE_SKIP_SYSTEM_TRUST = "1";
|