Files
OmniRoute/tests/integration/memory-engine-status.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

106 lines
3.9 KiB
TypeScript

/**
* Integration tests — GET /api/memory/engine-status
* Tests: 200 + valid MemoryEngineStatusSchema shape, 401 unauth.
*
* NOTE: We use the real engineStatus() here (no mocking) because:
* 1. engineStatus() is a named ESM export that cannot be redefined via mock.method
* 2. engineStatus() returns a valid structure even with no providers/embeddings configured
*/
import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
import { createManagementSessionHeaders } from "../helpers/managementSession.ts";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-engine-status-"));
process.env.DATA_DIR = TEST_DATA_DIR;
process.env.API_KEY_SECRET = "test-secret-engine-status";
const core = await import("../../src/lib/db/core.ts");
const localDb = await import("../../src/lib/localDb.ts");
// Import route AFTER setting DATA_DIR
const engineStatusRoute = await import("../../src/app/api/memory/engine-status/route.ts");
const { GET } = engineStatusRoute;
// ── Helpers ──
async function resetStorage() {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
}
// ── Test lifecycle ──
test.beforeEach(async () => {
await resetStorage();
await localDb.updateSettings({ requireLogin: false });
});
test.after(async () => {
await resetStorage();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
// ── Tests ──
test("GET /api/memory/engine-status — 200 + valid MemoryEngineStatusSchema shape", async () => {
const headers = await createManagementSessionHeaders();
const req = new Request("http://localhost/api/memory/engine-status", {
method: "GET",
headers: Object.fromEntries(headers.entries()),
});
const res = await GET(req);
assert.strictEqual(res.status, 200);
const body = await res.json();
// Validate shape matches MemoryEngineStatusSchema
assert.ok(body.keyword, "should have keyword section");
assert.strictEqual(body.keyword.available, true, "keyword.available should be true");
assert.strictEqual(body.keyword.backend, "FTS5", "keyword.backend should be FTS5");
assert.ok(body.embedding, "should have embedding section");
assert.strictEqual(
typeof body.embedding.available,
"boolean",
"embedding.available should be boolean"
);
assert.ok(typeof body.embedding.reason === "string", "embedding.reason should be a string");
assert.ok(body.embedding.cacheStats, "should have cacheStats in embedding");
assert.strictEqual(typeof body.embedding.cacheStats.hits, "number");
assert.strictEqual(typeof body.embedding.cacheStats.misses, "number");
assert.strictEqual(typeof body.embedding.cacheStats.size, "number");
assert.ok(body.vectorStore, "should have vectorStore section");
assert.ok(
["sqlite-vec", "qdrant", "none"].includes(body.vectorStore.backend),
`vectorStore.backend should be valid: ${body.vectorStore.backend}`
);
assert.strictEqual(typeof body.vectorStore.available, "boolean");
assert.strictEqual(typeof body.vectorStore.rowCount, "number");
assert.strictEqual(typeof body.vectorStore.needsReindex, "number");
assert.ok(body.qdrant, "should have qdrant section");
assert.strictEqual(typeof body.qdrant.enabled, "boolean");
assert.ok(body.rerank, "should have rerank section");
assert.strictEqual(typeof body.rerank.enabled, "boolean");
assert.strictEqual(typeof body.rerank.available, "boolean");
});
test("GET /api/memory/engine-status — 401 without auth when requireLogin=true", async () => {
await localDb.updateSettings({ requireLogin: true, password: "hashed-pw" });
const req = new Request("http://localhost/api/memory/engine-status", {
method: "GET",
});
const res = await GET(req);
assert.strictEqual(res.status, 401);
});