mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-13 18:32:12 +03:00
65e81158ab
Landed with the design call resolved per the owner's pick — **option 1**: the synced store is now endpoint-agnostic (persistDiscoveredModels and managedModelImport no longer drop non-chat models at write time), and chat selectability moved to read time (auto-pool expansion in autoStrategy applies filterChatSelectableModels; the models-route projection already had its chatOnly filter). Your discovery test now passes end-to-end (3/3): /api/show capabilities persist per connection and image/embedding requests route through the advertising host. Reconciliation notes: conflicted areas merged onto the current tip (adobe discovery import, requestedModel preflight signature, resolvedProvider fast-path coexists with the synced-route override — explicit resolution wins); carried base-red drains (#10055 memoization, #11071 test variants) dropped as already-landed; the managed-model-import exclusion test was propagated to the new contract (image/video models persist; the read filter still hides them from chat pickers — pinned by a new assertion). Full battery: 205/206 focused (the one red is a confirmed periodic-timer timing flake on the loaded devbox — 20/20 isolated), autoCombo vitest 30/30, combo suites 46/46, gates + typecheck clean. Thank you @yourspraveen — the capability probe + routing design was right; it just needed the store contract opened up. Fixes #11087.
31 lines
1.3 KiB
TypeScript
31 lines
1.3 KiB
TypeScript
import { test } from "node:test";
|
|
import assert from "node:assert/strict";
|
|
|
|
import { resolveCodexSpawn } from "../../bin/cli/commands/launch-codex.mjs";
|
|
|
|
// Regression guard for #6312: on Windows the `codex` binary is an npm `.cmd`
|
|
// shim that `spawn` cannot resolve without a shell (bare "codex" → ENOENT).
|
|
// Since #9454 resolveCodexSpawn is async and probes PATH for a native .exe
|
|
// first; the .cmd+shell fallback below is the original #6312 contract (the
|
|
// .exe-preferred path is covered in cli/launch-claude-exe-windows-9454.test.ts).
|
|
test("resolveCodexSpawn: win32 spawns codex.cmd through a shell when no .exe is found", async () => {
|
|
const { command, shell } = await resolveCodexSpawn("win32", { probe: async () => null });
|
|
assert.equal(command, "codex.cmd");
|
|
assert.equal(shell, true);
|
|
});
|
|
|
|
test("resolveCodexSpawn: non-Windows platforms spawn the bare binary without a shell", async () => {
|
|
for (const platform of ["linux", "darwin", "freebsd"]) {
|
|
let probeCalls = 0;
|
|
const { command, shell } = await resolveCodexSpawn(platform, {
|
|
probe: async () => {
|
|
probeCalls++;
|
|
return null;
|
|
},
|
|
});
|
|
assert.equal(command, "codex", `${platform} command`);
|
|
assert.equal(shell, undefined, `${platform} shell`);
|
|
assert.equal(probeCalls, 0, `${platform} must not probe PATH off Windows`);
|
|
}
|
|
});
|