mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-13 18:32:12 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
56 lines
2.3 KiB
TypeScript
56 lines
2.3 KiB
TypeScript
/**
|
|
* A synced model delete removes the current discovery row only. If the upstream
|
|
* provider advertises that model again, the next sync restores it. Persistent
|
|
* exclusion is represented by isHidden, not a separate deletion tombstone.
|
|
*/
|
|
import test, { before, after } from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
import fs from "node:fs";
|
|
|
|
// Hermetic DB: this test mutates the syncedAvailableModels key_value namespace.
|
|
const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-test-synced-del-"));
|
|
process.env.DATA_DIR = tmpDir;
|
|
|
|
const { replaceSyncedAvailableModelsForConnection, getSyncedAvailableModels } =
|
|
await import("../../src/lib/localDb.ts");
|
|
const { resetDbInstance } = await import("../../src/lib/db/core.ts");
|
|
|
|
before(() => {
|
|
resetDbInstance();
|
|
});
|
|
|
|
after(() => {
|
|
resetDbInstance();
|
|
fs.rmSync(tmpDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
test("a deleted synced model is restored when upstream advertises it again", async () => {
|
|
const provider = "llama-cpp";
|
|
const connectionId = "conn-3199";
|
|
|
|
// Initial sync brings in two models.
|
|
await replaceSyncedAvailableModelsForConnection(provider, connectionId, [
|
|
{ id: "model-keep", name: "Keep" },
|
|
{ id: "model-del", name: "Delete me" },
|
|
]);
|
|
let synced = (await getSyncedAvailableModels(provider)).map((m) => m.id);
|
|
assert.ok(synced.includes("model-del"), "both models present after first sync");
|
|
|
|
const { removeSyncedAvailableModel } = await import("../../src/lib/localDb.ts");
|
|
assert.equal(await removeSyncedAvailableModel(provider, "model-del"), true);
|
|
synced = (await getSyncedAvailableModels(provider)).map((m) => m.id);
|
|
assert.ok(!synced.includes("model-del"), "delete removes the current synced row");
|
|
|
|
// Auto-fetch re-imports the SAME upstream list (still advertising model-del).
|
|
await replaceSyncedAvailableModelsForConnection(provider, connectionId, [
|
|
{ id: "model-keep", name: "Keep" },
|
|
{ id: "model-del", name: "Delete me" },
|
|
]);
|
|
|
|
synced = (await getSyncedAvailableModels(provider)).map((m) => m.id);
|
|
assert.ok(synced.includes("model-keep"), "unrelated model stays");
|
|
assert.ok(synced.includes("model-del"), "upstream re-sync restores the deleted model");
|
|
});
|