Files
OmniRoute/tests/unit/tls-client-node-docker-binary-7802.test.ts
Diego Rodrigues de Sa e Souza 7a0e982dff fix(docker): repair tls-client-node native binary after --ignore-scripts (#7802) (#7829)
The Dockerfile builder stage installs with --ignore-scripts, which blocks
tls-client-node's own postinstall.js (the script that fetches the native
.so/.dylib/.dll from bogdanfinn/tls-client GitHub Releases). Unlike
better-sqlite3 (explicit node-gyp rebuild) and wreq-js (fixWreqJsBinary()),
tls-client-node had zero compensating step, so node_modules/tls-client-node/bin/
was always empty in the official Docker image and every chatgpt-web/claude-web/
grok-web/lmarena/perplexity-web request threw TlsClientUnavailableError.

- Dockerfile: explicitly invoke tls-client-node's postinstall.js after
  npm ci --ignore-scripts (same spot as the better-sqlite3 rebuild), and
  fail the build loudly if bin/ ends up empty instead of shipping a
  silently-broken image.
- scripts/build/fixTlsClientNodeBinary.mjs (new): mirrors fixWreqJsBinary()
  to copy the root bin/ into the standalone dist/node_modules bundle, and
  retries the download with backoff when bin/ is empty (degrades gracefully
  against a transient GitHub API rate-limit instead of failing on the first
  attempt), warning with a clear manual-fix pointer if every retry still
  comes up empty.
- Registered the new script in package.json files + pack-artifact-policy.ts
  allowlists so it ships in the npm tarball.

Regression test: tests/unit/tls-client-node-docker-binary-7802.test.ts
(RED against current release/v3.8.49 tip, GREEN after the fix). New unit
coverage for the retry/copy/warn behavior in
tests/unit/fix-tls-client-node-binary-7802.test.ts.

Closes #7802
2026-07-20 02:03:31 -03:00

46 lines
1.7 KiB
TypeScript

import { test } from "node:test";
import assert from "node:assert/strict";
import { readFileSync } from "node:fs";
import { fileURLToPath } from "node:url";
import { dirname, join } from "node:path";
const __dirname = dirname(fileURLToPath(import.meta.url));
const ROOT = join(__dirname, "..", "..");
test("Dockerfile's --ignore-scripts npm ci is compensated for tls-client-node's native binary, same as it is for wreq-js and better-sqlite3 (#7802)", () => {
const dockerfile = readFileSync(join(ROOT, "Dockerfile"), "utf8");
const postinstall = readFileSync(join(ROOT, "scripts/build/postinstall.mjs"), "utf8");
assert.match(
dockerfile,
/npm ci --no-audit --no-fund --legacy-peer-deps --ignore-scripts/,
"expected the builder stage to install with --ignore-scripts (precondition of #7802)"
);
assert.match(
dockerfile,
/better-sqlite3[\s\S]*node-gyp\.js rebuild/,
"expected an explicit better-sqlite3 rebuild step after --ignore-scripts"
);
assert.match(
postinstall,
/fixWreqJsBinary/,
"expected postinstall.mjs to repair wreq-js's native binary"
);
const dockerfileHandlesIt = /tls-client-node[\s\S]{0,200}(postinstall|rebuild|download)/i.test(
dockerfile
);
const postinstallHandlesIt = /tls-client-node/i.test(postinstall);
assert.ok(
dockerfileHandlesIt || postinstallHandlesIt,
"tls-client-node has no --ignore-scripts compensation in Dockerfile or " +
"scripts/build/postinstall.mjs (unlike better-sqlite3 and wreq-js) — " +
"node_modules/tls-client-node/bin/ is never populated in the official " +
"Docker image, so chatgpt-web/claude-web/grok-web/lmarena/perplexity-web " +
"all fail with TlsClientUnavailableError at first request (#7802)"
);
});