mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-08-06 15:22:12 +03:00
* feat(discovery): Phase 2 reporter — discoveryResults DB module + service wiring
Adds src/lib/db/discoveryResults.ts (CRUD over the discovery_results table
from migration 074) and wires the opt-in discovery service to persist and read
findings through it: persistDiscoveryResult / getDiscoveryResults /
getDiscoveryResultById / markVerified / deleteDiscoveryResult, with
(provider, method, endpoint) upsert de-duplication. Re-exported from localDb.
The service stays opt-in / default-off. The /api/discovery/* routes and the
dashboard UI tab are intentionally deferred to Phase 2b — they need the
local-only enforcement model (Hard Rules #15/#17 territory) decided first.
TDD: tests/unit/db/discovery-results.test.ts (8 cases, DB + service delegation),
isolated DATA_DIR with resetDbInstance cleanup.
* feat(discovery): Phase 2b — /api/discovery/* routes (strict loopback-only)
Adds the discovery HTTP surface on top of the reporter DB module:
GET /api/discovery/results list findings (optional ?providerId)
GET /api/discovery/results/:id one finding (404 if absent)
DELETE /api/discovery/results/:id delete a finding
POST /api/discovery/scan scan a provider + persist findings
POST /api/discovery/verify/:id mark a finding verified
Authorization: strict loopback-only. "/api/discovery/" is added to
LOCAL_ONLY_API_PREFIXES so the central authz pipeline (proxy.ts →
runAuthzPipeline → managementPolicy) rejects non-loopback callers with a 403
LOCAL_ONLY before any handler runs. It is deliberately NOT in
LOCAL_ONLY_MANAGE_SCOPE_BYPASS_PREFIXES — no remote manage-scope bypass —
because POST /scan issues outbound probes to provider endpoints (SSRF-adjacent)
and must never be tunnel-reachable. Handlers also call requireManagementAuth
(defense in depth) and return sanitized errors via createErrorResponse.
Tests:
- tests/unit/authz/discovery-routes-local-only.test.ts (8) — security guard:
isLocalOnlyPath true + not manage-scope-bypassable for all four paths.
- tests/unit/api/discovery-routes.test.ts (6) — handler integration over an
isolated DATA_DIR: list/filter, by-id 200/404/400, scan persist + 400 on
empty/malformed body, verify 200/404, delete 200/404, no stack-trace leak.
* feat(discovery): Phase 2c — dashboard UI tab (Tools → Discovery)
Adds the /dashboard/discovery page (DiscoveryPageClient) that consumes the
Phase 2b /api/discovery/* routes: scan a provider, list findings, verify or
delete them. Registered in the sidebar under the Tools group (icon
travel_explore) and given a "discovery" i18n namespace + sidebar keys in
en.json (other locales fall back to en via next-intl until synced — the
locale files are in a pre-existing coverage deficit unrelated to this change).
Registers the UI test path in vitest.config.ts (advisory ui suite).
Tests: src/app/(dashboard)/dashboard/discovery/__tests__/DiscoveryPageClient.test.tsx
(3 cases: loads+renders results, empty state, fetches /api/discovery/results on
mount; stable useTranslations mock to avoid the fetch-loop). NOTE: the ui vitest
suite cannot run in this workspace — @testing-library/dom (a @testing-library/
react peer dep) is absent from node_modules, which fails ALL existing ui tests
equally; the test runs in CI. Component verified locally via typecheck + lint.
* test(discovery): register discovery-routes-local-only in stryker tap.testFiles
The mutation-test-coverage gate (--strict) flags any unit test covering a
mutated module that isn't listed in stryker.conf.json tap.testFiles. This PR's
tests/unit/authz/discovery-routes-local-only.test.ts covers src/server/authz/
routeGuard.ts (a mutated module, which this PR edits by adding the
/api/discovery/ local-only prefix), so it must be registered for its mutant
kills to count. No behavior change.
* refactor(discovery): split DiscoveryPageClient to satisfy max-lines-per-function
The complexity ratchet (max-lines-per-function: 80) flagged the single
184-line DiscoveryPageClient function (+1 over baseline). Extract the data
layer into two hooks (useDiscoveryResults for list/loading/feedback,
useDiscoveryActions for scan/verify/delete), a shared callApi helper, and two
presentational sub-components (DiscoveryScanForm, DiscoveryResultCard). Every
function is now under the 80-line ceiling; complexity gate back to baseline
1995. No behavior change — same exported component, same endpoints, same props.
* test(sidebar): include discovery in omni-proxy item-order snapshot
Adding the Discovery item to the Tools group (this PR's sidebar entry) extends
the ordered omni-proxy section list. Update the exact-match deepEqual snapshot
in sidebar-visibility.test.ts to include "discovery" in its position (after
traffic-inspector). The assertion stays exact — this reflects the intentional
new item, it does not weaken the check.
* docs(changelog): restore release bullets eaten by merge auto-resolve; re-add discovery bullet additively
* chore(quality): bump testFrozen for translator-openai-responses-req.test.ts (1097 -> 1172)
Base-red inherited from #5933, which grew the test file to 1171 lines
(Hard Rule #18 regression tests) without adjusting the frozen cap. The
release tip itself fails check:file-size; this unblocks every PR into
release/v3.8.44. File untouched by this PR.
* chore(quality): restore stryker tap.testFiles entries eaten by merge auto-resolve
The merge of origin/release/v3.8.44 silently dropped the 3 entries added
on the release side (#5903, clinepass, #5923). Took the release version
verbatim and re-added only this PR's entry (discovery-routes-local-only)
in alphabetical order. check:mutation-test-coverage green locally.
* chore(quality): reconcile inherited v3.8.44 merge-burst drift + include discovery in tools-group order test
- complexity 1995->2003 and cognitive 856->859: both measure IDENTICAL on
the pristine release tip (3a3d618fe) and this PR's merged HEAD — the PR
is complexity-net-zero; drift is from the 2026-07-02 merge burst
(notes added to both baselines, same family as prior reconciliations).
- sidebar-tools-group.test.ts: append 'discovery' to the expected
TOOLS_GROUP order — the intentional new sidebar item this PR adds
(same expected-value update already made in sidebar-visibility.test.ts).
181 lines
6.0 KiB
TypeScript
181 lines
6.0 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import { readFile } from "node:fs/promises";
|
|
import { join } from "node:path";
|
|
|
|
const sidebarVisibility = await import("../../src/shared/constants/sidebarVisibility.ts");
|
|
const repoRoot = join(import.meta.dirname, "../..");
|
|
|
|
function sectionItems(sectionId: string) {
|
|
const section = sidebarVisibility.SIDEBAR_SECTIONS.find(
|
|
(candidate) => candidate.id === sectionId
|
|
);
|
|
assert.ok(section, `expected ${sectionId} sidebar section to exist`);
|
|
return sidebarVisibility.getSectionItems(section);
|
|
}
|
|
|
|
test("system sidebar items: monitoring has activity at top then logs/audit/system groups", () => {
|
|
const items = sectionItems("monitoring");
|
|
assert.deepEqual(
|
|
items.map((item) => item.id),
|
|
[
|
|
"activity",
|
|
"logs",
|
|
"logs-proxy",
|
|
"logs-console",
|
|
"audit",
|
|
"audit-mcp",
|
|
"audit-a2a",
|
|
"health",
|
|
"runtime",
|
|
]
|
|
);
|
|
});
|
|
|
|
test("primary sidebar items place limits after cache", () => {
|
|
const items = sectionItems("omni-proxy");
|
|
assert.deepEqual(
|
|
items.map((item) => item.id),
|
|
[
|
|
"endpoints",
|
|
"api-manager",
|
|
"providers",
|
|
"embedded-services",
|
|
"combos",
|
|
"combos-live",
|
|
"quota",
|
|
"costs-quota-share",
|
|
"context-settings",
|
|
"context-combos",
|
|
"context-caveman",
|
|
"context-rtk",
|
|
"context-headroom",
|
|
"context-session-dedup",
|
|
"context-ccr",
|
|
"context-llmlingua",
|
|
"context-lite",
|
|
"context-aggressive",
|
|
"context-ultra",
|
|
"compression-studio",
|
|
"cli-code",
|
|
"cli-agents",
|
|
"acp-agents",
|
|
"cloud-agents",
|
|
"agent-bridge",
|
|
"traffic-inspector",
|
|
"discovery",
|
|
"api-endpoints",
|
|
"webhooks",
|
|
"proxy",
|
|
]
|
|
);
|
|
});
|
|
|
|
test("context sidebar section sits between primary and cli", () => {
|
|
const sectionIds = sidebarVisibility.SIDEBAR_SECTIONS.map((section) => section.id);
|
|
assert.deepEqual(sectionIds.slice(0, 4), ["home", "omni-proxy", "analytics", "costs"]);
|
|
|
|
const items = sectionItems("omni-proxy");
|
|
assert.deepEqual(
|
|
items
|
|
.filter((item) => item.id.startsWith("context-"))
|
|
.map((item) => ({ id: item.id, href: item.href })),
|
|
[
|
|
{ id: "context-settings", href: "/dashboard/context/settings" },
|
|
{ id: "context-combos", href: "/dashboard/context/combos" },
|
|
{ id: "context-caveman", href: "/dashboard/context/caveman" },
|
|
{ id: "context-rtk", href: "/dashboard/context/rtk" },
|
|
{ id: "context-headroom", href: "/dashboard/context/headroom" },
|
|
{ id: "context-session-dedup", href: "/dashboard/context/session-dedup" },
|
|
{ id: "context-ccr", href: "/dashboard/context/ccr" },
|
|
{ id: "context-llmlingua", href: "/dashboard/context/llmlingua" },
|
|
{ id: "context-lite", href: "/dashboard/context/lite" },
|
|
{ id: "context-aggressive", href: "/dashboard/context/aggressive" },
|
|
{ id: "context-ultra", href: "/dashboard/context/ultra" },
|
|
]
|
|
);
|
|
});
|
|
|
|
test("sidebar visibility drops stale entries from saved settings", () => {
|
|
const allSidebarItemIds = sidebarVisibility.SIDEBAR_SECTIONS.flatMap((section) =>
|
|
sidebarVisibility.getSectionItems(section).map((item) => item.id)
|
|
);
|
|
|
|
assert.equal(
|
|
(sidebarVisibility.HIDEABLE_SIDEBAR_ITEM_IDS as readonly string[]).includes("auto-combo"),
|
|
false
|
|
);
|
|
assert.equal((allSidebarItemIds as string[]).includes("auto-combo"), false);
|
|
assert.equal(
|
|
(sidebarVisibility.HIDEABLE_SIDEBAR_ITEM_IDS as readonly string[]).includes("settings"),
|
|
false
|
|
);
|
|
assert.equal((allSidebarItemIds as string[]).includes("settings"), false);
|
|
assert.deepEqual(sidebarVisibility.normalizeHiddenSidebarItems(["auto-combo" as any, "logs"]), [
|
|
"logs",
|
|
]);
|
|
});
|
|
|
|
test("help sidebar exposes changelog after docs and issues", () => {
|
|
const items = sectionItems("help");
|
|
assert.deepEqual(
|
|
items.map((item) => ({
|
|
id: item.id,
|
|
href: item.href,
|
|
i18nKey: item.i18nKey,
|
|
})),
|
|
[
|
|
{ id: "docs", href: "/docs", i18nKey: "docs" },
|
|
{
|
|
id: "issues",
|
|
href: "https://github.com/diegosouzapw/OmniRoute/issues",
|
|
i18nKey: "issues",
|
|
},
|
|
{ id: "changelog", href: "/dashboard/changelog", i18nKey: "changelog" },
|
|
]
|
|
);
|
|
assert.equal(sidebarVisibility.HIDEABLE_SIDEBAR_ITEM_IDS.includes("changelog"), true);
|
|
});
|
|
|
|
test("plugins (marketplace) has a discoverable sidebar entry (#3656 follow-up)", async () => {
|
|
const items = sectionItems("agentic-features");
|
|
const plugins = items.find((item) => item.id === "plugins");
|
|
assert.ok(plugins, "expected a plugins item in the agentic-features section");
|
|
assert.equal(plugins.href, "/dashboard/plugins");
|
|
assert.equal(sidebarVisibility.HIDEABLE_SIDEBAR_ITEM_IDS.includes("plugins"), true);
|
|
|
|
// It must be a real page (plugin manager + marketplace tab), not a legacy redirect stub.
|
|
const pluginsPage = await readFile(
|
|
join(repoRoot, "src/app/(dashboard)/dashboard/plugins/page.tsx"),
|
|
"utf8"
|
|
);
|
|
assert.doesNotMatch(pluginsPage, /^\s*redirect\(/m);
|
|
assert.match(pluginsPage, /marketplace/i);
|
|
});
|
|
|
|
test("legacy dashboard routes redirect to their consolidated surfaces", async () => {
|
|
const autoComboPage = await readFile(
|
|
join(repoRoot, "src/app/(dashboard)/dashboard/auto-combo/page.tsx"),
|
|
"utf8"
|
|
);
|
|
const usagePage = await readFile(
|
|
join(repoRoot, "src/app/(dashboard)/dashboard/usage/page.tsx"),
|
|
"utf8"
|
|
);
|
|
const settingsPage = await readFile(
|
|
join(repoRoot, "src/app/(dashboard)/dashboard/settings/page.tsx"),
|
|
"utf8"
|
|
);
|
|
|
|
assert.match(autoComboPage, /redirect\("\/dashboard\/combos\?filter=intelligent"\)/);
|
|
assert.match(usagePage, /redirect\("\/dashboard\/logs"\)/);
|
|
assert.match(settingsPage, /redirect\(resolveSettingsRoute\(tab\)\)/);
|
|
assert.match(settingsPage, /\/dashboard\/settings\/general/);
|
|
|
|
const compressionPage = await readFile(
|
|
join(repoRoot, "src/app/(dashboard)/dashboard/compression/page.tsx"),
|
|
"utf8"
|
|
);
|
|
assert.match(compressionPage, /redirect\("\/dashboard\/context\/caveman"\)/);
|
|
});
|