mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-20 13:52:28 +03:00
7a938fe39f
Merged as part of the 39-PR owner batch of 2026-09-11, validated as a unit. Boarded into one consolidated worktree cut from `release/v3.8.51` with the other 38 — zero conflicts between them. - ESLint over every changed file: no errors (the only finding was one suppression entry the batch emptied, pruned on #13243) - `typecheck:core` clean; `check:dashboard-typecheck` OK (206 pre-existing, within baseline); `check:changelog-integrity` OK - complexity 2821 / baseline 3218 and cognitive-complexity 1272 / baseline 1437 — both under baseline - 256 assertions green: 246 under node:test and 10 under vitest, which is where `tests/unit/**/*.test.tsx` actually runs - `check-file-size`: `chatCore.ts` rebaselined 6144 → 6146 for #13278 and #13276, annotated and landed on #13243 ⚠️ base-red inherited: #12732 — the provider count (356 in the docs vs the 358 the modules define) and `open-sse/utils/stream.ts` at 3115 > frozen 3098 both reproduce on the pure tip with zero contribution from this batch.
35 lines
1.4 KiB
TypeScript
35 lines
1.4 KiB
TypeScript
/**
|
|
* #12398 — decides whether a Claude-format stream must be aborted with an
|
|
* upstream error at flush time because the client got no usable content.
|
|
*
|
|
* Covers two shapes:
|
|
* - "partial lifecycle": message_start (and optionally message_delta /
|
|
* message_stop) arrived but no content block ever did — this was already
|
|
* correctly handled before #12398 and is preserved here unchanged.
|
|
* - "truly empty": the upstream connection closed having sent literally
|
|
* zero bytes (HTTP 200, not even a message_start). The lifecycle flags
|
|
* above can never catch this shape since none of them are ever set — the
|
|
* caller must additionally know whether ANY upstream chunk ever arrived.
|
|
*
|
|
* Callers must additionally require a Claude-format client (this function
|
|
* does not take that flag — both call sites in stream.ts only ever reach
|
|
* here already scoped to a Claude-format response).
|
|
*/
|
|
type ClaudeEmptyLifecycleLike = {
|
|
hasError: boolean;
|
|
hasContentBlock: boolean;
|
|
hasMessageStart: boolean;
|
|
hasMessageDelta: boolean;
|
|
hasMessageStop: boolean;
|
|
};
|
|
|
|
export function shouldAbortEmptyClaudeStream(
|
|
lifecycle: ClaudeEmptyLifecycleLike,
|
|
sawAnyUpstreamPayload: boolean
|
|
): boolean {
|
|
if (lifecycle.hasError || lifecycle.hasContentBlock) return false;
|
|
const hasPartialLifecycle =
|
|
lifecycle.hasMessageStart || lifecycle.hasMessageDelta || lifecycle.hasMessageStop;
|
|
return hasPartialLifecycle || !sawAnyUpstreamPayload;
|
|
}
|