mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-14 10:52:17 +03:00
37ecab3659
Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.
One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.
Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.
66 lines
2.4 KiB
TypeScript
66 lines
2.4 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
import { fileURLToPath } from "node:url";
|
|
|
|
import { resolveDataDir as cliResolveDataDir } from "../../bin/cli/data-dir.mjs";
|
|
import { resolveDataDir as runtimeResolveDataDir } from "../../src/lib/dataPaths.ts";
|
|
|
|
const REPO_ROOT = path.join(path.dirname(fileURLToPath(import.meta.url)), "..", "..");
|
|
const BIN = path.join(REPO_ROOT, "bin", "omniroute.mjs");
|
|
|
|
async function withTempEnv(
|
|
fn: (paths: { root: string; home: string; cwd: string }) => void | Promise<void>
|
|
) {
|
|
const originalEnv = { ...process.env };
|
|
const originalCwd = process.cwd();
|
|
const root = fs.mkdtempSync(path.join(os.tmpdir(), "omni-cli-env-"));
|
|
const home = path.join(root, "home");
|
|
const cwd = path.join(root, "cwd");
|
|
fs.mkdirSync(home, { recursive: true });
|
|
fs.mkdirSync(cwd, { recursive: true });
|
|
|
|
delete process.env.DATA_DIR;
|
|
delete process.env.XDG_CONFIG_HOME;
|
|
delete process.env.APPDATA;
|
|
process.env.HOME = home;
|
|
process.chdir(cwd);
|
|
|
|
try {
|
|
await fn({ root, home, cwd });
|
|
} finally {
|
|
process.chdir(originalCwd);
|
|
for (const key of Object.keys(process.env)) {
|
|
if (!(key in originalEnv)) delete process.env[key];
|
|
}
|
|
for (const [key, value] of Object.entries(originalEnv)) {
|
|
process.env[key] = value;
|
|
}
|
|
fs.rmSync(root, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
}
|
|
}
|
|
|
|
test("CLI data dir preserves existing legacy ~/.omniroute before XDG", async () => {
|
|
await withTempEnv(({ home, root }) => {
|
|
const legacyDir = path.join(home, ".omniroute");
|
|
fs.mkdirSync(legacyDir, { recursive: true });
|
|
process.env.XDG_CONFIG_HOME = path.join(root, "xdg");
|
|
|
|
assert.equal(cliResolveDataDir(), legacyDir);
|
|
assert.equal(cliResolveDataDir(), runtimeResolveDataDir());
|
|
});
|
|
});
|
|
|
|
test("CLI env loader scans all env paths while preserving first value wins", () => {
|
|
const source = fs.readFileSync(BIN, "utf8");
|
|
const loaderStart = source.indexOf("function loadEnvFile()");
|
|
const loaderEnd = source.indexOf("loadEnvFile();", loaderStart);
|
|
const loaderSource = source.slice(loaderStart, loaderEnd);
|
|
|
|
assert.match(loaderSource, /for \(const envPath of envPaths\)/);
|
|
assert.match(loaderSource, /if \(process\.env\[key\] === undefined\)/);
|
|
assert.doesNotMatch(loaderSource, /Loaded env from \$\{envPath\}[\s\S]{0,80}\breturn;/);
|
|
});
|