mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-14 10:52:17 +03:00
Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.
One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.
Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.
244 lines
8.5 KiB
TypeScript
244 lines
8.5 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
import { pathToFileURL } from "node:url";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-cloud-sync-"));
|
|
const ORIGINAL_DATA_DIR = process.env.DATA_DIR;
|
|
const ORIGINAL_CLOUD_URL = process.env.CLOUD_URL;
|
|
const ORIGINAL_PUBLIC_CLOUD_URL = process.env.NEXT_PUBLIC_CLOUD_URL;
|
|
const ORIGINAL_TIMEOUT = process.env.CLOUD_SYNC_TIMEOUT_MS;
|
|
const ORIGINAL_CLOUD_SECRETS = process.env.OMNIROUTE_CLOUD_SYNC_SECRETS;
|
|
const ORIGINAL_FETCH = globalThis.fetch;
|
|
const cloudSyncModuleUrl = pathToFileURL(path.join(process.cwd(), "src/lib/cloudSync.ts")).href;
|
|
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
// FASE-01: API_KEY_SECRET is required for CRC operations (no hardcoded fallback)
|
|
if (!process.env.API_KEY_SECRET) {
|
|
process.env.API_KEY_SECRET = "test-cloud-sync-secret-" + Date.now();
|
|
}
|
|
|
|
const coreDb = await import("../../src/lib/db/core.ts");
|
|
const providersDb = await import("../../src/lib/db/providers.ts");
|
|
const apiKeysDb = await import("../../src/lib/db/apiKeys.ts");
|
|
|
|
function createAbortError(message = "aborted") {
|
|
const error = new Error(message);
|
|
error.name = "AbortError";
|
|
return error;
|
|
}
|
|
|
|
async function loadCloudSync(label) {
|
|
return import(`${cloudSyncModuleUrl}?case=${label}-${Date.now()}-${Math.random()}`);
|
|
}
|
|
|
|
async function resetStorage() {
|
|
apiKeysDb.resetApiKeyState();
|
|
coreDb.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
|
|
globalThis.fetch = ORIGINAL_FETCH;
|
|
delete process.env.CLOUD_URL;
|
|
delete process.env.NEXT_PUBLIC_CLOUD_URL;
|
|
delete process.env.CLOUD_SYNC_TIMEOUT_MS;
|
|
delete process.env.OMNIROUTE_CLOUD_SYNC_SECRETS;
|
|
}
|
|
|
|
test.beforeEach(async () => {
|
|
await resetStorage();
|
|
});
|
|
|
|
test.after(() => {
|
|
apiKeysDb.resetApiKeyState();
|
|
coreDb.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
globalThis.fetch = ORIGINAL_FETCH;
|
|
if (ORIGINAL_DATA_DIR === undefined) {
|
|
delete process.env.DATA_DIR;
|
|
} else {
|
|
process.env.DATA_DIR = ORIGINAL_DATA_DIR;
|
|
}
|
|
if (ORIGINAL_CLOUD_URL === undefined) {
|
|
delete process.env.CLOUD_URL;
|
|
} else {
|
|
process.env.CLOUD_URL = ORIGINAL_CLOUD_URL;
|
|
}
|
|
if (ORIGINAL_PUBLIC_CLOUD_URL === undefined) {
|
|
delete process.env.NEXT_PUBLIC_CLOUD_URL;
|
|
} else {
|
|
process.env.NEXT_PUBLIC_CLOUD_URL = ORIGINAL_PUBLIC_CLOUD_URL;
|
|
}
|
|
if (ORIGINAL_TIMEOUT === undefined) {
|
|
delete process.env.CLOUD_SYNC_TIMEOUT_MS;
|
|
} else {
|
|
process.env.CLOUD_SYNC_TIMEOUT_MS = ORIGINAL_TIMEOUT;
|
|
}
|
|
if (ORIGINAL_CLOUD_SECRETS === undefined) {
|
|
delete process.env.OMNIROUTE_CLOUD_SYNC_SECRETS;
|
|
} else {
|
|
process.env.OMNIROUTE_CLOUD_SYNC_SECRETS = ORIGINAL_CLOUD_SECRETS;
|
|
}
|
|
});
|
|
|
|
test("cloudSync returns a configuration error when the cloud URL is missing", async () => {
|
|
const cloudSync = await loadCloudSync("no-url");
|
|
|
|
const result = await cloudSync.syncToCloud("machine-1");
|
|
|
|
assert.deepEqual(result, { error: "NEXT_PUBLIC_CLOUD_URL is not configured" });
|
|
});
|
|
|
|
test("fetchWithTimeout aborts when the timeout elapses", async () => {
|
|
process.env.NEXT_PUBLIC_CLOUD_URL = "https://cloud.example";
|
|
globalThis.fetch = (_url, options) =>
|
|
new Promise((_, reject) => {
|
|
options.signal.addEventListener("abort", () => reject(createAbortError()));
|
|
});
|
|
|
|
const cloudSync = await loadCloudSync("timeout-helper");
|
|
|
|
await assert.rejects(cloudSync.fetchWithTimeout("https://cloud.example/ping", {}, 5), {
|
|
name: "AbortError",
|
|
});
|
|
});
|
|
|
|
test("cloudSync maps timeout and transport failures to stable error messages", async () => {
|
|
process.env.NEXT_PUBLIC_CLOUD_URL = "https://cloud.example";
|
|
process.env.CLOUD_SYNC_TIMEOUT_MS = "5";
|
|
|
|
globalThis.fetch = (_url, options) =>
|
|
new Promise((_, reject) => {
|
|
options.signal.addEventListener("abort", () => reject(createAbortError("timeout")));
|
|
});
|
|
|
|
let cloudSync = await loadCloudSync("sync-timeout");
|
|
assert.deepEqual(await cloudSync.syncToCloud("machine-1"), { error: "Cloud sync timeout" });
|
|
|
|
globalThis.fetch = async () => {
|
|
throw new Error("socket closed");
|
|
};
|
|
cloudSync = await loadCloudSync("sync-failure");
|
|
assert.deepEqual(await cloudSync.syncToCloud("machine-1"), {
|
|
error: "Cloud sync request failed",
|
|
});
|
|
});
|
|
|
|
test("cloudSync returns a generic error when the API responds with a non-OK status", async () => {
|
|
process.env.CLOUD_URL = "https://cloud.example";
|
|
|
|
const originalConsoleLog = console.log;
|
|
const logged = [];
|
|
console.log = (...args) =>
|
|
logged.push(args.map((x) => (typeof x === "object" ? JSON.stringify(x) : String(x))).join(" "));
|
|
globalThis.fetch = async () =>
|
|
new Response("upstream unavailable", {
|
|
status: 503,
|
|
headers: { "Content-Type": "text/plain" },
|
|
});
|
|
|
|
try {
|
|
const cloudSync = await loadCloudSync("sync-non-ok");
|
|
const result = await cloudSync.syncToCloud("machine-1");
|
|
|
|
assert.deepEqual(result, { error: "Cloud sync failed" });
|
|
assert.equal(
|
|
logged.some((entry) => entry.includes("Cloud sync failed") && entry.includes("503")),
|
|
true
|
|
);
|
|
} finally {
|
|
console.log = originalConsoleLog;
|
|
}
|
|
});
|
|
|
|
test("cloudSync syncs data upstream and refreshes only locally stale provider tokens", async () => {
|
|
process.env.NEXT_PUBLIC_CLOUD_URL = "https://cloud.example";
|
|
process.env.OMNIROUTE_CLOUD_SYNC_SECRETS = "true";
|
|
|
|
const stale = await providersDb.createProviderConnection({
|
|
provider: "openai",
|
|
authType: "oauth",
|
|
email: "stale@example.com",
|
|
accessToken: "old-token",
|
|
refreshToken: "old-refresh",
|
|
providerSpecificData: { region: "us" },
|
|
});
|
|
const fresh = await providersDb.createProviderConnection({
|
|
provider: "anthropic",
|
|
authType: "oauth",
|
|
email: "fresh@example.com",
|
|
accessToken: "keep-token",
|
|
refreshToken: "keep-refresh",
|
|
providerSpecificData: { plan: "pro" },
|
|
});
|
|
await apiKeysDb.createApiKey("machine key", "machine-1");
|
|
|
|
const db = coreDb.getDbInstance();
|
|
db.prepare("UPDATE provider_connections SET updated_at = ? WHERE id = ?").run(
|
|
"2026-01-01T00:00:00.000Z",
|
|
stale.id
|
|
);
|
|
db.prepare("UPDATE provider_connections SET updated_at = ? WHERE id = ?").run(
|
|
"2026-03-01T00:00:00.000Z",
|
|
fresh.id
|
|
);
|
|
|
|
let postedBody = null;
|
|
globalThis.fetch = async (_url, options) => {
|
|
postedBody = JSON.parse(options.body);
|
|
const responseData = {
|
|
changes: { providers: 1 },
|
|
data: {
|
|
providers: {
|
|
[stale.id]: {
|
|
updatedAt: "2026-04-01T00:00:00.000Z",
|
|
accessToken: "new-token",
|
|
refreshToken: "new-refresh",
|
|
expiresAt: "2026-04-02T00:00:00.000Z",
|
|
expiresIn: 3600,
|
|
providerSpecificData: { region: "eu" },
|
|
status: "active",
|
|
lastError: null,
|
|
lastErrorAt: null,
|
|
errorCode: null,
|
|
rateLimitedUntil: null,
|
|
},
|
|
[fresh.id]: {
|
|
updatedAt: "2026-02-01T00:00:00.000Z",
|
|
accessToken: "should-not-overwrite",
|
|
refreshToken: "should-not-overwrite",
|
|
},
|
|
},
|
|
},
|
|
};
|
|
return new Response(JSON.stringify(responseData), {
|
|
status: 200,
|
|
headers: { "Content-Type": "application/json" },
|
|
});
|
|
};
|
|
|
|
const cloudSync = await loadCloudSync("sync-success");
|
|
const result = await cloudSync.syncToCloud("machine-1", "created-key-1");
|
|
const staleAfter = await providersDb.getProviderConnectionById((stale as { id: string }).id);
|
|
const freshAfter = await providersDb.getProviderConnectionById((fresh as { id: string }).id);
|
|
|
|
assert.equal(Array.isArray(postedBody.providers), true);
|
|
assert.equal(Array.isArray(postedBody.apiKeys), true);
|
|
assert.match(postedBody.version, /^[a-f0-9]{64}$/);
|
|
assert.equal(postedBody.providers.length, 2);
|
|
assert.equal(postedBody.apiKeys.length, 1);
|
|
assert.equal(result.success, true);
|
|
assert.equal(result.message, "Synced successfully");
|
|
assert.deepEqual(result.changes, { providers: 1 });
|
|
assert.equal(result.createdKey, "created-key-1");
|
|
assert.match(result.version, /^[a-f0-9]{64}$/);
|
|
assert.equal(staleAfter.accessToken, "new-token");
|
|
assert.equal(staleAfter.refreshToken, "new-refresh");
|
|
assert.equal(staleAfter.expiresIn, 3600);
|
|
assert.deepEqual(staleAfter.providerSpecificData, { region: "eu" });
|
|
assert.equal(staleAfter.testStatus, "active");
|
|
assert.equal(freshAfter.accessToken, "keep-token");
|
|
assert.deepEqual(freshAfter.providerSpecificData, { plan: "pro" });
|
|
});
|