mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-14 10:52:17 +03:00
37ecab3659
Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.
One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.
Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.
60 lines
2.2 KiB
TypeScript
60 lines
2.2 KiB
TypeScript
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
import assert from "node:assert/strict";
|
|
import test from "node:test";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-combo-empty-models-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
|
|
const { createComboSchema, updateComboSchema } =
|
|
await import("../../src/shared/validation/schemas/combo.ts");
|
|
const { getCopilotTool } = await import("../../src/lib/copilot/tools.ts");
|
|
const combosDb = await import("../../src/lib/db/combos.ts");
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
|
|
test.after(() => {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
test("an update cannot remove every model from a combo", () => {
|
|
assert.equal(updateComboSchema.safeParse({ models: [] }).success, false);
|
|
assert.equal(updateComboSchema.safeParse({ models: ["openai/gpt-4o-mini"] }).success, true);
|
|
assert.equal(updateComboSchema.safeParse({ name: "renamed" }).success, true);
|
|
});
|
|
|
|
test("creating a combo without a model is refused at the boundary", () => {
|
|
assert.equal(createComboSchema.safeParse({ name: "drafted", models: [] }).success, false);
|
|
assert.equal(createComboSchema.safeParse({ name: "drafted" }).success, false);
|
|
});
|
|
|
|
test("the copilot createCombo tool stores targets where the router looks for them", async () => {
|
|
const tool = getCopilotTool("createCombo");
|
|
assert.ok(tool);
|
|
|
|
await tool.handler({
|
|
name: "copilot-stored",
|
|
strategy: "priority",
|
|
targets: JSON.stringify([{ provider: "openai", model: "gpt-4o-mini", weight: 100 }]),
|
|
});
|
|
|
|
const stored = (await combosDb.getComboByName("copilot-stored")) as { models?: unknown[] } | null;
|
|
assert.ok(stored, "the combo should exist");
|
|
assert.equal(stored.models?.length, 1);
|
|
});
|
|
|
|
test("the copilot combo list counts the targets the router will use", async () => {
|
|
const list = getCopilotTool("listCombos");
|
|
assert.ok(list);
|
|
|
|
await combosDb.createCombo({
|
|
name: "dashboard-made",
|
|
strategy: "priority",
|
|
models: ["openai/gpt-4o-mini", "openai/gpt-4o"],
|
|
});
|
|
|
|
const output = await list.handler({});
|
|
assert.match(output, /\*\*dashboard-made\*\* — strategy: `priority` — 2 target\(s\)/);
|
|
});
|